/milestone v1.15
/stage alpha

/assign @PatrickLang

@PatrickLang , Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

Hey, @PatrickLang 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Hi @PatrickLang . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

Hi @PatrickLang , today is code freeze. I do not see a reply for any PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

/milestone v1.16
Still not ready. PRs and testing are still in progress. Pushing out.

Hi @PatrickLang , I'm a 1.16 Enhancement Shadow. Is this feature going to be released in alpha stage in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

/milestone v1.17
Not likely to complete in 1.16, still having issues getting containerd work on Windows moving forward.

/stage stable

Is there a documentation similar to https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/ on how to set up a node with containerd with a CNI and join it to the cluster? I was able to install containerd and join the node by kubeadm join with --cri-socket "npipe:////./pipe/containerd-containerd" but after adding flannel as CNI I get the following when scheduling a workload:

Warning  FailedCreatePodSandBox  4m1s                 kubelet, minion    Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf": error while ProvisionEndpoint(2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096,7BB417A4-9BC3-4006-9374-D9EC6DA41D32,2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf): failed to find HNSEndpoint 2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096: Endpoint 2d458087deb7544c67f6dccbc3702cd9938489380fc48da5e5038f1ea0fc6bdf_flannel.4096 not found

When using host-local CNI instead the pods at least start successfully but don't have any network adapters when running ipconfig.

That doesn't look like a containerd-related issue, but that Flannel was unable to set up the endpoint. Check the logs of the kube-flannel-ds-windows-amd64 pod to see if it gave you any useful HNS-related failure messages.

@lippertmarkus Could you open up a separate issue to discuss? Don't want to pollute the enhancement issue.

Hey @PatrickLang @marosset 👋 -- 1.20 Enhancements Shadow here. Just a friendly reminder that the Enhancements Freeze deadline is October 6th.

Do we still plan on graduating this to GA in 1.20?

Also, if time permits, can we please update the KEP to match the new format detailed in https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template?

Thanks for all of your hard work everyone!

Regards,
Jeremy

@MorrisLaw - Yes we plan to go GA in 1.20.
I can update the KEP to match the new format this week.

Hi @marosset,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Best,
Jeremy

Thanks @MorrisLaw!
I updated the initial issue comment to include PRs/bugfixes needed for GA.

Hello @marosset 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @marosset 👋

The docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

Thanks !

Hi @eagleusb Here is the doc PR for graduating to stable
kubernetes/website#24862

Hey @marosset 👋

Is this PR the last PR remaining to get this to GA in 1.20 or are there some other PRs that we should explicitly link to this issue?

Please keep in mind that we have these upcoming dates:

• Thursday, Nov 12th: Week 9 - Code Freeze
• Monday, Nov 23rd: Week 11 - Docs PR Ready for Review
  

If we miss the the code freeze, an exception will need to be made if we want to include it in the 1.20 milestone.

If there are some relevant k/k PRs, please link it here so we can accurately track them. Thank you Mark!

@MorrisLaw I linked one more PR for 1.20 (kubernetes/kubernetes#96396)
This is approved and I'm finishing up a little bit of extra manual validation around this right now.

Hi @marosset

It looks like all the PRs are finished. How does kubernetes/kubernetes#70189 fit in?

Are you expecting to fix this as well? Or fix at a later date?

Thanks!
Kirsten

Hi @kikisdeliveryservice We will need to address that at a later date as fixing this requires an Windows OS fix that is not yet released yet. This functionality also doesn't work with any other container runtimes on Windows so we are not treating it as a blocker from declaring containerD support on Windows stable.

The OS fixes are expected to be available in Nov or Dec 2020 so we'll target fixing kubernetes/kubernetes#70189 in v1.21

@michmike - FYI

Great thanks for the update!

/close

@marosset: Closing this issue.