Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building Kubernetes Without In-Tree Cloud Providers #1179

Closed
BenTheElder opened this issue Jul 29, 2019 · 24 comments · Fixed by #1761
Closed

Building Kubernetes Without In-Tree Cloud Providers #1179

BenTheElder opened this issue Jul 29, 2019 · 24 comments · Fixed by #1761
Assignees
@BenTheElder
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone
v1.17

Comments

@BenTheElder
Copy link
Member

BenTheElder commented Jul 29, 2019 •
edited by kacole2

Enhancement Description

  • One-line enhancement description (can be used as a release note): Enable building Kubernetes without the in-tree (legacy) cloud providers.
  • Kubernetes Enhancement Proposal: 20190729-building-without-in-tree-providers.md
  • Primary contact (assignee): @BenTheElder
  • Responsible SIGs: Cloud-Provider, Release
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.16)
    • Beta release target (x.y)
    • Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 29, 2019
@BenTheElder
Copy link
Member Author

/sig cloud-provider
/sig release

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 29, 2019
@BenTheElder BenTheElder mentioned this issue Jul 29, 2019
Merged
@kacole2
Copy link
Contributor

kacole2 commented Jul 29, 2019

@BenTheElder I'm sure you know Enhancement Freeze is tomorrow so this is your notice that #1180 needs to be merged by then. Thanks!

/milestone v1.16
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 29, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 29, 2019
@BenTheElder
Copy link
Member Author

Hi @kacole2, yes, @justaugustus suggested that we should probably file an extension for this since it:

  • isn't user facing
  • shouldn't be a risk to the release
  • already has a partially reviewed implementation of the github.com/kubernetes/kubernetes changes

I will go look into that now, as I suspect the addition of a KEP to cover at this point this means review will go into tomorrow at minimum, but the details now captured there were previously discussed with the owning parties and implemented successfully so I think we should be able to get this in 😅

@justaugustus justaugustus added this to In progress in SIG Release Jul 30, 2019
@kacole2
Copy link
Contributor

kacole2 commented Jul 31, 2019

@BenTheElder @justaugustus

Enhancement Freeze has passed for 1.16. The KEP at #1180 was never merged and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Jul 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 31, 2019
@BenTheElder
Copy link
Member Author

Thanks @kacole2, I've filed an exception request 🤞

@xmudrii xmudrii mentioned this issue Aug 5, 2019
Closed
6 tasks
@BenTheElder
Copy link
Member Author

KEP is merged and implementable in #1180

@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 12, 2019
@simplytunde
Copy link

simplytunde commented Aug 19, 2019 •
edited

@BenTheElder I am 1.16 Doc Lead. We need a placeholder PR against k/website(dev-1.16 branch) for this enhancement before Friday, Aug 23rd. Let me know how I can help to make this happen or if doc is not required.

@BenTheElder
Copy link
Member Author

Hi @simplytunde, this is not user facing and will not have any documentation on k/website.

@kacole2
Copy link
Contributor

kacole2 commented Aug 26, 2019

@BenTheElder will this have any K/K PRs that need to be tracked?

@BenTheElder
Copy link
Member Author

I thought I'd linked these here but seems I didn't! D'oh.

kubernetes/kubernetes#80353 pretty much implemented this and merged in K/K already.

We will probably want to do some follow ups eventually but I think we probably don't need to track them and some of them might hold until 1.17+ (CSI migration testing having integration with this will probably slip until at least 1.17..).

@mrbobbytables
Copy link
Member

Hey there @BenTheElder -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2019
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2020
@helayoty
Copy link
Member

helayoty commented Jan 15, 2020 •
edited

Hey there @BenTheElder -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, please list all relevant k/k PRs in this issue so they can be tracked properly.

Thanks!

@BenTheElder
Copy link
Member Author

cc @liggitt I think maybe we can call this one done actually ...?
we decided to add some tests to prevent regressions, those landed in 1.17.

@liggitt
Copy link
Member

liggitt commented Jan 16, 2020

sounds good

/close

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closing this issue.

In response to this:

sounds good

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Release automation moved this from In progress to Done (1.18) Jan 16, 2020
@palnabarun
Copy link
Member

Hi @liggitt @BenTheElder -- 1.19 Enhancements Lead here. Since, this enhancement graduated to stable, can you please also mark the KEP implemented? 🙂

/reopen
(Reopening in the interim until the KEP is marked implemented)

@k8s-ci-robot k8s-ci-robot reopened this Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

@palnabarun: Reopened this issue.

In response to this:

Hi @liggitt @BenTheElder -- 1.19 Enhancements Lead here. Since, this enhancement graduated to stable, can you please also mark the KEP implemented? 🙂

/reopen
(Reopening in the interim until the KEP is marked implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG Release automation moved this from Done (1.18) to In progress Apr 17, 2020
@palnabarun
Copy link
Member

/milestone v1.17

(since the enhancement was implemented in v1.17 cycle)

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Apr 29, 2020
@BenTheElder
Copy link
Member Author

/assign

@BenTheElder BenTheElder mentioned this issue May 9, 2020
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2020
@BenTheElder
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2020
SIG Release automation moved this from In progress to Done (1.19) Jul 29, 2020
@BenTheElder
Copy link
Member Author

Sorry for the delay, this is actually fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
v1.17
Development

Successfully merging a pull request may close this issue.

mark building without in-tree providers implemented BenTheElder/enhancements
9 participants
@BenTheElder @liggitt @kacole2 @mrbobbytables @palnabarun @simplytunde @k8s-ci-robot @fejta-bot @helayoty