Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinder in-tree to CSI driver migration #1489

Closed
2 tasks
davidz627 opened this issue Jan 21, 2020 · 40 comments · Fixed by #3462
Closed
2 tasks

Cinder in-tree to CSI driver migration #1489

davidz627 opened this issue Jan 21, 2020 · 40 comments · Fixed by #3462
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@davidz627
Copy link
Contributor

davidz627 commented Jan 21, 2020

Enhancement Description

Parent enhancement: #625
Public Migration testing CI: LINK

TODO

  • Replace design/KEP with specific one if needed
  • Link public migration testing CI
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2020
@davidz627
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020
@jeremyrickard
Copy link
Contributor

@davidz627 @dims @adisky I assume this is also being targeted for 1.18? The KEP currently doesn't have a Test Plan defined, it only references what is in the original design proposal. The release team would like to see the KEP updated to actually contain the test plan before enhancement freeze. We'll conditionally track this for 1.18 with that in mind if you're planning on going to beta in 1.18.

Thanks!

@jeremyrickard jeremyrickard added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 23, 2020
@jeremyrickard
Copy link
Contributor

/milestone v1.19

@dims
Copy link
Member

dims commented Mar 26, 2020

This is already done, please see kubernetes/kubernetes#85637 (comment)

@dims dims closed this as completed Mar 26, 2020
@msau42
Copy link
Member

msau42 commented Apr 21, 2020

/reopen
We should keep this issue open to track to GA

@k8s-ci-robot
Copy link
Contributor

@msau42: Reopened this issue.

In response to this:

/reopen
We should keep this issue open to track to GA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 21, 2020
@palnabarun
Copy link
Member

Hi @msau42 @davidz627 -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

As Jeremy mentioned above, it would be great if a test plan can be added before moving it to GA.


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

palnabarun commented May 11, 2020

Hi @msau42 @davidz627, pinging back as a reminder for the above. 🙂

@msau42
Copy link
Member

msau42 commented May 11, 2020

I think we should remain in beta for 1.19 and work towards stabilizing the feature as well as getting it bundled with the openstack cloud controller. @adisky do you plan to continue working on this?

@palnabarun
Copy link
Member

Thank you @msau42 for the update. I will update the tracking sheet accordingly. 👍

@palnabarun
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone May 12, 2020
@adisky
Copy link
Contributor

adisky commented May 29, 2020

I think we should remain in beta for 1.19 and work towards stabilizing the feature as well as getting it bundled with the openstack cloud controller. @adisky do you plan to continue working on this?

@msau42 I am no longer working on this, @chrigl @ramineni would be primary contacts.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2020
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

Hi @chrigl @ramineni @msau42

Enhancements Lead here. Any plans for this in 1.20?

Thanks!
Kirsten

@ramineni
Copy link
Contributor

@kikisdeliveryservice Let me check on this on what needs to be done , will get back.

@msau42
Copy link
Member

msau42 commented Sep 14, 2020

cc @jsafrane

@kikisdeliveryservice
Copy link
Member

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone:

The KEP must be merged in an implementable state
The KEP must have test plans (missing: need this for beta->GA)
The KEP must have graduation criteria

If you could please update to the new template and include the missing sections noted above that would be great. See for ref: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

I also note that the implementation history of the KEP also needs to be updated.

Thanks!
Kirsten

@ramineni
Copy link
Contributor

@kikisdeliveryservice Sorry for the delay . Looks like it wont be possible for 1.20 , will target for next.
Thanks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2021
@jsafrane
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2021
@jsafrane
Copy link
Member

/remove-lifecycle stale

Update after 1.23 GA: it's still beta, to be GA in 1.24

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2021
@xing-yang
Copy link
Contributor

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 11, 2022
@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 12, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jan 17, 2022

Hello @msau42, @davidz627 👋, 1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting stable for 1.24 and #3124 is the latest KEP PR, are these correct?

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review for stage stable that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

The status of this enhancement is track as at risk. Please update this issue description with appropriate stages as well. Thank you!

@Priyankasaggu11929
Copy link
Member

All of the above criteria are satisfied now that the KEP PR #3124 has been merged. This enhancement is ready for the upcoming 1.24 enhancements freeze. 🚀

For note, the status of this enhancement is now tracked now. Thank you so much!

@PI-Victor
Copy link
Member

Hi @msau42 @davidz627 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Mar 18, 2022

Hello @msau42 @davidz627 👋

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!


UPDATE (March 27, 2022)

From the PR updating KEP 1489 for milestone GA: #3124 (comment), I confirmed that kubernetes/kubernetes#107462 is the code implementation PR.

With that, the status of the enhancement is now tracked 🚀 . Thank you!

@PI-Victor
Copy link
Member

Hi @msau42 @davidz627, please have a docs placeholder PR open by the 31st of March deadline. This PR can be empty for the time being. Thank you!

@xing-yang
Copy link
Contributor

@PI-Victor Doc PR is already merged: kubernetes/website#32495
We are all set for this enhancement.

@Priyankasaggu11929 Priyankasaggu11929 added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label May 10, 2022
@Priyankasaggu11929
Copy link
Member

Hello @msau42 @davidz627 👋, 1.25 Enhancements team here.

This feature has been fully implemented and is now GA in K8s version 1.24. 🎉

Please update the kep.yaml file's status to implemented and close this issue.

This would help accurate tracking in the v1.25 cycle. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@jsafrane
Copy link
Member

Isn't it GA in 1.24? I filed #3462 to finish the KEP and close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.