Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured logging #1602

Open
39 tasks done
serathius opened this issue Mar 6, 2020 · 129 comments
Open
39 tasks done

Structured logging #1602

serathius opened this issue Mar 6, 2020 · 129 comments
Assignees
@pohly
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@serathius
Copy link
Contributor

serathius commented Mar 6, 2020 •
edited by logicalhan

Enhancement Description

Define standard structure for Kubernetes log messages, add methods to klog to enforce this structure, add ability to configure Kubernetes components to produce logs in JSON format and initiate migration to structured logging.

  • Kubernetes Enhancement Proposal: Structured Logging KEP
  • Primary contact (assignee): @serathius
  • Responsible SIGs: sig-instrumentation
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.19
    • Beta release target 1.23
    • GA release target 1.27
Alpha

Follow-up from main tasks:

Beta

Follow ups:

Please let me know if someone is interested in working on one of the tasks.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 6, 2020
@serathius
Copy link
Contributor Author

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 6, 2020
@serathius serathius mentioned this issue Mar 13, 2020
Merged
5 tasks
@serathius
Copy link
Contributor Author

/help

@k8s-ci-robot
Copy link
Contributor

@serathius:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 14, 2020
@yuzhiquan
Copy link
Member

interested in

@tanjunchen
Copy link
Member

/cc

@serathius
Copy link
Contributor Author

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

@serathius: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 16, 2020
@justaugustus justaugustus removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 16, 2020
@hase1128
Copy link

/cc

This was referenced Mar 17, 2020
Closed
Closed
@serathius
Copy link
Contributor Author

KEP was marked as "implementable", so we can start working on it.
I have created first two subtasks within specific repositories. I will add more as work progresses and new tasks are unblocked.

If your interested in contributing please volunteer directly on subtasks or ask for specific task here.

@gavinfish
Copy link
Contributor

/cc

@yuzhiquan yuzhiquan mentioned this issue Mar 18, 2020
Merged
@serathius serathius mentioned this issue Mar 19, 2020
Closed
@yuzhiquan yuzhiquan mentioned this issue Apr 1, 2020
Closed
@serathius
Copy link
Contributor Author

After discussing offline with @dims we concluded that upgrading klog will be non-trivial as we need to upgrade all references at once. Upgrade cannot be done partially as it would break klog configuration.

We considered two options:

  • [Preferred] Properly update of all dependencies
  • Aliasing in go modules

As we have a lot of time before 1.19 cut we would like to do it properly. I will create subtask with upgrade plan.

@serathius serathius mentioned this issue Apr 8, 2020
Closed
13 tasks
@fenggw-fnst
Copy link

/cc

@johnbelamaric
Copy link
Member

@serathius Enhancements shadow for v1.19 here. Do you see this as moving to alpha in 1.19?

@serathius
Copy link
Contributor Author

Yes, I think we are on track. We are finishing klog upgrade, after that next milestones will be really fast to implement.

@johnbelamaric johnbelamaric added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2020
@hosseinsalahi hosseinsalahi mentioned this issue Mar 21, 2022
Closed
20 tasks
@logicalhan
Copy link
Member

/assign @serathius

To make more detailed milestones for GA release (i.e. scheduler migration and the like).

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2022
@pohly
Copy link
Contributor

pohly commented Aug 11, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2022
@pohly
Copy link
Contributor

pohly commented Oct 27, 2022

At this point the plan is to convert code directly to contextual logging, so see there for progress tracking.

@LittleFox94 LittleFox94 mentioned this issue Dec 7, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2023
@harshanarayana
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2023
@pohly
Copy link
Contributor

pohly commented Apr 25, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2023
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@logicalhan
Copy link
Member

@pohly is this dependent on contextual logging?

@pohly
Copy link
Contributor

pohly commented Jun 22, 2023

Yes. We are now doing both together.

@gnufied
Copy link
Member

gnufied commented Oct 2, 2023

Are there any plans to migrate logs inside client-go to structured logs? https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/reflector.go#L295

@pohly
Copy link
Contributor

pohly commented Oct 2, 2023

Yes, most likely. Now that interaction with slog in Go 1.21 is clear(er), we can continue like we did so far based on klog+go-logr. I'm hoping to get confirmation from others for that plan in #4181.

@dashpole
Copy link
Contributor

@pohly @mengjiao-liu Based on #1602 (comment), I assume this will not progress to GA in 1.30?

@pohly
Copy link
Contributor

pohly commented Jan 18, 2024

/unassign @serathius
/assign

@dashpole: yes, let's keep it in beta. We keep chucking away at the code, but the conversion is not complete yet.

At some point we also need to find our whether JSON output really is being used. I'll need help from the SIG for this.

@k8s-ci-robot k8s-ci-robot assigned pohly and unassigned serathius Jan 18, 2024
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this issue Apr 5, 2024
@openshift-merge-bot
Merge pull request kubernetes#1602 from dhellmann/twie-2024-03-29
dbf62f3 
this-week: 2024-03-29
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024
@pohly
Copy link
Contributor

pohly commented Apr 18, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests