Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Terminating Endpoints #1669

Closed
andrewsykim opened this issue Apr 6, 2020 · 105 comments
Closed

Proxy Terminating Endpoints #1669

andrewsykim opened this issue Apr 6, 2020 · 105 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Apr 6, 2020

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 6, 2020
@andrewsykim
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2020
@johnbelamaric
Copy link
Member

@andrewsykim Based on the discussion it looks like you are still planning this for 1.19? If so I will make sure we track it in the release team.

@andrewsykim
Copy link
Member Author

andrewsykim commented May 5, 2020

@andrewsykim Based on the discussion it looks like you are still planning this for 1.19? If so I will make sure we track it in the release team.

I know there's a lot of other efforts in-flight in SIG Network so no worries if this slips v1.19. Assuming we're happy with what's proposed, I intend to work on this for v1.19

@johnbelamaric
Copy link
Member

We are trying to reduce content and risk in v1.19 so if you can defer to v1.20 that would be best.

@johnbelamaric
Copy link
Member

@andrewsykim Hi Andrew, tomorrow is Enhancements Freeze for 1.19, what's the decision? 1.19 or 1.20?

@andrewsykim
Copy link
Member Author

Happy to work on this for v1.19, KEP just needs approval/review at this point. If it slips to v1.20 that is okay with me as well :).

@johnbelamaric
Copy link
Member

Enhancements freeze is upon us, deferring to 1.20.

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 20, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@andrewsykim
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@thockin thockin added this to Proposed in Test-sig-network Sep 4, 2020
@thockin thockin moved this from Proposed to To Do in Test-sig-network Sep 4, 2020
@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim

Enhancements Lead here, do you still intend to target this for GA in 1.20?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim

Pinging again, is this to be included in 1.20?

Thanks
Kirsten

@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim @thockin

Another reminder: Enhancements Freeze is next Tuesday October 6th. If you intend for this enhancement to be included, please let me know. This KEP's graduation criteria says it's dependent on #1672 , but #1672 currently does not have any KEP associated with it. So if this were to proceed into 1.20, you would need to update the graduation criteria.

I also note that this KEP seems to be missing the PRR.

Thanks,
Kirsten

@andrewsykim
Copy link
Member Author

Sorry @kikisdeliveryservice this KEP was merged in v1.19, forgot to update the description with a link

@kikisdeliveryservice kikisdeliveryservice added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 30, 2020
@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim

Thanks for the update. A little confusion bc the graduation criteria says:

The graduation criteria of this KEP will largely depend on the graduation status of the EndpointSlice API. Once the terminating field is added to EndpointSlice API, this change in behavior will kick-in as soon as kube-proxy consumes EndpointSlice.

Is that correct? What do you expect to delivery in this release exactly? Can you update the KEP to provide some clarity?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

@andrewsykim

As a reminder Enhancements Freeze is October 6th, so you will need to update your KEP by that time to lay out the alpha (this release deliverable), alpha->beta, etc... graduation criteria as requested above.

Thanks!
Kirsten

@andrewsykim
Copy link
Member Author

Updated alpha graduation criteria here #2064

@kikisdeliveryservice
Copy link
Member

@andrewsykim This is great and much clearer!! 👍

@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim

Ping!

As a reminder your PR (#2064 ) needs to merge by EOD PST tomorrow October 6th to be included in the 1.20 Release. After that time you will need to request an exception.

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

#2064 merged! Updating tracking sheet now. 😄

@kikisdeliveryservice
Copy link
Member

Hey @andrewsykim

Sincethis Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten

@Atharva-Shinde Atharva-Shinde removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@thockin
Copy link
Member

thockin commented May 30, 2023

Next: Cleanup and close in 1.30

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 7, 2023
@ruheenaansari34
Copy link

Hello @andrewsykim 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage stable for 1.28 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up-to-date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with the appropriate stages as well. Thank you!

@VibhorChinda
Copy link

VibhorChinda commented Jun 22, 2023

Hello @andrewsykim @bowei 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @andrewsykim , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@ruheenaansari34
Copy link

Hey again @andrewsykim 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023.

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@VibhorChinda
Copy link

Hey @andrewsykim , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.
Thanks.

@Atharva-Shinde Atharva-Shinde added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 19, 2023
@Atharva-Shinde
Copy link
Contributor

Hey @andrewsykim 👋 Enhancements Lead here,
With kubernetes/kubernetes#117718 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@Rishit-dagli
Copy link
Member

Hey @andrewsykim , I apologize for the ping again but we are already past the deadline for having a draft docs PR make on kubernetes/website , could you please do this as soon as possible, it could be a PR with no content yet too.

@VibhorChinda
Copy link

Hello @andrewsykim 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@Rishit-dagli
Copy link
Member

Hey @kubernetes/sig-network-leads (sorry for another ping after https://kubernetes.slack.com/archives/C09QYUH5W/p1689977384967339),

I'm Rishit from the 1.28 Release Team. We had this KEP which is past the deadline for having a draft documentation PR for the 1.28 release. As indicated here the deadline to create a draft docs PR on kubernetes/website for the KEP was 20th July. Could you please take a look at this and populate the docs PR was 25th July?

@andrewsykim
Copy link
Member Author

Opened a PR to update feature gate reference in kubernetes/website#42229. Other docs were added in previous releases.

@npolshakova
Copy link

Hey @andrewsykim 👋 1.29 Enhancements Lead here, is there any more work planned for this KEP? Also is the milestone accurate (are you targeting v1.30 instead of v1.29?)

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 8, 2023
@aojea
Copy link
Member

aojea commented Sep 10, 2023

This KEP is finished, last step is to completely remove the feature tag from the code, that is why it targets 2 releases after GA

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2024
@thockin thockin closed this as completed Jan 28, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Graduating
Status: Deferred
Status: Tracked
Obsolete: SIG-Network KEPs (see https...
GA (merged, gate not removed)
Development

No branches or pull requests