Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Manager #1769

Open
12 of 16 tasks
cezaryzukowski opened this issue May 12, 2020 · 76 comments
Open
12 of 16 tasks

Memory Manager #1769

cezaryzukowski opened this issue May 12, 2020 · 76 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@cezaryzukowski
Copy link
Contributor

cezaryzukowski commented May 12, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

@cezaryzukowski: The label(s) sig/sig-node cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezaryzukowski
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2020
@cezaryzukowski
Copy link
Contributor Author

/kind kep
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory kind/feature Categorizes issue or PR as related to a new feature. labels May 12, 2020
@cezaryzukowski
Copy link
Contributor Author

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

@cezaryzukowski: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

Hey there @cezaryzukowski @bg-chun -- 1.19 Enhancements Lead here. I wanted to check in and see if you think this Enhancement will be graduating to Alpha in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

As an additional note, #1620 merged recently, adding production readiness review questions to the KEP template. We are not making it mandatory for the 1.19 release cycle, but it would be great if the PRR questionnaire is filled since the KEP PR is in flight.

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks! 🙂


The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@palnabarun
Copy link
Member

@cezaryzukowski @bg-chun -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@palnabarun palnabarun added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 20, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@palnabarun
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2020
@kikisdeliveryservice
Copy link
Member

Hi @cezaryzukowski @bg-chun !

Enhancements Lead here, do you still intend to do any work on this (alpha/beta/stable) for 1.20?

Thanks!
Kirsten

@cezaryzukowski
Copy link
Contributor Author

Hi @kikisdeliveryservice, yes w plan Alpha for v1.20 as a target.
Should we update the description above?

PS We planned Alpha for v1.19, but we couldn't make it.

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

Thanks for the update @cezaryzukowski !

As a reminder the KEP PR should also include a kep.yaml file, please see here for the templates:
https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

If you could also update the description to reflect alpha in 1.20 that would be great.

Best,
Kirsten

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Hi @cezaryzukowski @bg-chun

As a reminder Enhancements Freeze is next week ** Tuesday October 6th**. By that time your completed KEP PR will need to merge.

If you have any questions, please let me know

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

Update: the PR merged! 👍

@cezaryzukowski
Copy link
Contributor Author

@kikisdeliveryservice Many thanks for your support.

Do we need to do anything else beyond "KEP merged" to have this feature in v1.20?

@kikisdeliveryservice
Copy link
Member

Hi @cezaryzukowski at the moment, no. 😄 But you do have to keep to all of the remaining milestone deadlines such as Code Freeze (Nov 12th) and Test Freeze(Nov 23rd) as well as the Docs Placeholder PR deadline of Nov 6th.

As you go forward, also please link all PRs related to this enhancement on this issue.

Lmk if you have any questions!!! I'll be here 😄 and will remind you of upcoming important dates.

@cezaryzukowski
Copy link
Contributor Author

cezaryzukowski commented Oct 7, 2020

Hi @kikisdeliveryservice

That's grand, we know the exact schedule.

With respect to "Docs Placeholder PR", is there any template or guideline on how to prepare the docs?

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 7, 2020

Hi @cezaryzukowski !

So the placeholder PR is very simple. See: https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr. This tells the docs team that you intend on adding feature documentation. Later on you'll add that full documentation and work with the docs team. You just need to do the placeholder by Nov. 6th but the sooner the better =)

Also, going forward, please link the placeholder PR and any k/k PRs back to this issue so the team can track them.

If you have any questions, let me know 😸

Just to recap:
Upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze
Monday, Nov 23rd: Week 11 - Test Freeze

Thanks!
Kirsten

@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 18, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member

/remove-lifecycle rotten
/reopen

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Sep 15, 2023
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 15, 2023
@SergeyKanzhelev
Copy link
Member

/assign @itzhak

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: GitHub didn't allow me to assign the following users: Itzhak.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @itzhak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member

/milestone v1.29
/stage stable
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.22, v1.29 Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Sep 15, 2023
@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Sep 15, 2023

@Tal-or please send PR to update KEP metadata for 1.29 gradution

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@SergeyKanzhelev
Copy link
Member

/assign @Tal-or

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: GitHub didn't allow me to assign the following users: Tal-or.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tal-or
Copy link

Tal-or commented Sep 18, 2023

@Tal-or please send PR to update KEP metadata for 1.29 gradution

Thank you @SergeyKanzhelev, sure.
I'll get to that ASAP

@Tal-or
Copy link

Tal-or commented Sep 28, 2023

Hello @SergeyKanzhelev, just sent #4251 updating KEP metadata for 1.29 graduation.

@AnaMMedina21
Copy link

AnaMMedina21 commented Sep 29, 2023

Hola @cezaryzukowski @Tal-or 👋, v1.29 Enhancements team here.

I am just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2023..

This enhancement is targeting for stage stable for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo. [waiting on merge for KEP-1769: Graduate Memory Manager to GA #4251]
  • KEP status is marked as implementable for latest-milestone: { v1.29}. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). [waiting on merge for KEP-1769: Graduate Memory Manager to GA #4251]

The status of this enhancement is marked as Tracked for Enhancements Freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Tal-or
Copy link

Tal-or commented Sep 29, 2023

For tracking of graduation of this feature to GA:

  • One-line enhancement description (can be used as a release note): Graduate Kubelet Memory Manager to GA
  • Kubernetes Enhancement Proposal: KEP-1769: Graduate Memory Manager to GA #4251
  • Primary contact (assignee): @Tal-or
  • Responsible SIGs: sig-node
  • Enhancement status: Tracked for Enhancements Freeze
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.21
    • Beta release target (x.y): 1.22
    • Stable release target (x.y): 1.29

Additional references:

  1. KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1769-memory-manager

@AnaMMedina21
Copy link

Hey @cezaryzukowski @Tal-or 👋, v1.29 Enhancements team here, checking in once more as we approach the v1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October 2023. The status of this enhancement is marked as At Risk for Enhancements Freeze. It looks like #4251 is still open and has a few questions open that might require more time. Let me know if I missed anything. Thank you!

@npolshakova
Copy link

Hello 👋, 1.29 Enhancements Lead here.
Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze.
Feel free to file an exception to add this back to the release tracking process. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Oct 6, 2023
@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Removed from Milestone
Development

No branches or pull requests