Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set a pod’s hostname to its Fully Qualified Domain Name (FQDN) #1797

Closed
javidiaz opened this issue May 18, 2020 · 52 comments
Closed

Allow users to set a pod’s hostname to its Fully Qualified Domain Name (FQDN) #1797

javidiaz opened this issue May 18, 2020 · 52 comments
Assignees
@javidiaz
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Test-sig-network Obsolete: SIG-Network KEPs (see https...
Milestone
v1.25

Comments

@javidiaz
Copy link
Contributor

javidiaz commented May 18, 2020 •
edited by kikisdeliveryservice

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 18, 2020
@javidiaz
Copy link
Contributor Author

javidiaz commented May 18, 2020 •
edited

/sig network
/sig node

@javidiaz javidiaz mentioned this issue May 18, 2020
Merged
javidiaz added a commit to javidiaz/enhancements that referenced this issue May 18, 2020
@javidiaz
Fqdn hostname KEP
0b601f2 
This proposal gives users the ability to set a pod’s hostname to
its Fully Qualified Domain Name (FQDN). A new PodSpec field `fqdnInHostname`
will be introduced. When a user sets this field to true, its Linux kernel
hostname field ([the nodename field of struct utsname]http://man7.org/linux/man-pages/man2/uname.2.html))
will be set to its fully qualified domain name (FQDN). Hence, both uname -n
and hostname --fqdn will return the pod’s FQDN. The new PodSpec field `fqdnInHostname`
will default to `false` to preserve current behavior, i.e., setting the hostname
field of the kernel to the pod's shortname.

Related issue is: kubernetes#1797
@javidiaz
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2020
@javidiaz
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label May 20, 2020
@javidiaz
Copy link
Contributor Author

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

@javidiaz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

@javidiaz -- Your exception request was approved. I have updated the tracking sheet accordingly.

@palnabarun
Copy link
Member

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 22, 2020
@palnabarun
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 22, 2020
@palnabarun palnabarun added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 22, 2020
@palnabarun
Copy link
Member

@javidiaz -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@zestrells
Copy link

Hi @javidiaz - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

@javidiaz
Copy link
Contributor Author

@javidiaz -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂

Thanks @palnabarun, I will put them in here. So far I have one kubernetes/kubernetes#91035

@javidiaz
Copy link
Contributor Author

Hi @javidiaz - My name is Zachary, 1.19 Docs shadow. Is this enhancement work planned for 1.19 and does it require any new docs (or modifications to existing docs)? If not, can you please update the 1.19 Enhancement Tracker Sheet, or let me know, I can do it for you :)
If docs are required, just a friendly reminder that we are looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks @zestrells for info. I will need to add some docs.

javidiaz added a commit to javidiaz/website that referenced this issue May 26, 2020
@javidiaz
[WIP] Documentation for new feature hostnameFQDN
b18388b 
KEP: kubernetes/enhancements#1797
kubernetes/enhancements#1792
@javidiaz javidiaz mentioned this issue May 26, 2020
Merged
@javidiaz
Copy link
Contributor Author

@zestrells I created a PR for docs, how do I update the 1.19 Enhancement Tracker Sheet?

javidiaz added a commit to javidiaz/website that referenced this issue May 26, 2020
@javidiaz
[WIP] Documentation for new feature hostnameFQDN
0e42f1d 
KEP: kubernetes/enhancements#1797
kubernetes/enhancements#1792
@zestrells
Copy link

@javidiaz I can update the tracker sheet. Thank you for the docs :)

@palnabarun
Copy link
Member

Thanks @javidiaz for the update on the implementation PR. 👍

I have updated the update the tracking sheet.

This was referenced Jun 2, 2020
Closed
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2021
@javidiaz
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2021
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/stage stable
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 5, 2021
@jrsapi
Copy link

jrsapi commented May 11, 2021

Greetings @javidiaz ! 1.22 Enhancement shadow checking in. After reviewing the KEP overall is in great shape. Just a small edit needed:

  • In the kep.yaml, update the value for latest-milestone to "v1.22"

Reminder that the Enhancement freeze is this Thursday.

Thanks!

@javidiaz
Copy link
Contributor Author

Greetings @javidiaz ! 1.22 Enhancement shadow checking in. After reviewing the KEP overall is in great shape. Just a small edit needed:

* In the kep.yaml, update the value for latest-milestone to "v1.22"

Reminder that the Enhancement freeze is this Thursday.

Thanks!

Thanks for the reminder @jrsapi ! I have a PR waiting to be approved to update the KEP #2641

@javidiaz
Copy link
Contributor Author

Greetings @javidiaz ! 1.22 Enhancement shadow checking in. After reviewing the KEP overall is in great shape. Just a small edit needed:

* In the kep.yaml, update the value for latest-milestone to "v1.22"

Reminder that the Enhancement freeze is this Thursday.
Thanks!

Thanks for the reminder @jrsapi ! I have a PR waiting to be approved to update the KEP #2641

@jrsapi Could you add milestone to the PRs associated with this KEP? the full list is #2641 kubernetes/kubernetes#101294 and kubernetes/website#27636

@ehashman
Copy link
Member

The milestones will be automatically added, they're not required.

@jrsapi
Copy link

jrsapi commented May 13, 2021

Greetings @javidiaz!
Thanks for the follow-up. After reviewing the KEP and approved PRR this enhancement is now being tracked for the 1.22 milestone.

Thanks!

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 9, 2021
@jrsapi
Copy link

jrsapi commented Jul 6, 2021 •
edited

Greetings @javidiaz,
1.22 Enhancements shadow checking in with a few reminders. Code freeze is this Thursday, July 7th. We're tracking the following PR kubernetes/kubernetes#101294 for this KEP. Is this the only K/K PR needed to implement this?
Also, the Docs PR placeholder deadline is this Friday, July 8th and we are tracking the following k/website PR #2641.
We are marking this KEP tracked for the 1.22 milestone.

Thanks!

@javidiaz
Copy link
Contributor Author

javidiaz commented Jul 6, 2021

Greetings @javidiaz,
1.22 Enhancements shadow checking in with a few reminders. Code freeze is this Thursday, July 7th. We're tracking the following PR kubernetes/kubernetes#101294 for this KEP. Is this the only K/K PR needed to implement this?
Also, the Docs PR placeholder deadline is this Friday, July 8th and we are tracking the following k/website PR #2641.
We are marking this KEP tracked for the 1.22 milestone.

Thanks!

Thanks @jrsapi! yes , those 2 PRs are all I needed.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 18, 2021
@salaxander
Copy link

Hi @javidiaz - Could you open a PR on the KEP to change the status to implemented? At that point we can close out the issue :)

Thanks!

@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 19, 2021
@javidiaz javidiaz mentioned this issue Aug 24, 2021
Merged
@javidiaz
Copy link
Contributor Author

Hi @javidiaz - Could you open a PR on the KEP to change the status to implemented? At that point we can close out the issue :)

Thanks!

Thanks @salaxander , I created a PR.

@salaxander
Copy link

Closing out now that we're fully implemented :) Awesome job everyone!

@thockin thockin modified the milestones: v1.22, v1.25 Feb 16, 2022
@thockin
Copy link
Member

thockin commented Feb 16, 2022

Reminder: Remove gate in 1.25, milestone updated

@thockin thockin moved this from GA (merged, gate not removed) to GA (merged, gate removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javidiaz javidiaz

Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Obsolete: SIG-Network KEPs (see https...
DONE (GA, merged, gate removed)
Test-sig-network
  
Alpha
Milestone
v1.25
Development

No branches or pull requests