Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto remove PVCs created by StatefulSet #1847

Open
1 of 4 tasks
kk-src opened this issue Jun 6, 2020 · 103 comments
Open
1 of 4 tasks

Auto remove PVCs created by StatefulSet #1847

kk-src opened this issue Jun 6, 2020 · 103 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@kk-src
Copy link

kk-src commented Jun 6, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Auto remove PVCs created by StatefulSet

  • Kubernetes Enhancement Proposal: KEP-1847: Auto remove PVCs created by StatefulSet.

  • Primary contact (assignee): @mattcary

  • Responsible SIGs: @sig-apps (with collaboration by @sig-storage)

  • Enhancement target (which target equals to which milestone):

    • Alpha release target 1.23
    • Beta release target 1.27
    • Stable release target TBD

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

Resolves kubernetes/kubernetes#55045

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 6, 2020
@k8s-ci-robot
Copy link
Contributor

@kk-src: The label(s) sig/sig-storage cannot be applied, because the repository doesn't have them

In response to this:

/sig sig-storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kk-src
Copy link
Author

kk-src commented Jun 6, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2020
@kk-src
Copy link
Author

kk-src commented Jun 6, 2020

/assign

@pacoxu
Copy link
Member

pacoxu commented Jun 19, 2020

@kubernetes/sig-storage-feature-requests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-feature-requests

In response to this:

@kubernetes/sig-storage-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor

CC @dsu-igeek

@kk-src
Copy link
Author

kk-src commented Jun 19, 2020

Having discussions with @dsu-igeek @msau42 @mattcary
Should have a KEP with the proposal in shortly.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2020
@kikisdeliveryservice
Copy link
Member

Hi @kk-src

Enhancements Lead here. Will there be any work for this in 1.20?

Also, as a reminder to be included in a release:

The KEP must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

Thanks
Kirsten

@kikisdeliveryservice
Copy link
Member

As per #1915 (comment)

marking this is as tracked.

Please note that Enhancements Freeze is October 6th, by which time to be included in the milestone:
The KEP must be merged in an implementable state (not yet merged & provisional)
The KEP must have test plans (missing)
The KEP must have graduation criteria (missing)

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2020
@kikisdeliveryservice
Copy link
Member

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 24, 2020
@mikejoh
Copy link

mikejoh commented Sep 29, 2020

Hi @kk-src 👋!

I'm one of the Enhancement shadows for the 1.20 release cycle. This is a friendly reminder that the Enhancement freeze is roughly one week from now on the 6th of October. I'm repeating the requirements needed by then:

  • The KEP must be merged in an implementable state.
    • It's provisional at the moment.
  • The KEP must have test plans.
    • Missing in the KEP.
  • The KEP must have graduation criteria.
    • Also missing in the KEP.

Let us know if you have any questions etc.!

Thanks!

@mikejoh
Copy link

mikejoh commented Oct 5, 2020

As a reminder, the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

@kikisdeliveryservice
Copy link
Member

Hi @kk-src

Enhancements Freeze is now in effect. Unfortunately, your KEP PR has not merged. If you wish to be included in the 1.20 Release, please submit an Exception Request as soon as possible.

Best,
Kirsten
1.20 Enhancements Lead

@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Oct 7, 2020
@kk-src
Copy link
Author

kk-src commented Oct 9, 2020

/remove-lifecycle stale

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@mattcary
Copy link
Contributor

mattcary commented Feb 7, 2023

/tracked

@soltysh
Copy link
Contributor

soltysh commented Feb 8, 2023

@mattcary the release team only has the power to mark KEP as tracked, they are continuously monitoring the KEPs, we just need to wait for @fsmunoz to re-visit this issue.

@mattcary
Copy link
Contributor

mattcary commented Feb 8, 2023

Ah, thank you! I didn't realize.

@fsmunoz
Copy link

fsmunoz commented Feb 8, 2023

Thank you @mattcary ! The changes cover the previous points, but the markdown formatting seems off in the Scalability section: subheadings are cut short and the rest appears as text. Could you take a look? Thanks!

@mattcary
Copy link
Contributor

mattcary commented Feb 8, 2023

Oops, thanks for catching that.

#3856

@fsmunoz
Copy link

fsmunoz commented Feb 9, 2023

@mattcary thank you!

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to beta in v1.27.

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2023
@Rishit-dagli
Copy link
Member

Hi @kk-src 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@mattcary
Copy link
Contributor

@Rishit-dagli is this not the right placeholder pr? kubernetes/website#39819

@msau42
Copy link
Member

msau42 commented Mar 10, 2023

@mattcary there is also the k8s documentation that updates the feature gate table, user guide, etc.

@mattcary
Copy link
Contributor

Done! kubernetes/website#39926

@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

Hi @kk-src , @mattcary 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs need to merge:

This is based on information shared here, given the inability of the lead to change the issue description.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@mattcary
Copy link
Contributor

Hi, I'm leading this bug, but don't have access to change the issue description.

The pending PR is kubernetes/website#39926.

@mattcary
Copy link
Contributor

Oops, sorry that's the wrong PR. kubernetes/kubernetes#116501 is the right pending PR.

@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

@mattcary thank you, I've updated the status above.

@marosset marosset removed kind/feature Categorizes issue or PR as related to a new feature. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 20, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@npolshakova
Copy link

Hi @carlory, Is this targeting 1.29? If it is, can you add the lead-opted-in label so that the enhancement is tracked? Thanks!

@mattcary
Copy link
Contributor

sorry for missing this -- we're pushing this to 1.30 so we can collect more usage data, see #4197 (comment)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@carlory
Copy link
Member

carlory commented Jan 30, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Graduating
Status: Tracked
Status: Needs Triage
Development

No branches or pull requests