Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downward API support for hugepages #2053

Closed
6 tasks done
derekwaynecarr opened this issue Oct 2, 2020 · 34 comments
Closed
6 tasks done

Add downward API support for hugepages #2053

derekwaynecarr opened this issue Oct 2, 2020 · 34 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Oct 2, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 2, 2020
@derekwaynecarr
Copy link
Member Author

After reflecting on the implementation PR: kubernetes/kubernetes#86102

I think this needs a KEP as it loosens validation, and as a result, the feature requires that all kubelets have the support enabled before the API server accepts its usage. Will write a quick KEP now.

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 2, 2020
@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Oct 2, 2020
@kikisdeliveryservice
Copy link
Member

Took a quick 👀 and the kep would need alpha graduation criteria but other than that it has the testplans, implementable state, etc... So would need that update and to merge before October 6th

@kikisdeliveryservice
Copy link
Member

PR #2055 was updated and now it meets the criteria (pending sig-node review ofc), we'll just need this to merge by October 6th to be included in 1.20

@kinarashah
Copy link

Hi @derekwaynecarr,

Enhancement shadow for 1.20 release team here 👋 ,

Just a reminder that the Enhancements Freeze is Tomorrow October 6th EOD PST. All KEPs and updates must be merged by that time. After October 6th, you will need to request an Exception to be included in the 1.20 Release.

Thank you.

@kinarashah
Copy link

kinarashah commented Oct 11, 2020

Hi @derekwaynecarr ,

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

@annajung
Copy link
Contributor

Hello @derekwaynecarr 👋 , 1.20 Docs lead here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@annajung
Copy link
Contributor

annajung commented Nov 1, 2020

Hi @derekwaynecarr

The docs placeholder deadline is this Friday. Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline

Also, please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@derekwaynecarr
Copy link
Member Author

@annajung placeholder pr is kubernetes/website#24904

@kikisdeliveryservice
Copy link
Member

Hey @derekwaynecarr

it looks like all the k/k prs for this have merged, correct?

Thanks!
Kirsten

@kikisdeliveryservice
Copy link
Member

Confirmed with Derek that this is completed for code freeze.

@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@derekwaynecarr
Copy link
Member Author

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 8, 2021
@annajung annajung added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 8, 2021
@annajung
Copy link
Contributor

Hi @derekwaynecarr

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@annajung
Copy link
Contributor

annajung commented Mar 1, 2021

Hi @derekwaynecarr

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@sjenning
Copy link
Contributor

sjenning commented Mar 2, 2021

e2e test for this kubernetes/kubernetes#99612

@annajung
Copy link
Contributor

annajung commented Mar 4, 2021

Hey @derekwaynecarr

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Enhancements team is currently tracking the following PR(s):

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert saschagrunert reopened this Jan 10, 2023
@saschagrunert
Copy link
Member

Targeting stable for Kubernetes v1.27.

@saschagrunert saschagrunert removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 10, 2023
@saschagrunert saschagrunert added lead-opted-in Denotes that an issue has been opted in to a release and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 11, 2023
@saschagrunert saschagrunert modified the milestones: v1.21, v1.27 Jan 11, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @derekwaynecarr @saschagrunert 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@johnbelamaric
Copy link
Member

Can we get the KEP updated and make sure all the stable PRR questions are answered ASAP?

@johnbelamaric
Copy link
Member

Oh, I see the PR here: #3719

In the future please tag the issue so it shows up on here.

@saschagrunert
Copy link
Member

Updating the test section in #3865

Should be mostly a no-op, since it's only a formal change.

@SergeyKanzhelev
Copy link
Member

Production readiness completed

stable:
approver: "@johnbelamaric"

and template updated to the latest including the test plan.

@Atharva-Shinde this KEP should be good to go

@marosset
Copy link
Contributor

This enhancement meets all the requirements to be tracked for v1.27
Thanks @saschagrunert @SergeyKanzhelev

@marosset marosset added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 10, 2023
@katmutua
Copy link
Member

katmutua commented Mar 9, 2023

Hello @saschagrunert and @SergeyKanzhelev 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

@saschagrunert
Copy link
Member

Thank you @katmutua, the placeholder PR is now available in kubernetes/website#39905

@Atharva-Shinde
Copy link
Contributor

Hey again @saschagrunert @SergeyKanzhelev 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@marosset
Copy link
Contributor

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 20, 2023
@saschagrunert
Copy link
Member

This is done

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
Development

No branches or pull requests