Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cAdvisor json metrics from the Kubelet #2129

Closed
4 tasks
dashpole opened this issue Nov 4, 2020 · 16 comments · Fixed by #2562
Closed
4 tasks

Remove cAdvisor json metrics from the Kubelet #2129

dashpole opened this issue Nov 4, 2020 · 16 comments · Fixed by #2562
Assignees
@pacoxu
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone
v1.21

Comments

@dashpole
Copy link
Contributor

dashpole commented Nov 4, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note):
  • Kubernetes Enhancement Proposal:
  • Discussion Link: Reduce the set of metrics exposed by the kubelet kubernetes#68522 (comment)
  • Primary contact (assignee): dashpole
  • Responsible SIGs: node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.21
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 4, 2020
@dashpole
Copy link
Contributor Author

dashpole commented Nov 4, 2020

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 10, 2020
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 4, 2021
@annajung annajung added this to the v1.21 milestone Feb 6, 2021
@annajung
Copy link
Contributor

annajung commented Feb 7, 2021

Hi @dashpole

Enhancements Freeze is 2 days away, Feb 9th EOD PST

Enhancements team is aware that KEP update is currently in progress (PR #2130). Please make sure PR merges before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in slack #prod-readiness

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@pacoxu
Copy link
Member

pacoxu commented Feb 19, 2021

/assign
Can I send a PR for this?

@pacoxu pacoxu mentioned this issue Feb 19, 2021
Merged
@dashpole
Copy link
Contributor Author

yes, feel free to work on this.

@arunmk
Copy link

arunmk commented Feb 20, 2021

Hi @dashpole, @pacoxu,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@pacoxu
Copy link
Member

pacoxu commented Feb 20, 2021

@arunmk Thanks for reminding.

The pr is ready for review now.

@arunmk
Copy link

arunmk commented Mar 2, 2021

Hi @pacoxu,

Enhancements team is currently tracking the following PR

With the PR merged, can we mark this enhancement complete for code freeze or do you have other PR(s) that are being worked on as part of the release?

Thanks

@ehashman ehashman mentioned this issue Mar 3, 2021
Merged
@pacoxu
Copy link
Member

pacoxu commented Mar 4, 2021 •
edited

@arunmk I think so.
@dashpole Would you confirm?

I will check/update the docs in website for 1.21 next week.

@dashpole
Copy link
Contributor Author

dashpole commented Mar 4, 2021

This enhancement is complete. We can mark the KEP as implemented.

This was referenced Mar 10, 2021
Merged
Merged
@pacoxu
Copy link
Member

pacoxu commented Mar 25, 2021

website is updatd.
@dashpole We may close this after #2562 is merged.

@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 3, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@pacoxu pacoxu mentioned this issue Aug 6, 2021
Merged
13 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 1, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacoxu pacoxu

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
v1.21
Development

Successfully merging a pull request may close this issue.

[1.21]mark Disable CAdvisor Json Metrics as implemented pacoxu/enhancements
8 participants
@JamesLaverack @pacoxu @dashpole @kikisdeliveryservice @arunmk @k8s-ci-robot @annajung @k8s-triage-robot