Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random Pod selection on ReplicaSet downscaling #2185

Open
5 of 8 tasks
alculquicondor opened this issue Dec 15, 2020 · 57 comments
Open
5 of 8 tasks

Random Pod selection on ReplicaSet downscaling #2185

alculquicondor opened this issue Dec 15, 2020 · 57 comments
Assignees
@damemi @MinpengJin
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Dec 15, 2020 •
edited by janetkuo

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 15, 2020
@alculquicondor
Copy link
Member Author

/sig apps
/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2020
@alculquicondor alculquicondor mentioned this issue Dec 15, 2020
Closed
@alculquicondor
Copy link
Member Author

cc @damemi

@damemi
Copy link
Contributor

damemi commented Dec 15, 2020

/assign

@damemi
Copy link
Contributor

damemi commented Jan 5, 2021

Haven't fogotten about this, just didn't get it in time for the new year... will open a PR soon based on @alculquicondor's draft

@damemi damemi mentioned this issue Jan 6, 2021
Merged
@damemi
Copy link
Contributor

damemi commented Jan 6, 2021

Filled out most of the sections and opened a KEP here: #2233

Looking for anything I missed or could improve on. Pretty straightforward mostly since it's not affecting a user-documented behavior

@annajung annajung added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2021
@annajung annajung added this to the v1.21 milestone Feb 5, 2021
@annajung annajung added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 5, 2021
@jrsapi
Copy link

jrsapi commented Feb 18, 2021

Greetings @damemi!
Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
• Tuesday, March 9th: Week 9 - Code Freeze
• Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
• If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.
Thanks!

@damemi
Copy link
Contributor

damemi commented Feb 18, 2021

xref - wip PR kubernetes/kubernetes#96898

I'll be picking up this PR and working to get that merged for code freeze. Thanks for the update @jrsapi !

@damemi damemi mentioned this issue Feb 18, 2021
Merged
@damemi
Copy link
Contributor

damemi commented Feb 18, 2021

Opened new PR in kubernetes/kubernetes#99212

@jrsapi
Copy link

jrsapi commented Mar 4, 2021

Greetings @damemi,

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST
Any enhancements that are NOT code complete by the freeze will be removed from the milestone will require an exception to be added back.
Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST.
Thanks!

@alculquicondor
Copy link
Member Author

Should we consider any updates to documentation for this? https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/#scaling-a-replicaset

Current documentation doesn't give any details about internal selection, which might still be desired.

@janetkuo @soltysh

@janetkuo
Copy link
Member

janetkuo commented Mar 8, 2021

Yes, please update docs and the feature gate for this.

@PI-Victor
Copy link
Member

Hello @damemi, 1.21 Docs shadow here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@damemi damemi mentioned this issue Mar 10, 2021
Open
@damemi
Copy link
Contributor

damemi commented Mar 10, 2021

Yeah, I will open a PR to update the docs Aldo linked above

@damemi damemi mentioned this issue Mar 10, 2021
Merged
@damemi
Copy link
Contributor

damemi commented Mar 10, 2021

Docs PR opened at kubernetes/website#26993, which just copies the comments from code into the docs

@reylejano reylejano mentioned this issue Mar 25, 2021
Merged
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@damemi
Copy link
Contributor

damemi commented May 3, 2022

@alculquicondor did this ever move to GA?

@alculquicondor
Copy link
Member Author

/reopen

No, still beta

@k8s-ci-robot k8s-ci-robot reopened this May 3, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen

No, still beta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@janetkuo
Copy link
Member

I removed 1.23 from Stable release target (x.y) in the issue description to avoid confusion.

@soltysh
Copy link
Contributor

soltysh commented Jun 8, 2022

/milestone clear
since you can always check the latest-milestone in https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2185-random-pod-select-on-replicaset-downscale/kep.yaml

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone Jun 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor

soltysh commented Mar 6, 2023

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

@soltysh: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuzhenglun
Copy link
Contributor

is any plan to GA this enhancement?

@alculquicondor
Copy link
Member Author

/reopen
This is open for contributors

@k8s-ci-robot k8s-ci-robot reopened this Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen
This is open for contributors

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MinpengJin
Copy link

Is there anything else that needs to be done for this feature?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuzhenglun
Copy link
Contributor

xuzhenglun commented Apr 19, 2024 •
edited

/reopen This is open for contributors

Is there anything else required before GA? Could you please clarify the clues, and I'm glad to follow with that. @alculquicondor

@alculquicondor
Copy link
Member Author

/reopen

Nothing major, just to follow the process of graduation: update KEP, answer any new PRR questions, update code.

@k8s-ci-robot k8s-ci-robot reopened this Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen

Nothing major, just to follow the process of graduation: update KEP, answer any new PRR questions, update code.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuzhenglun
Copy link
Contributor

so, Iet's do that.

/assign @MinpengJin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damemi damemi

@MinpengJin MinpengJin

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests