/sig node

https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2254-cgroup-v2

Seems to need update as it says: "OCI runtime spec: TODO" and "OCI will need support for cgroups v2"

Instead of referring to: https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#unified

I have already submitted a PR to update the information: #2507

@giuseppe We are working on supporting cgroup v2 of Kubernetes in our production in Tencent, including new addition, such as memory.high / memory.low, io controller. We really want to contribute to the community with cgroup v2 and resource qos, please contact me if need.

/cc

/milestone v1.22

Hi @giuseppe , 1.22 enhancements team here

For the enhancement to be included in the milestone, it must meet the following criteria:

• [DONE] The KEP must be merged in an implementable state
• The KEP must have test plans
• [DONE] The KEP must have graduation criteria
• The KEP must have a production readiness review

In order to move forward in 1.22 we'd need to have test plans as well as a production readiness review before enhancements freeze on 5/13. Feel free to reference the KEP template here -> https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks!!

If you get there please assign me as PRR approver. Thanks.

@johnbelamaric it's up here: #2689

But questionnaire isn't filled out, I'll leave a comment.

@ehashman as long as that merges before enhancements freeze tomorrow evening we're good to go!

Hi @giuseppe ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

Hi @giuseppe ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

opened a draft PR here: kubernetes/website#28106

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

do you have any example of what should end up in the documentation for this feature?

Hey @giuseppe - Just checking in as we're about 2 weeks away from code freeze for 1.22. Are there any open or closed k/k PRs for the milestone that we should be tracking? Or is kubernetes/kubernetes#85218 everything planned for 1.22?

@salaxander thanks for asking. There is nothing more planned for cgroup v2 in 1.22.

There were a few fixes PR but they were already merged

👋 Hello @giuseppe,

1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

• Update the test plan section to comply with the latest KEP template. The KEP template has recently changed.
• Open a PR for the PRR
• Open a PR to update the kep.yaml fields to indicate you are targeting stable in v1.25

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

With KEP PR #3405 merged, the enhancement is ready for the 1.25 Enhancements Freeze. Thank you!

For note, the status is now marked as tracked in the 1.25 Enhancements Tracking sheet.

Thank you @Priyankasaggu11929 for the update!

Moving this to this issue per comments in #3405:

Would there be value in making it visible in the Node status that the node is using cgroup v2?

Yes, I think so. It might be a good candidate for a node label so that pods can target pure v1, pure v2, or hybrid mode v1/v2. Some applications that expect an older setup could experience issues if a node is pure v2. Applications using Java 8 or Java 11 <= 11.0.16 for example don't accurately detect CPU/memory limits when ran on v2-only systems.

Hello @giuseppe, @mrunalp, @bobbypage! 👋,

1.25 Release Docs Shadow here.

Does this enhancement work planned for 1.25 require any new docs or modification to existing docs?

If so, please make sure to open a PR against the dev-1.25 branch in the k/website repo (follow the steps here)

This PR can be just a placeholder at this time and must be created before August 4.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@ReillyBrogan regarding adding a node label / node status of cgroupv2, it's something me and @mrunalp discussed but we decided it would make more sense for the vendor to set since some vendors may or may not want to set this label. Some vendors may only allow running all nodes as cgroupv2 so it would be redundant to add the label.

Thanks @sethmccombs, I created a placeholder doc PR here - kubernetes/website#35180

Hi @bobbypage / @giuseppe

1.25 Enhancements team here. Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

I couldn't find any PRs (opened or closed) relating to promoting this enhancement to stable.
Can you confirm if any code changes are needed here or if documentation just needs to be updated.

Thank!!

AFAIK, only documentation needs to be updated

Yes, we only need documentation updates, thank you!

Thanks for confirming!

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

/remove-lifecycle rotten

@bobbypage @giuseppe Can we close this issue since it's graduated to stable?

yes, I think it can be closed since there is nothing left to do. Thanks for the reminder!

/close

@giuseppe: Closing this issue.

yes, I think it can be closed since there is nothing left to do.

@giuseppe cAdvisor has been left behind, it seems; google/cadvisor#3137