New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric cardinality enforcement #2305
Comments
/sig instrumentation |
@ehashman is there any action items for either Han or me? Thank you! |
@lilic this KEP graduated to alpha last cycle (1.20), it would be good to finish up beta and graduation criteria and target releases for those. |
@lilic @logicalhan once we have beta/graduation criteria we should decide how we want to target milestones for this moving forward. That's all currently empty: |
/milestone v1.21 slipped from 1.20 |
Hi @logicalhan and @lilic, 1.21 Enhancements Lead here For the enhancement to be included in the milestone, it must meet the following criteria:
Please make sure you update the KEP using the latest template. Also starting 1.21, all KEP must include a production readiness review. Please make sure to take a look at the instructions and update the KEP to include this. For PRR review, please make sure to reach out to #prod-readiness slack channel asap to get this in before the enhancements freeze coming up on Feb. 9th. Thank you! |
Hey @logicalhan and @lilic, 1.21 enhancements shadow here, Just to add to Anna's comment above — enhancement's freeze is 2 days away, Feb 9th EOD PST. Any enhancements that do not complete the requirements in Anna's comment above by the freeze will require an exception. |
I've pinged @logicalhan about getting this added today. |
Opened #2468 to update kep and request for PPR approval. |
@annajung everything should now be addressed. |
With PR #2468 merged, this enhancement meets all criteria required for the enhancements freeze 👍 |
ref kubernetes/kubernetes#97208 I have a couple of suggestions for extensions:
|
Hi @logicalhan and @lilic, Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:
As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them. Thanks! |
Hi @logicalhan and @lilic, Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement. Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team. |
@JamesLaverack I'm updating the point contacts to be @logicalhan and @YoyinZyc |
@JamesLaverack There is one ongoing pr kubernetes/kubernetes#99385 |
I think they are good ideas. I'll keep that in mind. Thanks! |
@ehashman Thanks for the clarification! We'll update our tracking spreadsheet to reflect that. @YoyinZyc Thank you for linking me, i've set this enhancement back to "Tracked". I see that kubernetes/kubernetes#99385 is now merged. Are there any other k/k pull requests outstanding (/need doing before code freeze) or can I mark you as done? |
@JamesLaverack I have one more pr kubernetes/kubernetes#99738. Once it is merged, you can mark it as done.:) |
Code changes are complete, we just need to follow up with documentation updates. |
Can you give me some instruction on which document I should update? I am not sure I know all. Thanks! |
Thanks both. I've now updated the enhancement tracking spreadsheet to note this enhancement as done for code freeze. |
Hello 👋 1.30 Enhancements Lead here, I'm closing milestone 1.29 now, /milestone clear |
@rexagod I assume this is going to stay in beta for 1.30? |
/lead-opted-in I think we should be fine with graduating this to stable now, since this has been in beta for the past couple of releases. LMK if you think we should keep this in beta for another release though. |
@rexagod: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ah, it seems I'll need to request to join that group once kubernetes/kubernetes#122827 is in. |
/lead-opted-in |
Hello @logicalhan @YoyinZyc 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
I think it's already beta, it is going for stable this cycle. |
Hello @logicalhan @YoyinZyc 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is still |
/cc @richabanker |
@meganwolf0 could you please check the status of the enhancement now that #4499 is merged? Thanks! |
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀 |
Hello @logicalhan @YoyinZyc 👋, 1.30 Docs Lead here. Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. |
👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
Hello @drewhagen @fkautz! Since there haven't been any changes marking the stable graduation, I believe kubernetes/website#41998 should suffice for exposing details about this feature. PS. Apologies for not updating the issue description with the website-side link, I've opened #4522 that should allow me to do so for all such instances in the future. 👋🏼 |
Hey again @logicalhan @YoyinZyc👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, I couldn't find any (open) PRs in k/k - perhaps no code changes are expected, please confirm and update the above description. With this, it is now marked as Please let me know if there are other PRs in k/k we should be tracking for this KEP. |
ACK, that's right. I can't edit the description currently but I'll see to it as soon as #4522 is in (and I have the ability to do so). :) |
Hi @rexagod - Code freeze is upon us and I wanted to check back in as the description in this issue is still ambiguous for any expected code changes. Are you able to update so we can make sure this is tracked for code freeze? Thank you! |
Hello @logicalhan @YoyinZyc 👋 Enhancements team here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the If you still wish to progress this enhancement in /milestone clear |
are you sure? #4522 was the only one linked and merged two weeks ago |
My bad, sorry! As it was merged two weeks ago, this can be marked as /milestone v1.30 |
Hello @rexagod 👋 Regarding this:
I think there still needs to be a docs PR (against the k8s website) for adding the new feature flag to beta, correct? If you have some time, can you please do this soon? PR Ready for Review is due this week, supposed to be tomorrow March 12th 18:00 PDT, but grace makes sense in this circumstance of short notice. Let me know, thanks! |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):k/enhancements
) update PR(s): KEP-2305: Metric cardinality enforcement #4039k/k
) update PR(s): KEP-2305: introduce allow-metric-labels-manifest kubernetes#118299k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: