Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job tracking without lingering Pods #2307

Closed
12 tasks done
alculquicondor opened this issue Jan 21, 2021 · 47 comments
Closed
12 tasks done

Job tracking without lingering Pods #2307

alculquicondor opened this issue Jan 21, 2021 · 47 comments
Assignees
@alculquicondor
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@alculquicondor
Copy link
Member

alculquicondor commented Jan 21, 2021 •
edited by soltysh

Enhancement Description

/sig apps
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 21, 2021
@alculquicondor
Copy link
Member Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2021
This was referenced Jan 21, 2021
Merged
Merged
Merged
@alculquicondor
Copy link
Member Author

/assign

@alculquicondor alculquicondor mentioned this issue Feb 5, 2021
Merged
@alculquicondor alculquicondor mentioned this issue Feb 23, 2021
Closed
@alculquicondor
Copy link
Member Author

It looks like #2232 is almost there. Once it merges, we would have very little time to handle conflicts and go through reviews. So we would likely be deferring this enhancement to 1.22.

cc @ahg-g @soltysh

@alculquicondor alculquicondor mentioned this issue Mar 25, 2021
Merged
@alculquicondor alculquicondor mentioned this issue Apr 9, 2021
Merged
@ahg-g
Copy link
Member

ahg-g commented May 5, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 5, 2021
@ahg-g
Copy link
Member

ahg-g commented May 5, 2021 •
edited

@alculquicondor can you update the links to the merged KEP and the open implementation PRs please

@JamesLaverack JamesLaverack added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 5, 2021
@gracenng
Copy link
Member

gracenng commented May 9, 2021

Hi @alculquicondor 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In KEP.yaml, latest-milestone has not been updated
  • In KEP.yaml, milestone (alpha: v1.21, beta: v1.22) doesn't match your current stage

Thanks!

@alculquicondor
Copy link
Member Author

Hi @gracenng, it is up to date https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2307-job-tracking-without-lingering-pods/kep.yaml
Perhaps you missed the last PR?

@gracenng
Copy link
Member

My apologies @alculquicondor, I did miss that PR. I've updated Enhancement track sheet and this issue is no longer at risk.

@gracenng
Copy link
Member

gracenng commented May 11, 2021 •
edited

Hi @alculquicondor 👋 1.22 Enhancements shadow here.
I just wanted to check to see if SIG-Apps will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@soltysh
Copy link
Contributor

soltysh commented May 11, 2021

Yup, sig-apps is aware and tracking this development.

@chrisnegus
Copy link

Hi @alculquicondor ! I'm @chrisnegus , a Docs Shadow for release 1.22.
This enhancement is marked as Needs Docs for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the kubernetes/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@gracenng
Copy link
Member

Hi @alculquicondor 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as k/k#98238 has not been merged.

Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@alculquicondor
Copy link
Member Author

Thanks Grace. The PR is approved by the SIG, but still awaiting for api-review. There are no more PRs.

@alculquicondor alculquicondor mentioned this issue Jul 5, 2021
Merged
@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @alculquicondor 🌷 1.22 enhancements shadow here.

A friendly reminder that Code Freeze is tomorrow, on July 8th. Please also be mindful of the docs PR deadline on July 9th

Thanks

@alculquicondor alculquicondor mentioned this issue Jul 7, 2021
Merged
@marosset
Copy link
Contributor

Hi @alculquicondor 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, please link all related k/k PRs to this issue (and include them in the initial issue description) and try and get them merged before code-freeze.

As always, we are here to help should questions come up. Thanks!

This was referenced Oct 31, 2022
Merged
Merged
@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @alculquicondor 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@alculquicondor
Copy link
Member Author

Hi @krol3, I just added the PR for the website

@krol3
Copy link

krol3 commented Nov 7, 2022

Thank you @alculquicondor , will be these kubernetes/website#37764?

@alculquicondor
Copy link
Member Author

yes, that's the only one.

@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

Hi @alculquicondor 👋,

It looks like all of the code PRs for this enhancement have been merged so this enhancement is once again tracked for the v1.26 release.

Thanks!

@marosset
Copy link
Contributor

Hi @alculquicondor - since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/2307-job-tracking-without-lingering-pods/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 12, 2022
@alculquicondor
Copy link
Member Author

alculquicondor commented Dec 13, 2022 •
edited

We still have a few deprecations and removals to do in the next versions, as mentioned in the KEP. Is that fine?

cross reference: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/2307-job-tracking-without-lingering-pods#deprecation

@marosset
Copy link
Contributor

My mistake! Please keep this issue open until the deprecations / removals are complete.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Dec 14, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023
@alculquicondor
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023
@soltysh soltysh mentioned this issue Apr 19, 2023
Merged
@alculquicondor alculquicondor mentioned this issue Apr 28, 2023
Merged
@kannon92 kannon92 mentioned this issue May 4, 2023
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2023
@kannon92 kannon92 mentioned this issue Oct 20, 2023
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2024
@alculquicondor
Copy link
Member Author

/remove-lifecycle stale

All the post GA requirements are completed.

/close

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Closing this issue.

In response to this:

/remove-lifecycle stale

All the post GA requirements are completed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alculquicondor alculquicondor

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
(Test board) Kubernetes 1.26 Enhancements Tracking
Status: New New
1.26 Enhancements Tracking
Status: Graduating
SIG Apps
Archived in project
Milestone
No milestone
Development

No branches or pull requests