Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StorageVersion API for HA API servers #2339

Open
5 of 8 tasks
shekhar-rajak opened this issue Jan 26, 2021 · 44 comments · May be fixed by kubernetes/kubernetes#120582 or kubernetes/kubernetes#123999
Open
5 of 8 tasks

StorageVersion API for HA API servers #2339

shekhar-rajak opened this issue Jan 26, 2021 · 44 comments · May be fixed by kubernetes/kubernetes#120582 or kubernetes/kubernetes#123999
Assignees
@enj @andrewsykim @richabanker
Labels
lead-opted-in Denotes that an issue has been opted in to a release lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@shekhar-rajak
Copy link
Contributor

shekhar-rajak commented Jan 26, 2021 •
edited by jpbetz

Enhancement Description

  • One-line enhancement description (can be used as a release note):

StorageVersion API for HA API servers

  • Kubernetes Enhancement Proposal:

During the rolling upgrade of an HA master, the API server instances may
use different storage versions encoding a resource. The storageVersionHash
in the discovery document does not expose this disagreement. As a result, the
storage migrator may proceed with migration with the false belief that all API
server instances are encoding objects using the same storage version, resulting
in polluted migration. (details).

We propose a way to show what storage versions all API servers are using, so
that the storage migrator can defer migration until an agreement has been
reached.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2021
@shekhar-rajak
Copy link
Contributor Author

#2331 created for migrating the old keps into new template.

@LappleApple
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 8, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2021
@k8s-triage-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj enj mentioned this issue May 5, 2022
Closed
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2022

@enj expressed interest in implementing.

/lead-opted-in
/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 5, 2022
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2022

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 5, 2022
@k8s-ci-robot
Copy link
Contributor

@deads2k: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enj
Copy link
Member

enj commented Oct 5, 2022

/remove-lifecycle rotten
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 5, 2022
@enj enj added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 5, 2022
@rhockenbury
Copy link

/label tracked/yes
/remove-label tracked/no
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 6, 2022
@k8s-ci-robot
Copy link
Contributor

@rhockenbury: Those labels are not set on the issue: tracked/no

In response to this:

/label tracked/yes
/remove-label tracked/no
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury
Copy link

Hello @enj 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze TOMORROW on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to open a PR to meet all the requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@enj enj mentioned this issue Oct 6, 2022
Merged
@enj
Copy link
Member

enj commented Oct 6, 2022

@rhockenbury #3593 is open for review.

@richabanker
Copy link
Contributor

/milestone v1.30

@k8s-ci-robot
Copy link
Contributor

@richabanker: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpbetz
Copy link
Contributor

jpbetz commented Feb 6, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 6, 2024
@AnaMMedina21
Copy link

Hello @xuchao @shekhar-rajak 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@richabanker richabanker mentioned this issue Feb 7, 2024
Merged
@richabanker
Copy link
Contributor

richabanker commented Feb 7, 2024 •
edited

Hi @AnaMMedina21 I just linked a PR to this issue to update the KEP's README.md with the scalability question as you suggested.
Regarding updating the issue, because I am not the original author of this issue, I am unable to edit the issue description. But I am currently working on graduating this feature to beta in v1.30. How do you suggest I go about making changes to the issue description - if thats even possible? Thanks

@richabanker
Copy link
Contributor

/assign

@AnaMMedina21
Copy link

@richabanker Thanks for making that new PR, once we get it approved and merged, we can change the status to tracked for Freeze.

Noted on not being able to edit the description, it's not a blocking task so don't worry about being unable to. That I know of, only the author can edit it.

@richabanker
Copy link
Contributor

@AnaMMedina21 #4492 is now merged.

@AnaMMedina21
Copy link

@richabanker Hi!
Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kcmartin
Copy link

Hi @richabanker,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @richabanker 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@roycaihw roycaihw mentioned this issue Feb 23, 2024
Closed
@roycaihw
Copy link
Member

#2339 (comment): @Vyom-Yadav Thanks for the reminder! Doc placeholder PR created: kubernetes/website#45302

@AnaMMedina21
Copy link

Hey again @richabanker 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • [] All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • [] All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour
Copy link
Contributor

Hello @richabanker 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
This was referenced Mar 14, 2024
Closed
Open
Closed
Open
enj added a commit to enj/community that referenced this issue Apr 1, 2024
@enj
Add sig-api-machinery-storageversion-dev channel
c1e4aa9 
For discussions around:

kubernetes/enhancements#2339
kubernetes/enhancements#4192
@enj enj mentioned this issue Apr 1, 2024
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2024
@enj enj mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enj enj

@andrewsykim andrewsykim

@richabanker richabanker

Labels
lead-opted-in Denotes that an issue has been opted in to a release lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
1.26 Enhancements Tracking
Status: Net New
1.30 Enhancements Tracking
Status: Removed from Milestone
Milestone
No milestone