Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Reads from Cache #2340

Open
1 of 7 tasks
shekhar-rajak opened this issue Jan 26, 2021 · 42 comments
Open
1 of 7 tasks

Consistent Reads from Cache #2340

shekhar-rajak opened this issue Jan 26, 2021 · 42 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@shekhar-rajak
Copy link
Contributor

shekhar-rajak commented Jan 26, 2021

Enhancement Description

  • One-line enhancement description : Consistent Reads from Cache
  • Kubernetes Enhancement Proposal:

Kubernetes Get and List requests are guaranteed to be "consistent reads" if the
resourceVersion parameter is not provided. Consistent reads are served from
etcd using a "quorum read".

But often the watch cache contains sufficiently up-to-date data to serve the
read request, and could serve it far more efficiently.

This KEP proposes a mechanism to serve most reads from the watch cache
while still providing the same consistency guarantees as serving the
read from etcd.

Tasks

  1. help wanted kind/bug
  2. help wanted kind/feature sig/api-machinery triage/accepted
  3. kind/feature sig/api-machinery triage/accepted
    serathius
  4. help wanted kind/feature sig/api-machinery sig/etcd triage/accepted
    ah8ad3 kumarankit999
  5. area/apiserver area/cloudprovider area/code-generation area/dependency area/kube-proxy area/kubeadm area/kubectl area/kubelet area/provider/gcp area/test cncf-cla: yes do-not-merge/work-in-progress kind/feature needs-priority ok-to-test release-note sig/api-machinery sig/architecture sig/auth sig/cli sig/cloud-provider sig/cluster-lifecycle sig/instrumentation sig/network sig/node sig/storage sig/testing size/M triage/accepted
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2021
@shekhar-rajak
Copy link
Contributor Author

#2331 created for migrating the old keps into new template.

@LappleApple
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 8, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 7, 2021
@k8s-triage-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serathius
Copy link
Contributor

Reviving the KEP as agreed on SIG-Apimachinery meeting May 31st 2023. https://youtu.be/sueYXW89ZHg
/assign

PR #4047 to move KEP to implementable

@serathius serathius reopened this Jun 6, 2023
@serathius serathius removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 7, 2023
@serathius
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 7, 2023
@serathius
Copy link
Contributor

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 7, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Jun 12, 2023

/lead opt-in

@serathius serathius added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 12, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @shekhar-rajak @serathius 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage alpha for v1.28

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has an updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

There are some nits remaining to be addressed:

I won't decline this KEP for enhancements freeze because of these minor changes but would be great to get a PR ready addressing them.

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@serathius
Copy link
Contributor

Don't understand the unmarked points.

KEP readme using the latest template has been merged into the k/enhancements repo.
KEP readme has an updated detailed test plan section filled out

Tests follows the latest template (maybe roughly) and uses a detailed test plan. Please provide criteria that you used to decide that they are not.

@Atharva-Shinde
Copy link
Contributor

Hey @serathius , the second unmarked point is a subset of the first unmarked point.
As mentioned in my comment above, there is an acknowledgement at the start of the Test Plan section quoting:

[ ] I/we understand the owners of the involved components may require updates to
existing tests to make this code solid enough prior to committing the changes necessary
to implement this enhancement.

which this KEP currently doesn't have and we need that to be included so that the KEP is in compliance with the latest KEP readme template.

@serathius
Copy link
Contributor

serathius commented Jun 15, 2023

Makes sense, suggestion for future. Separate questionnaire to KEP authors (also applies to PRR) from KEPs design document into separate file. Having agreements in the middle of the design makes it less readable, doesn't contribute to overall design and also cannot be automatically validated via ./hack/verify-kep.sh.

serathius added a commit to serathius/enhancements that referenced this issue Jun 15, 2023
serathius added a commit to serathius/enhancements that referenced this issue Jun 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jan 16, 2024
@wojtek-t
Copy link
Member

wojtek-t commented Feb 7, 2024

/milestone v1.30
/label lead-opted-in
/label stage/beta
/remove-label stage/alpha

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 7, 2024
@wojtek-t wojtek-t added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

@wojtek-t: The label(s) /label stage/beta , /remove-label stage/alpha cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/milestone v1.30
/label lead-opted-in
/label stage/beta
/remove-label stage/alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@salehsedghpour
Copy link
Contributor

Hello @serathius 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@kcmartin
Copy link

Hi @serathius,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@drewhagen
Copy link
Member

drewhagen commented Feb 15, 2024

Hello @serathius 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@serathius
Copy link
Contributor

@drewhagen Done kubernetes/website#45239

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 22, 2024

Hey again @serathius 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@serathius
Copy link
Contributor

serathius commented Feb 23, 2024

@salehsedghpour Did you mean 5th March and not 9th February which is the enhancement freeze?

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 23, 2024

Oh You're right, I copied the wrong date. Thanks for noticing! I updated my comment.

@serathius
Copy link
Contributor

@kcmartin done

@salehsedghpour
Copy link
Contributor

Hello @serathius 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
@serathius
Copy link
Contributor

/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 23, 2024
@serathius
Copy link
Contributor

serathius commented Apr 23, 2024

We slipped from v1.30 due to etcd-io/etcd#17507.

Will attempt to land it in v1.31, preliminary validation of v3.5.13 shows that K8s test pass kubernetes/kubernetes#124469.

Next step is to merge kubernetes/kubernetes#124469, kubernetes/kubernetes#124027 and kubernetes/kubernetes#123264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Removed from Milestone
Development

No branches or pull requests