Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing In-Tree Cloud Providers #2395

Open
8 tasks done
shekhar-rajak opened this issue Feb 1, 2021 · 62 comments
Open
8 tasks done

Removing In-Tree Cloud Providers #2395

shekhar-rajak opened this issue Feb 1, 2021 · 62 comments
Assignees
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@shekhar-rajak
Copy link
Contributor

shekhar-rajak commented Feb 1, 2021

Enhancement Description

  • One-line enhancement description (can be used as a release note): Removing In-Tree Cloud Providers
  • Kubernetes Enhancement Proposal:

This is a proposal outlining steps to remove "in-tree" cloud provider code from the k8s.io/kubernetes repo while being
as least disruptive to end users and other Kubernetes developers as possible.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 1, 2021
@shekhar-rajak
Copy link
Contributor Author

Migrating all the old template keps to new template : #2391

@andrewsykim
Copy link
Member

/assign

@andrewsykim
Copy link
Member

/sig cloud-provider
/milestoneo v1.21

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2021
@annajung annajung added this to the v1.21 milestone Feb 8, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 8, 2021
@annajung
Copy link
Contributor

annajung commented Feb 9, 2021

Hi @andrewsykim, even with PR #2443 merged, you are missing both test plans and graduation criteria. Could you make sure the requirements are added into the KEP before the freeze EOD PST?

@andrewsykim
Copy link
Member

@annajung that KEP is really old and predates the new template, do you need that updated by EOD today? There are some other KEPs I need to get to and I don't think I'll have time to revisit this one.

@annajung
Copy link
Contributor

Hi @andrewsykim

Enhancements Freeze is now in effect.

Unfortunately, KEP for this enhancement does not meet all the required criteria. If you wish to be included in the 1.21 Release, please submit an Exception Request as soon as possible.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.21 milestone Feb 10, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 10, 2021
@annajung annajung added this to the v1.21 milestone Feb 16, 2021
@annajung
Copy link
Contributor

Hi @andrewsykim

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 - Code Freeze
  • Tuesday, March 16th: Week 10 - Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@annajung
Copy link
Contributor

annajung commented Mar 1, 2021

Hi @andrewsykim

Enhancements team is marking this enhancement as "At Risk" for the upcoming code freeze due to not seeing any linked k/k PR(s) for this enhancement.

Please make sure to provide all k/k PR(s) and k/website PR(s) to this issue so it can be tracked by the release team.

@annajung
Copy link
Contributor

annajung commented Mar 4, 2021

Hey @andrewsykim

A friendly reminder that Code freeze is 5 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Contributor

Hi @andrewsykim, with code freeze now in effect, we are removing this enhancement from 1.21 release due to no code PR being tracked for this enhancement.

If needed, feel free to file an exception to add this back into the release. thanks!

@annajung annajung removed this from the v1.21 milestone Mar 10, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 10, 2021
@JamesLaverack JamesLaverack added this to the v1.22 milestone May 7, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 7, 2021
@supriya-premkumar
Copy link
Contributor

👋🏼 Hi @andrewsykim

This is Supriya, v1.22 enhancement shadow here. For the enhancement to be included in the 1.22 milestone, it must meet the following criteria:

The KEP must have test plans
The KEP must have graduation criteria
The KEP must have a target/latest milestone mentioned in kep.yaml

Please make sure to follow all the instructions and update the KEP to include this.

Thank you!

@JamesLaverack
Copy link
Member

Hi @andrewsykim, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 20, 2023
@rayandas
Copy link
Member

rayandas commented Sep 26, 2023

Hello @shekhar-rajak 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • The latest readme template has more items in production readiness review questionnaire that need to be addressed.
  • The status should be marked as implementable in the kep.yaml file and the latest-milestone should be set to v1.29.
  • Ensure that the readme has a detailed test plan and graduation criteria.
  • Ensure that the PR including the production readiness review has been reviewed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@krol3
Copy link

krol3 commented Sep 27, 2023

Hi @shekhar-rajak and @elmiko 👋, v1.29 Communication Release Team. I would like to check any plan about publication blogs related new features, removals, and deprecations for this release.

The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)
Here the 1.29 Calendar

@elmiko
Copy link
Contributor

elmiko commented Sep 28, 2023

@rayandas should i updating the checklist in your post?

@rayandas
Copy link
Member

rayandas commented Sep 28, 2023

Sure, go ahead. @elmiko

@elmiko
Copy link
Contributor

elmiko commented Sep 28, 2023

ok, one more follow up before i start checking things. does it need to be merged for us to mark them as complete? (i notice the last item specifically mentions it)

@rayandas
Copy link
Member

@elmiko You can update the issue description with open PRs and when it’s merged you can update the checklist, or I’ll update it. So yes things should be merged before.

@elmiko
Copy link
Contributor

elmiko commented Sep 29, 2023

@rayandas perfect, thanks. i'll need to do a little research as it appears the description is out-of-date with our current work.

@elmiko
Copy link
Contributor

elmiko commented Sep 29, 2023

@rayandas updated the description, does that look ok?

@rayandas
Copy link
Member

rayandas commented Oct 4, 2023

Hi @shekhar-rajak @elmiko 👋🏽 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.
It looks like merging PR #4190 will address most of the requirements. Let me know if I missed anything. Thanks.

@elmiko
Copy link
Contributor

elmiko commented Oct 4, 2023

thanks @rayandas , that is accurate. i have a feeling we might miss this freeze given that i am having trouble finding some of the requested information from review.

@npolshakova
Copy link

With KEP PR #4190 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

@Princesso
Copy link

Hey there @elmiko, @bridgetkromhout and @andrewsykim ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@elmiko
Copy link
Contributor

elmiko commented Oct 11, 2023

@Princesso i believe all of our documentation for this change is already live on the kube docs website.

@Princesso
Copy link

@elmiko, could you kindly point me to a PR for reference purposes? Thank you!

@elmiko
Copy link
Contributor

elmiko commented Oct 17, 2023

@Princesso i believe these are the PRs that introduced the docs, although one of them might have older PRs that i couldn't find easily.

kubernetes/website#3227
kubernetes/website#26970

@rayandas
Copy link
Member

Hey again @shekhar-rajak 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all this, the status of this KEP is now tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

a-mccarthy commented Nov 14, 2023

Hi @elmiko @bridgetkromhout @andrewsykim, I'm reaching out from the 1.29 comms team 👋 Are you all planning to write a blog for this feature? If so, please create a placeholder blog PR in https://github.com/kubernetes/website. The deadline for creating a placeholder PR is today 11/14, so please let us know if you are planning to write a blog as soon as possible. Thanks! cc: @Priyankasaggu11929

@elmiko
Copy link
Contributor

elmiko commented Nov 16, 2023

@a-mccarthy would love to have a blog article, but none of us have had time to write it or even propose the placeholder. i'm not sure if there is a path forward for us on this issue, any guidance?

@krol3
Copy link

krol3 commented Nov 16, 2023

Hi @elmiko @bridgetkromhout @andrewsykim, I'm reaching out from the 1.29 comms team 👋 Are you all planning to write a blog for this feature? If so, please create a placeholder blog PR in https://github.com/kubernetes/website. The deadline for creating a placeholder PR is today 11/14, so please let us know if you are planning to write a blog as soon as possible. Thanks! cc: @Priyankasaggu11929

Hi @elmiko please try to submit the placeholder, to help you, the feature blog are released after the release date (Dec 5th)

@elmiko
Copy link
Contributor

elmiko commented Nov 20, 2023

placeholder submitted, kubernetes/website#44010

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@dims
Copy link
Member

dims commented Jan 17, 2024

xref: kubernetes/kubernetes#122828

@elmiko
Copy link
Contributor

elmiko commented Jan 17, 2024

thanks for the reminder @salehsedghpour , i do not think we will have changes for 1.30. our plan is to make the next move to stable after 1.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked for Code Freeze
Development

No branches or pull requests