@cookieisaac

/stage alpha
/milestone v1.22

Greetings @ehashman!
Enhancement shadow checking in with a few reminders. 1.22 Enhancements Freeze starts at 23:59:59 pst on Thursday, May 13. A few items needing review for this KEP:

• Enhancement README

• PRR approved

• Node memory swap support #2400 updated with current target and alpha information.

Thanks!

All of this is covered in #2602

Greetings @ehashman!
Thanks for the follow-up. After reviewing the KEP and PRR everything looks on target. The enhancement is marked at risk but once merged we can move its status to tracked. A reminder that tomorrow 5/13 the Enhancement freeze starts at 23:59:59 PST.

Thanks!

Work breakdown for 1.22

• Documentation for enabling swap (TBD - @ehashman?)
• CI environment/test updates (@ike-ma)
  • Build images with swap for 2 Linux distros
  • Add jobs to test-infra that use the images and enable the swap feature flag/kubelet option for node e2e suite
  • See also Test Plan
• CRI and kubelet changes (@ehashman)
  • Complete API changes per KEP
  • Add e2e tests as appropriate

External to k8s but still need to happen:

• Containerd update to use new CRI
• CRI-O update to use new CRI

Once the above CRI updates happen, ensure that CI environment is using latest container runtimes with updated CRI.

Greetings @ehashman ,
Enhancement shadow checking with a reminder that we are 2 weeks away from code freeze (July 8, 2021). Can you like the k/k PR/s that are needed to implement this enhancement for the 1.22 milestone?

Greetings @ehashman,
A friendly reminder that code freeze is this Thursday, July 8th and we're tracking the following k/k PR:

• Alpha node swap support kubernetes#102823
  The PR has to be merged by code freeze and currently, this KEP is marked "At Risk".
  Also, Docs PR placeholder deadline is Friday, July 9th. Here are instructions on opening a PR in dev-1.22 branch.

Thanks!

PR just merged. Docs placeholder is kubernetes/website#28838

Awesome! Thanks for the update. Moving this to "Tracked".

We are good to go for 1.22! Docs complete.

/milestone v1.23

/stage beta

kubernetes/kubernetes#121820 is also related for testing.

@kannon92 et al: related to the SIG Node discussion meeting today, the QoS resources KEP (issue, PR) lists per-application swap control as one potential use case (albeit a short mention when under memory QoS). It would give per-node visibility (where swap is available) and scheduler support, for example.

/stage beta
/milestone v1.30

Hello @SergeyKanzhelev @kannon92 and @iholder101 , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@SergeyKanzhelev can you add that label? I think we have everything on my end.

/label lead-opted-in

Hello @kannon92 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the [latest template](https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check [here](https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval)).

It looks like all of the above were created for your beta1 release, but now need to be refreshed for your beta2 release.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@mickeyboxell I think everything should be good on this one.

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

Hello @ehashman, @kannon92 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

Hello @Princesso I opened up kubernetes/website#45128.

I can confirm that this works well if you set --experimental-allocatable-ignore-eviction (i.e. via kubernetes/kops#15821) on kubelet to prevent memory evictions. Allows you to pack tighter with very performance penalties. Especially useful for java workloads.

Hi @ehashman,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

Hey all!

I'm sorry for disappearing for so long. It was due to the unfortunate events in my country that have led to me being drafted for a more than 4 months of active military service.

In any case, I'm back now and intend to dedicate the vast majority of my time around the swap feature and other SIG-NODE related features. After some catching up I would be more than happy to help in any way I can.

Thanks for understanding.

Hey again @kannon92 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Add swap conformance tests kubernetes#122175

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

Hey @kannon92 👋 Enhancements team here, just a friendly reminder to follow up on the open Enhancement items above prior to code freeze at 02:00 UTC Wednesday 6th March 2024.

I don't have access to edit this issue but the only PR we should track for code freeze is https://github.com/kubernetes/kubernetes/pull/122745/files. We are working on some improvements to swap tests but that should be for test freeze.

Sorry that I can't edit this issue so its a bit confusing to follow.

@kannon92 thanks for clarifying. This has a beefy enhancement description that's definitely a little tricky to follow.

So the two code PRs we are tracking for 1.30:

• [KEP-2400] add no swap as the default option for swap kubernetes#122745
• [KEP-2400]: Fail limited swap cgroup v1 kubernetes#123738

Both are LGTM/approved so I think they qualify for inclusion in the release.

@iholder101 has a test PR:

• [Swap][Tests][KEP2400] Add swap serial stress tests, improve NodeConformance tests and adapt NoSwap behavior kubernetes#123557

Which should go in before test freeze.

And their is one website PR:

• [KEP-2400] Update swap with beta2 deprecations website#45128

Hello @kannon92 👋 , Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

• [KEP-2400] add no swap as the default option for swap kubernetes#122745
• [KEP-2400]: Fail limited swap cgroup v1 kubernetes#123738

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!