Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend podresources API to report allocatable resources #2403

Closed
4 tasks done
ffromani opened this issue Feb 2, 2021 · 48 comments
Closed
4 tasks done

Extend podresources API to report allocatable resources #2403

ffromani opened this issue Feb 2, 2021 · 48 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@ffromani
Copy link
Contributor

ffromani commented Feb 2, 2021

Enhancement Description

Previous/Related work:

  • initial issue - initially targeting 1.20, we are creating a separate issue + KEP to clearly describe this unit of work.

PRs:

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 2, 2021
@ffromani
Copy link
Contributor Author

ffromani commented Feb 2, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 2, 2021
@ffromani
Copy link
Contributor Author

ffromani commented Feb 2, 2021

rationale for this split in this slack conversation

the main goal is to make this change easier to review

@derekwaynecarr
Copy link
Member

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@annajung annajung added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Feb 3, 2021
@JamesLaverack
Copy link
Member

Hey @fromanirh, enhancements 1.21 shadow here,

Enhancements Freeze is 2 days away, Feb 9th EOD PST

The enhancements team is aware that KEP update is currently in progress (PR #2404). Please make sure to work on PRR questionnaires and requirements and get it merged before the freeze. For PRR related questions or to boost the PR for PRR review, please reach out in Slack on the #prod-readiness channel.

Any enhancements that do not complete the following requirements by the freeze will require an exception.

  • [IN PROGRESS] The KEP must be merged in an implementable state
  • [IN PROGRESS] The KEP must have test plans
  • [IN PROGRESS] The KEP must have graduation criteria
  • [IN PROGRESS] The KEP must have a production readiness review

@JamesLaverack
Copy link
Member

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

  • Tuesday, March 9th: Week 9 — Code Freeze
  • Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
    • If this enhancement requires new docs or modification to existing docs, please follow the steps in the Open a placeholder PR doc to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

@ffromani
Copy link
Contributor Author

ffromani commented Feb 20, 2021

Hi @fromanirh,

Since your Enhancement is scheduled to be in 1.21, please keep in mind the important upcoming dates:

* Tuesday, March 9th: Week 9 — Code Freeze

* Tuesday, March 16th: Week 10 — Docs Placeholder PR deadline
  
  * If this enhancement requires new docs or modification to existing docs, please follow the steps in the [Open a placeholder PR doc](https://kubernetes.io/docs/contribute/new-content/new-features/#open-a-placeholder-pr) to open a PR against k/website repo.

As a reminder, please link all of your k/k PR(s) and k/website PR(s) to this issue so we can track them.

Thanks!

Thanks for the reminder!
I don't think this enhancement requires a k/website PR, but I'll doublecheck and file a placeholder PR if needed.
Implementation PR: kubernetes/kubernetes#95734

@JamesLaverack
Copy link
Member

Hi @fromanirh,

A friendly reminder that Code freeze is 3 days away, March 9th EOD PST

Any enhancements that are NOT code complete by the freeze will be removed from the milestone and will require an exception to be added back.

Please also keep in mind that if this enhancement requires new docs or modification to existing docs, you'll need to follow the steps in the Open a placeholder PR doc to open a PR against k/website repo by March 16th EOD PST

Thanks!

@annajung
Copy link
Contributor

annajung commented Mar 9, 2021

Hi @fromanirh, with kubernetes/kubernetes#95734 merged in, we will mark this as code complete.

@ffromani
Copy link
Contributor Author

ffromani commented Mar 9, 2021

yes, thanks!

@annajung annajung added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Apr 8, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 24, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2021
@ehashman
Copy link
Member

ehashman commented Sep 2, 2021

/milestone v1.23

per 08/24 Node meeting

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.21, v1.23 Sep 2, 2021
@ehashman
Copy link
Member

ehashman commented Sep 2, 2021

/stage beta

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 2, 2021
@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jun 16, 2023
@Atharva-Shinde
Copy link
Contributor

Adding this enhancement to the v1.28 milestone as it's exception request was approved!

@Atharva-Shinde Atharva-Shinde added this to the v1.28 milestone Jun 19, 2023
@AdminTurnedDevOps
Copy link

Hey @ffromani

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@ffromani
Copy link
Contributor Author

Hey @ffromani

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Done (kubernetes/website#41729) thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @ffromani the stage of this KEP is still in beta instead of stable and we need to update it ASAP.

@Atharva-Shinde
Copy link
Contributor

👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR is open and it needs to be merged or should be in merge-ready state before the code freeze commences:

These are the code related PR's that I found on this KEP issue

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@ffromani
Copy link
Contributor Author

Hey @ffromani the stage of this KEP is still in beta instead of stable and we need to update it ASAP.

Thanks for noticing! fixing in #4124

ffromani added a commit to ffromani/website that referenced this issue Jul 17, 2023
…g post about it.

I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancement:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
@Atharva-Shinde
Copy link
Contributor

Hey @ffromani 👋 Enhancements Lead here,
With kubernetes/kubernetes#116525 and kubernetes/kubernetes#118973 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

ffromani added a commit to ffromani/website that referenced this issue Aug 2, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 2, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 3, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 8, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 9, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 11, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue Aug 11, 2023
I'm intentionally covering multiple related enhancements with a single
blog post.

Enhancements:
- kubernetes/enhancements#606
- kubernetes/enhancements#2403
- kubernetes/enhancements#3743

Signed-off-by: Francesco Romani <fromani@redhat.com>
@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@ffromani
Copy link
Contributor Author

all changes merged, GA in 1.28.0. The release 1.28.1 is out, so we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Development

No branches or pull requests