New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure secret pulled images #2535
Comments
Thx @adisky |
/stage stable Note: Since this is a bugfix Mike would like to target graduation directly to stable. |
Hey @mikebrow, 1.22 Enhancements Lead here. 👋
@ehashman That should be fine so long as SIG Node are happy with that. (cc @dchen1107 @derekwaynecarr) I'm aware there's an open PR for your KEP open, but I'd just like to highlight a few things. By enhancements freeze (23:59:59 PST on Thursday 13th May) we require the following:
|
exception was filed last week.. no response yet. KEP updated to latest format and to resolve review questions (mainly added feature gate and switch to alpha vs going directly to GA. Code PR needs final reviews to go over the added feature gate. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi @adisky! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:
Looks like for this one, we would need the following:
Also, could we please add some more information in the
Thank you! |
cc @mikebrow |
@adisky @Priyankasaggu11929 I updated the KEP adding a description for the test plan and links.. and updated the KEP's alpha target from 1.22 to 1.23. |
Thank you so much for adding the changes, @mikebrow. Just to confirm once:
Could you please confirm this part. Thanks once again. :) |
Yes, it is right to change the stage to alpha.
Forgot to hit the save button on those changes :-) Fixed now. Cheers, Mike |
Thanks for the changes @mikebrow :) |
Hello @mikebrow, just checking in as we approach 1.23 enhancements freeze tonight (09/09/2021, 23:59 PDT). Looks like the PR #1608 has got both Is it intended or can be removed to go ahead.? As with the PR merged, this enhancements will be ready for the 1.23 enhancements freeze tonight. Thank you! |
Just an update, the The KEP is now tracked for the kubernetes 1.23 release. Thank you so much @mikebrow. |
Hi @mikebrow, checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC Friday, 6th October 2023. The status of this enhancement is marked as at risk. It looks like #3532 will address most of the requirements. Please make sure that the changes are merged in time. Let me know if I missed anything. Thanks! |
…rsist #2535:ensure secret pulled images - move kep targets; add persist
With KEP PR #3532 approved, the enhancement is ready for the enhancements freeze. The status is now marked as |
Hello @mikebrow @pacoxu 👋, v1.29 Docs Shadow here. |
@drewhagen I opened kubernetes/website#43454 as a placeholder. The PR is still in review. |
Hi @mikebrow @pacoxu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. |
Hey again @pacoxu 👋 v1.29 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023. Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP if any). The status for this KEP is currently |
Sorry for the late update due to missing @haircommander 's comments notification. I update the PR yesterday. And I may have to test it again with some changes. And the PR needs another round of review. |
Hello @pacoxu 👋 1.29 Enhancements lead here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone. If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks! /milestone clear |
/remove-label lead-opted-in |
kep update PR is open in #4431. |
/stage alpha |
/label lead-opted-in |
Hello @mikebrow and @pacoxu 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just want to update the following but it's not required for
The status of this enhancement is marked as |
Hello @adisky, @pacoxu 👋 1.30 Docs Shadow here. |
👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
@adisky Pls update doc list to also include the wip blog entry ^^ |
Hey again @mikebrow and @pacoxu 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP): With this, it is now marked as Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
With the exception request being approved, this can now be marked as |
Hello @mikebrow @pacoxu @adisky! There appears to have been a mix-up where the blog PR was being tracked as a docs PR, so we'd like to help here if docs are needed. A complete review of new docs is due Tuesday March 26th, after which an exception needs to be filed. Please let us know if docs are needed. Thanks! 😄 |
/milestone clear Some discussions around the design when doing the api review. This feature will be postponed. |
Enhancement Description
IfNotPresent
image pull policyKubelet should enforce access to images after they've already been pulled to a node kubernetes#18787
k/enhancements
) update PR(s):k/k
) update PR(s):first try Ensure secret pulled images kubernetes#94899k/website
) update PR(s):[WIP] Document KubeletEnsureSecretPulledImages feature website#43454Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
/sig node
The text was updated successfully, but these errors were encountered: