Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl return code normalization #2551

Open
4 tasks
rikatz opened this issue Mar 3, 2021 · 21 comments · Fixed by #2574
Open
4 tasks

kubectl return code normalization #2551

rikatz opened this issue Mar 3, 2021 · 21 comments · Fixed by #2574
Assignees
@rikatz
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@rikatz
Copy link
Contributor

rikatz commented Mar 3, 2021 •
edited

Enhancement Description

  • One-line enhancement description (can be used as a release note): Normalize the return codes issued by kubectl when an error occurs (and also when we have success)
  • Kubernetes Enhancement Proposal: NONE YET
  • Discussion Link: Discussed on sig-cli bug scrub of 3rd of March of 2021 https://www.youtube.com/watch?v=EWxJiZXZD08 49:39
  • Primary contact (assignee): @rikatz
  • Responsible SIGs: CLI
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.22
    • Beta release target (x.y): 1.23
    • Stable release target (x.y): 1.24
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 3, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Mar 3, 2021

/assign @rikatz
/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2021
@rikatz rikatz mentioned this issue Mar 16, 2021
Merged
@JamesLaverack
Copy link
Member

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 11, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@soltysh
Copy link
Contributor

soltysh commented May 11, 2021

@JamesLaverack this isn't something SIG-CLI is planning to track for 1.22, we will be working on it, but we're more in the gather input phase than closer to alpha implementation.

@supriya-premkumar
Copy link
Contributor

/milestone remove

@k8s-ci-robot
Copy link
Contributor

@supriya-premkumar: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.25]

Use /milestone clear to clear the milestone.

In response to this:

/milestone remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@supriya-premkumar
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 11, 2021
@supriya-premkumar supriya-premkumar removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 11, 2021
@JamesLaverack JamesLaverack added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 11, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 12, 2021

/remove-lifecycle stale
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 12, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Nov 10, 2021
@soltysh
Copy link
Contributor

soltysh commented Nov 16, 2021

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 16, 2021
@eddiezane eddiezane linked a pull request Nov 22, 2021 that will close this issue
KEP 2551 - kubectl exit code normalization #2574
Merged
@rikatz
Copy link
Contributor Author

rikatz commented Dec 9, 2021

@eddiezane @soltysh let me see if someone here at company wants to help me on this, so I can sort of mentor/help/whatever but someone can do the heavy job!

Maybe we can get an alpha proposal for this in v1.24

@gracenng gracenng removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 22, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 22, 2022
@hosseinsalahi
Copy link

hosseinsalahi commented Jan 25, 2022 •
edited

Hello @rikatz

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description and the targeted stage up-to-date for release v1.24.
Thanks!

@johnbelamaric
Copy link
Member

johnbelamaric commented Jan 31, 2022 •
edited

Any updates here? Any PR?

nm, I see it

@soltysh
Copy link
Contributor

soltysh commented Feb 3, 2022

/reopen
this is still worked on

@k8s-ci-robot
Copy link
Contributor

@soltysh: Reopened this issue.

In response to this:

/reopen
this is still worked on

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 3, 2022
@chrisnegus
Copy link

Hi @rikatz 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 6, 2022
@soltysh
Copy link
Contributor

soltysh commented Mar 18, 2022

Hey @chrisnegus I must have marked this feature prematurely as needs docs, since we're still very early and not much of this work will be visible to users. Is there a way we could remove that needs docs for now?

@chrisnegus
Copy link

Thanks @soltysh ! I've moved the KEP to our "No Docs Required" column.

@hosseinsalahi
Copy link

Hello @rikatz

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as tracked.
Thank you!

@katcosgrove
Copy link

Hey y'all! We're approaching last call for feature blogs, as the freeze is Wednesday, March 23. If you would like to have a feature blog for this, please add it to the tracking sheet and reach out to me if you have any questions. Thank you!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@ah8ad3
Copy link

ah8ad3 commented Apr 9, 2024

I've read the kep and i'm interested on starting this, but i need some sort of help/mentoring. @rikatz @soltysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rikatz rikatz

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

KEP 2551 - kubectl exit code normalization rikatz/enhancements