Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded DNS configuration #2595

Closed
12 tasks done
gjkim42 opened this issue Apr 2, 2021 · 54 comments
Closed
12 tasks done

Expanded DNS configuration #2595

gjkim42 opened this issue Apr 2, 2021 · 54 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@gjkim42
Copy link
Member

gjkim42 commented Apr 2, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 2, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Apr 6, 2021

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2021
@JamesLaverack
Copy link
Member

/milestone v1.22
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 1, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 1, 2021
@gracenng
Copy link
Member

Hi @gjkim42 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, a minor change request in light of Enhancement Freeze on Thursday May 13th:

  • Graduation criteria for alpha is incomplete

Thanks!

@gracenng
Copy link
Member

Hi @gjkim42 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Network will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@gjkim42
Copy link
Member Author

gjkim42 commented May 11, 2021

Hi @gracenng
Updated graduation criteria for alpha.
The Enhancement PR was just merged yesterday with the sig-network's approval.
I think it seems to be OK as it is now.

Thanks :)

@gracenng
Copy link
Member

gracenng commented Jun 23, 2021

Hi @gjkim42 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is tracked and we are tracking kubernetes/kubernetes#100651.
Please let me know if there is other code PR associated with this enhancement.

Thanks

@gjkim42
Copy link
Member Author

gjkim42 commented Jun 23, 2021

Hi @gracenng

Please let me know if there is other code PR associated with this enhancement.

There isn't. All works for this release has been completed.

Thanks :)

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@thockin
Copy link
Member

thockin commented Sep 3, 2021

For the record: it sounds like we're waiting for runtimes to implement, so no advancement for 1.23, right?

@gjkim42
Copy link
Member Author

gjkim42 commented Sep 3, 2021

Right. We should wait for container runtimes to support this feature.

Will discuss about the beta promotion later.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2021
@gjkim42
Copy link
Member Author

gjkim42 commented Dec 2, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2021
@thockin
Copy link
Member

thockin commented Feb 16, 2022

We did not queue this up for 1.24, so I will tag for 25 and we can re-evaluate then

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) May 30, 2023
@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 7, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 9, 2023

Hello @gjkim42 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28 (correct me if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to:

  • Get an approval for the PRR.
  • We usually mark an enhancement as implemented after it is released as GA. So we would need to change the status in kep.yaml from implemented to implementable for now.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@enj
Copy link
Member

enj commented Jun 12, 2023

KEP and PRR have been approved for v1.28: #3914 (comment)

@gjkim42
Copy link
Member Author

gjkim42 commented Jun 12, 2023

@Atharva-Shinde

  • Get an approval for the PRR.

KEP and PRR have been approved for v1.28: #3914 (comment)

Yes, we already got PRR approve. Correct me if I am wrong.

  • We usually mark an enhancement as implemented after it is released as GA. So we would need to change the status in kep.yaml from implemented to implementable for now.

This feature will be released as GA in 1.28, so I think marking it as implemented is ok, right?

@enj
Copy link
Member

enj commented Jun 13, 2023

This feature will be released as GA in 1.28, so I think marking it as implemented is ok, right?

Only once all of the code/docs/etc are done (I don't know the current state).

@gjkim42
Copy link
Member Author

gjkim42 commented Jun 13, 2023

they are all done.

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 13, 2023

I have updated my comment above: check marking the PRR approval requirement.

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 13, 2023

From what I have seen, ultimately when an enhancement is released out as GA it needs to lock its Feature Gates (before Code Freeze) and set the status to implemented which happens after it has been successfully tracked the release cycle it has opted-in (in this case v1.28).

Tagging the PRR approver for this enhancement @johnbelamaric for a decision.

@enj
Copy link
Member

enj commented Jun 13, 2023

@Atharva-Shinde not sure I see any issues here - all the work for this KEP is already complete, so it is implemented.

@enj
Copy link
Member

enj commented Jun 13, 2023

which happens after it has been successfully tracked the release cycle it has opted-in (in this case v1.28)

Nothing prevents the work from being completed in between code thaw and enhancements freeze (which is what happened here).

@Atharva-Shinde
Copy link
Contributor

Nothing prevents the work from being completed in between code thaw and enhancements freeze (which is what happened here).

Yes I agree on that. It's just the case of changing the status to implementable rather than implemented for now.

@gjkim42
Copy link
Member Author

gjkim42 commented Jun 14, 2023

@Atharva-Shinde

I understand that I should have not updated the status to implemented if all work had not been done.
However, all the work has been done now. Do we need to update the KEP status to implementable and update it back to implemented?

(Please correct me, if I misunderstand something.)

@Atharva-Shinde
Copy link
Contributor

With everything already done for this enhancement, I am leaning towards approving this KEP and getting it tracked. But there is an instance where the enhancement owner had to close the PR which was changing the status to implemented because it should be changed to implemented only after the release is out. I'll ping the PRR team on slack for a decision.

@Atharva-Shinde
Copy link
Contributor

Marking the status of this enhancement as tracked🚀

@Atharva-Shinde Atharva-Shinde added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 15, 2023
@Atharva-Shinde
Copy link
Contributor

Hey again @gjkim42 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

This the code related PR/s that I found on this KEP issue:

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @gjkim42 👋 Enhancements Lead here,
With kubernetes/kubernetes#116741 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@thockin thockin modified the milestones: v1.28, v1.30 Aug 17, 2023
@npolshakova
Copy link

Hey @gjkim42 👋 1.29 Enhancements Lead here, is there any more work planned for this KEP? Also is the milestone accurate (are you targeting v1.30 instead of v1.29?)

@gjkim42
Copy link
Member Author

gjkim42 commented Sep 7, 2023

This is already in GA, we have to remove the feature gate in v1.30.

@npolshakova
Copy link

Great! I'm going to remove the lead-opted-in label for now. Feel free to add it again once the v1.30 release cycle starts.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2024
@thockin thockin closed this as completed Jan 29, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Graduating
Status: Tracked
Obsolete: SIG-Network KEPs (see https...
GA (merged, gate not removed)
Development

No branches or pull requests