Skip to content

node: cpumanager: add options to reject non SMT-aligned workload #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 tasks done
ffromani opened this issue Apr 14, 2021 · 66 comments
Open
12 tasks done

node: cpumanager: add options to reject non SMT-aligned workload #2625

ffromani opened this issue Apr 14, 2021 · 66 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@ffromani
Copy link
Contributor

ffromani commented Apr 14, 2021

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 14, 2021
@ffromani
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2021
@ehashman
Copy link
Member

ehashman commented May 4, 2021

/stage alpha
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 5, 2021
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue May 6, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani changed the title Add new cpumanager policies to enable finer grained thread allocation Add options to cpumanager policies to allow finer grained thread allocation May 7, 2021
@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Thank you 😊

ffromani added a commit to ffromani/enhancements that referenced this issue May 10, 2021
See: kubernetes#2625 (comment)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented May 10, 2021

Hi @fromanirh wave 1.22 Enhancement shadow here.

This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • In kep.yaml file, prr-approvers is empty
  • Please elaborate and/or link the implementation PR in your Test Plan

Done! thanks for checking!

@ffromani ffromani changed the title Add options to cpumanager policies to allow finer grained thread allocation node: cpumanager: add options to reject non SMT-aligned workload May 10, 2021
@ffromani
Copy link
Contributor Author

fixed the issue summary to make it consistent with the KEP

@gracenng
Copy link
Member

Hi @fromanirh 👋 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@ffromani
Copy link
Contributor Author

ffromani commented May 11, 2021

Hi @fromanirh wave 1.22 Enhancements shadow here.
I just wanted to double check to see if SIG-Node will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

Hi @gracenng ! thanks for checking in! I'm waiting for another review indeed. sig-node ack'd this enhancement (https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.y6vnh39j4mih) but unfortunately the sig is a bit overworked. I'll update as soon as possible.

ffromani added a commit to ffromani/website that referenced this issue May 12, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani added a commit to ffromani/website that referenced this issue May 20, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@gracenng
Copy link
Member

Hi @fromanirh 🌞 1.22 enhancements shadow here.

In light of Code Freeze on July 8th, this enhancement current status is at risk as kubernetes/kubernetes#101432 has not been merged.
Please let me know if there is other code PR associated with this enhancement and feel free to ping me once its merged.

Thanks

@gracenng
Copy link
Member

gracenng commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

@ffromani
Copy link
Contributor Author

ffromani commented Jul 7, 2021

Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged.

Hi Grace, thanks for the reminder. I'm working towards the final round of review.

ffromani added a commit to ffromani/website that referenced this issue Jul 8, 2021
The enhancement kubernetes/enhancements#2625
want to add a new kubelet option to fine tune the behaviour of the
cpu manager policies, and to do so we add support for cpu manager policy
options themselves.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

Please note that (of course once the implementation merges) we are planning to go beta not before two releases. So, if the implementation merges in 1.22, we will not promote to beta before 1.24 (was 1.23 before)

@ffromani
Copy link
Contributor Author

ffromani commented Jul 8, 2021

@gracenng FYI: kubernetes/kubernetes#101432 (comment)

@haircommander
Copy link
Contributor

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 30, 2025
@dipesh-rawat
Copy link
Member

Hello @ffromani 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)
/stage stable

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

It looks like #5108 will address most of these issues.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 31, 2025
@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Jan 31, 2025
@dipesh-rawat
Copy link
Member

Hi @ffromani 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #2625 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@ffromani ffromani moved this from Proposed for consideration to Considered for release in SIG Node 1.33 KEPs planning Feb 11, 2025
@ffromani ffromani moved this from Considered for release to Tracked in SIG Node 1.33 KEPs planning Feb 11, 2025
@dipesh-rawat
Copy link
Member

Hello @ffromani 👋, 1.33 Enhancements team here.

Now that PR #5108 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 11, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 11, 2025
@hacktivist123
Copy link

Hello @ffromani 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Feb 28, 2025

Hey again @ffromani 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

@dipesh-rawat dipesh-rawat moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Feb 28, 2025
@Udi-Hofesh
Copy link
Member

Hey @ffromani 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timelines to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@ffromani
Copy link
Contributor Author

ffromani commented Mar 3, 2025

Hey @ffromani 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

* This introduces some breaking change(s)

* This has significant impacts and/or implications to users

* ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timelines to keep in mind:

* **02:00 UTC Wednesday, 5th March, 2025**: Feature blog PR freeze

* **Monday, 7th April, 2025**: Feature blogs ready for review

* You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

thanks for the reminder! I was contemplating adding a feature blog but this feature (non-breaking, nontrivial impact to few users, not particularly long-awaited) is a bit of niche and a bit of limited scope. So I think it would be best to have a cumulative entry later on once we have more cpumanager policy options, and nothing for now (just regular release docs, no highlights yet)

@ffromani
Copy link
Contributor Author

ffromani commented Mar 3, 2025

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

* [node: metrics for alignment failures kubernetes#129950](https://github.com/kubernetes/kubernetes/pull/129950)

* I couldn’t find a PR for graduating the feature to Stable. Not sure if it’s completed or not, can you confirm if it’s already done?

Thanks for checking! I was hoping to merge 129950 quickly, but I was proven wrong. I filed the missing PR, which does not logically depend on 129950, but should be merged only after 129950 is merged: kubernetes/kubernetes#130535

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

Thanks, I'm also trying my best to track accurately the KEP status. For this work, the linked PRs should be sufficient.

@Udi-Hofesh
Copy link
Member

Hey @ffromani 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!
For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!
As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

* This introduces some breaking change(s)

* This has significant impacts and/or implications to users

* ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚
Tip
Some timelines to keep in mind:

* **02:00 UTC Wednesday, 5th March, 2025**: Feature blog PR freeze

* **Monday, 7th April, 2025**: Feature blogs ready for review

* You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

Note
In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

thanks for the reminder! I was contemplating adding a feature blog but this feature (non-breaking, nontrivial impact to few users, not particularly long-awaited) is a bit of niche and a bit of limited scope. So I think it would be best to have a cumulative entry later on once we have more cpumanager policy options, and nothing for now (just regular release docs, no highlights yet)

@ffromani, as the deadline to submit is only a few hours away, I wanted to double verify that you are opting out (?) You only need to open a placeholder PR at this stage. Lemme know :)

@ffromani
Copy link
Contributor Author

ffromani commented Mar 6, 2025

Hey @ffromani 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team!
For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!
As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:

* This introduces some breaking change(s)

* This has significant impacts and/or implications to users

* ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚
Tip
Some timelines to keep in mind:

* **02:00 UTC Wednesday, 5th March, 2025**: Feature blog PR freeze

* **Monday, 7th April, 2025**: Feature blogs ready for review

* You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

Note
In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

thanks for the reminder! I was contemplating adding a feature blog but this feature (non-breaking, nontrivial impact to few users, not particularly long-awaited) is a bit of niche and a bit of limited scope. So I think it would be best to have a cumulative entry later on once we have more cpumanager policy options, and nothing for now (just regular release docs, no highlights yet)

@ffromani, as the deadline to submit is only a few hours away, I wanted to double verify that you are opting out (?) You only need to open a placeholder PR at this stage. Lemme know :)

Hi, I double confirm I'm opting out. I really do feel a blog entrey for this option alone is too thin and I'd rather have a single blog entry (perhaps co-authored with other contributors) covering a range of features.
All of these feature blog will require a refresher about modern CPU layout which can take some significant real blog estate, so this seems another reason to group the topics reusing a common introduction.

@dipesh-rawat
Copy link
Member

Hi @ffromani 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #2625 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hey @ffromani 👋, v1.33 Enhancements team here,

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.33 Enhancements Tracking Mar 20, 2025
@haircommander haircommander moved this from Tracked to Implemented in SIG Node 1.33 KEPs planning Mar 21, 2025
@rayandas rayandas moved this from Tracked for code freeze to Tracked for Docs Freeze in 1.33 Enhancements Tracking Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Docs Freeze
Status: Implemented
Status: Deferred
Status: Removed
Development

No branches or pull requests