-
Notifications
You must be signed in to change notification settings - Fork 1.5k
node: cpumanager: add options to reject non SMT-aligned workload #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/sig node |
/stage alpha |
The enhancement kubernetes/enhancements#2625 want to add a new kubelet option to fine tune the behaviour of the cpu manager policies, and to do so we add support for cpu manager policy options themselves. Signed-off-by: Francesco Romani <fromani@redhat.com>
The enhancement kubernetes/enhancements#2625 want to add a new kubelet option to fine tune the behaviour of the cpu manager policies, and to do so we add support for cpu manager policy options themselves. Signed-off-by: Francesco Romani <fromani@redhat.com>
Hi @fromanirh 👋 1.22 Enhancement shadow here. This enhancement is in good shape, some minor change requests in light of Enhancement Freeze on Thursday May 13th:
Thank you 😊 |
See: kubernetes#2625 (comment) Signed-off-by: Francesco Romani <fromani@redhat.com>
Done! thanks for checking! |
fixed the issue summary to make it consistent with the KEP |
Hi @fromanirh 👋 1.22 Enhancements shadow here. |
Hi @gracenng ! thanks for checking in! I'm waiting for another review indeed. sig-node ack'd this enhancement (https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.y6vnh39j4mih) but unfortunately the sig is a bit overworked. I'll update as soon as possible. |
The enhancement kubernetes/enhancements#2625 want to add a new kubelet option to fine tune the behaviour of the cpu manager policies, and to do so we add support for cpu manager policy options themselves. Signed-off-by: Francesco Romani <fromani@redhat.com>
The enhancement kubernetes/enhancements#2625 want to add a new kubelet option to fine tune the behaviour of the cpu manager policies, and to do so we add support for cpu manager policy options themselves. Signed-off-by: Francesco Romani <fromani@redhat.com>
Hi @fromanirh 🌞 1.22 enhancements shadow here. In light of Code Freeze on July 8th, this enhancement current status is at risk as kubernetes/kubernetes#101432 has not been merged. Thanks |
Hi @fromanirh, 1.22 enhancements shadow here. Friendly reminder that Code Freeze is tomorrow, July 8th. Feel free to ping me once its merged. |
Hi Grace, thanks for the reminder. I'm working towards the final round of review. |
The enhancement kubernetes/enhancements#2625 want to add a new kubelet option to fine tune the behaviour of the cpu manager policies, and to do so we add support for cpu manager policy options themselves. Signed-off-by: Francesco Romani <fromani@redhat.com>
Please note that (of course once the implementation merges) we are planning to go beta not before two releases. So, if the implementation merges in 1.22, we will not promote to beta before 1.24 (was 1.23 before) |
/label lead-opted-in |
Hello @ffromani 👋, v1.33 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, we would need to update the following:
It looks like #5108 will address most of these issues.
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hi @ffromani 👋, 1.33 Enhancements team here, Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. The current status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hello @ffromani 👋, 1.33 Enhancements team here. Now that PR #5108 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is marked as /label tracked/yes |
Hello @ffromani 👋, v1.33 Docs Shadow here. Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. |
Hey again @ffromani 👋, 1.33 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):
Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status. If you anticipate missing code freeze, you can file an exception request in advance. The status of this enhancement is marked as |
Hey @ffromani 👋 -- this is Udi (@Udi-Hofesh) from the 1.33 Communications Team! For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement! As you may be aware, feature blogs are a great way to communicate to users about features that fall into (but are not limited to) the following categories:
To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚 Tip Some timelines to keep in mind:
Note In your placeholder PR, use |
thanks for the reminder! I was contemplating adding a feature blog but this feature (non-breaking, nontrivial impact to few users, not particularly long-awaited) is a bit of niche and a bit of limited scope. So I think it would be best to have a cumulative entry later on once we have more cpumanager policy options, and nothing for now (just regular release docs, no highlights yet) |
Thanks for checking! I was hoping to merge 129950 quickly, but I was proven wrong. I filed the missing PR, which does not logically depend on 129950, but should be merged only after 129950 is merged: kubernetes/kubernetes#130535
Thanks, I'm also trying my best to track accurately the KEP status. For this work, the linked PRs should be sufficient. |
@ffromani, as the deadline to submit is only a few hours away, I wanted to double verify that you are opting out (?) You only need to open a placeholder PR at this stage. Lemme know :) |
Hi, I double confirm I'm opting out. I really do feel a blog entrey for this option alone is too thin and I'd rather have a single blog entry (perhaps co-authored with other contributors) covering a range of features. |
Hi @ffromani 👋, 1.33 Enhancements team here, Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. The current status of this enhancement is marked as If you anticipate missing code freeze, you can file an exception request in advance. Thank you! |
Hey @ffromani 👋, v1.33 Enhancements team here, With all the implementation(code related) PRs merged as per the issue description:
This enhancement is now marked as Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status. |
Enhancement Description
Add options to cpumanager policies to allow finer grained thread allocation
k/enhancements
) update PR(s): node: cpumanager: add options to reject non SMT-aligned workload #2626k/k
) update PR(s): node: cpumanager: add options to reject non SMT-aligned workload kubernetes#101432k/website
) update PR(s): cpumanager: document cpu manager policy options website#27891k/enhancements
) update PR(s): KEP-2625: Update CPU Manager Policy Options 1.23 Beta #2933k/k
) update PR(s): node: graduate CPUManagerPolicyOptions to beta kubernetes#105012k/website
) update PR(s): node: cpumanager: policy options to beta: document the options graduation process website#29709k/enhancements
) update PR(s): KEP-2625: Promote the CPUManager Policy Optionfull-pcpus-only
to GA #5108k/k
) update PR(s):k/website
) update PR(s):The text was updated successfully, but these errors were encountered: