Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always Honor PersistentVolume Reclaim Policy #2644

Open
3 of 4 tasks
xing-yang opened this issue Apr 22, 2021 · 45 comments
Open
3 of 4 tasks

Always Honor PersistentVolume Reclaim Policy #2644

xing-yang opened this issue Apr 22, 2021 · 45 comments
Assignees
@deepakkinni
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Apr 22, 2021 •
edited

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 22, 2021
@xing-yang
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 22, 2021
@JamesLaverack
Copy link
Member

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@JamesLaverack JamesLaverack added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 28, 2021
@gracenng
Copy link
Member

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

@gracenng
Copy link
Member

Hi @xing-yang 👋 1.22 Enhancements shadow here.
To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

@JamesLaverack
Copy link
Member

Hi @deepakkinni, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 14, 2021
@xing-yang
Copy link
Contributor Author

KEP is here but not merged yet: #2680

@xing-yang xing-yang mentioned this issue May 14, 2021
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 12, 2021
@xing-yang
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021
@xing-yang
Copy link
Contributor Author

/milestone v1.23

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 30, 2021
@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 31, 2021
@lauralorenz
Copy link
Contributor

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable (filled out in PR, not merged)
  • KEP has a test plan section filled out. (filled out in PR, not merged)
  • KEP has up to date graduation criteria. (filled out in PR, not merged)
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

@ramrodo
Copy link
Member

ramrodo commented Sep 20, 2021

Hi @xing-yang, @deepakkinni 👋 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@xing-yang
Copy link
Contributor Author

Hi @ramrodo,
We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

@xing-yang
Copy link
Contributor Author

Also the required in-tree PR for this KEP is merged: kubernetes/kubernetes#105773
We are on-track for 1.23.

@deepakkinni deepakkinni mentioned this issue Nov 15, 2021
Merged
@lauralorenz
Copy link
Contributor

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

Thanks!!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 12, 2023
@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
@xing-yang
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 24, 2023
@xing-yang
Copy link
Contributor Author

/milestone 1.29

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor Author

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 31, 2023
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Aug 31, 2023
@andyzhangx andyzhangx mentioned this issue Sep 5, 2023
Closed
@deepakkinni deepakkinni mentioned this issue Sep 5, 2023
Closed
@sreeram-venkitesh
Copy link
Member

Hello @xing-yang 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v.1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest milestone to v1.29, beta milestone to 1.29 and the stage to be beta in the kep.yaml file and get them merged into k/enhancements.
  • Make sure that your KEP readme file is using the latest template. If not, please update it to the latest template and get it merged to k/enhancements as well.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@xing-yang
Copy link
Contributor Author

Thanks @sreeram-venkitesh for the reminder! Unfortunately I don't think we can meet the deadlines for the enhancement freeze in 1.29. We'll try again in 1.30. cc @deepakkinni

@xing-yang xing-yang removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 2, 2023
@xing-yang xing-yang removed this from the v1.29 milestone Oct 2, 2023
@sreeram-venkitesh
Copy link
Member

@xing-yang Thank you for the update! I will remove the KEP from the 1.29 enhancement tracking board.

@carlory carlory mentioned this issue Jan 9, 2024
Open
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 17, 2024
@xing-yang xing-yang added this to the v1.30 milestone Jan 17, 2024
@sreeram-venkitesh
Copy link
Member

Hello @xing-yang 👋, v1.30 Enhancements team here!

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone to 1.30, beta milestone to 1.30 and the stage to be beta in the kep.yaml file and get them merged into k/enhancements.
  • Make sure that your KEP readme file is using the latest template. If not, please update it to the latest template and get it merged to k/enhancements as well.

The status of this enhancement is marked as at risk for enhancement freeze. Thank you!

@xing-yang
Copy link
Contributor Author

@sreeram-venkitesh Thanks for the ping! Most likely we'll miss the 1.30 deadlines as we need to add e2e tests first before the KEP merge deadline.
cc @deepakkinni

@xing-yang xing-yang removed this from the v1.30 milestone Feb 5, 2024
@xing-yang xing-yang removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2024
@carlory carlory mentioned this issue Feb 6, 2024
Open
@sreeram-venkitesh
Copy link
Member

@xing-yang Thanks for the update! I've updated this KEP to be deferred for this cycle.

CC: @salehsedghpour

@salehsedghpour
Copy link
Contributor

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakkinni deepakkinni

Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
(Test board) Kubernetes 1.26 Enhancements Tracking
Status: No status
1.26 Enhancements Tracking
Status: Graduating
1.29 Enhancements Tracking
Status: Removed from Milestone
1.30 Enhancements Tracking
Status: Removed from Milestone
Milestone
No milestone
Development

No branches or pull requests