Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe #2727

Closed
1 of 12 tasks
bowei opened this issue May 12, 2021 · 69 comments · Fixed by #3989
Closed
1 of 12 tasks

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe #2727

bowei opened this issue May 12, 2021 · 69 comments · Fixed by #3989
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@bowei
Copy link
Member

bowei commented May 12, 2021

Enhancement Description

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 12, 2021
@bowei
Copy link
Member Author

bowei commented May 12, 2021

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2021
@bowei
Copy link
Member Author

bowei commented May 12, 2021

/assign

@bowei
Copy link
Member Author

bowei commented May 12, 2021

@PxyUp

@bowei
Copy link
Member Author

bowei commented May 12, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 12, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 12, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 12, 2021
@SergeyKanzhelev
Copy link
Member

@ehashman
Copy link
Member

@bowei can you start filing an exception request if you want this in 1.22? It seems very unlikely this feature will make the deadline of tomorrow given that it has not been opted in to the release, is missing PRR, etc.

@JamesLaverack
Copy link
Member

/milestone v1.22
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 13, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 13, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 13, 2021
bowei added a commit to bowei/enhancements that referenced this issue May 13, 2021
@JamesLaverack
Copy link
Member

Hi @bowei, 1.22 Enhancements Lead here. We're not removing this from 1.22, but can you address John's comment about updating your kep.yaml metadata to match your KEP README?

@yuzhiquan
Copy link
Member

/cc

@bowei
Copy link
Member Author

bowei commented May 14, 2021

Got it, updating.

@bowei
Copy link
Member Author

bowei commented May 14, 2021

@ehashman do we need an exception request?

@SergeyKanzhelev
Copy link
Member

@ehashman do we need an exception request?

It is in the tracking document: https://docs.google.com/spreadsheets/d/1mlui0brYypOAsgS2D13fvcs3At1uMq4i1gWfneq-jxY/edit#gid=1954476102 and was merged in time. Also @ehashman counted it in the Slack message =).

We generally not encouraging last minute KEPs so we have a proper planning and be respectful for reviewers time. I think this one is not controversial and it is great that it got merged in time.

@PxyUp
Copy link

PxyUp commented May 14, 2021

@bowei thanks for leading that, sadly i haven't time to finish my proposal. I did MR for prober long time ago may be commits will be also useful:

kubernetes/kubernetes#89832

If you need it, i will rebase and update MR

@yuzhiquan
Copy link
Member

yuzhiquan commented May 18, 2021

@bowei do you working on this now?

If not, i would like to take this from here, and base on @PxyUp work kubernetes/kubernetes#89832.

@yuzhiquan yuzhiquan removed their assignment May 18, 2021
@thockin
Copy link
Member

thockin commented Feb 2, 2023

/label lead-opted-in

@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

Hello @bowei 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage stable for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3807 will address the remaining requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@SergeyKanzhelev
Copy link
Member

@marosset I believe this is done.

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @bowei 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
I do see a few open issues associated with this KEP and am not sure how to track these.

As always, we are here to help should questions come up. Thanks!

@Rishit-dagli
Copy link
Member

Hi @bowei 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@bowei
Copy link
Member Author

bowei commented Mar 10, 2023

Thanks, let me take a look.

@SergeyKanzhelev
Copy link
Member

kubernetes/website#39919

/assign
/unassign @bowei

@bowei, no worries, I will handle this

@bowei
Copy link
Member Author

bowei commented Mar 13, 2023

Thanks!

@thockin
Copy link
Member

thockin commented Apr 27, 2023

NEXT: Remove gate in 1.29

@pacoxu
Copy link
Member

pacoxu commented Aug 30, 2023

This feature is GAed. There are still several issues to track related tasks or in-discussion issues.

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Graduating
Status: Tracked
Obsolete: SIG-Network KEPs (see https...
GA (merged, gate not removed)
Development

Successfully merging a pull request may close this issue.