Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral Containers #277

Closed
23 tasks done
verb opened this issue Apr 25, 2017 · 172 comments
Closed
23 tasks done

Ephemeral Containers #277

verb opened this issue Apr 25, 2017 · 172 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@verb
Copy link
Contributor

verb commented Apr 25, 2017

Feature Description

  • One-line feature description (can be used as a release note): Support advanced troubleshooting of running pods by running a new container image in shared pod namespaces.
  • Kubernetes Enhancement Proposal: https://git.k8s.io/enhancements/keps/sig-node/277-ephemeral-containers
  • Primary contact (assignee): @verb
  • Responsible SIGs: sig-node
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.16)
    • Beta release target (1.23)
    • Stable release target (1.25)

Documentation

Milestones

These are the user-visible milestones on the way towards a Kubernetes release that will support kubectl debug functionality. Those interested can follow this issue for updates. I've included estimated release targets, but these are highly dependent on reviewer availability and should not be relied upon.

  • Ephemeral containers added to core API (landed 1.16)
  • kubelet support for creating basic ephemeral containers (landed 1.16)
  • kubectl command to launch ephemeral containers (landed 1.17)
  • kubelet support for namespace targeting (landed 1.18)
  • kubectl support for adding ephemeral containers (landed 1.18)
  • Switch API to use Pod kind (target 1.22)
  • allow setting securityContext (target 1.22)
  • Beta graduation (target 1.23)

Related Enhancements and Proposals

Issues & Feature Requests

Completed features

Scheduled for work in 1.23

Scheduled for work in 1.25

Future work, out of scope for this KEP

Contribute to these features or help prioritize by voting for these issues.

@dchen1107 dchen1107 added this to the v1.7 milestone May 1, 2017
@dchen1107 dchen1107 added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 1, 2017
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 3, 2017
@idvoretskyi idvoretskyi added this to In Progress in Kubernetes 1.7 features May 3, 2017
@liggitt liggitt added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label May 23, 2017
@liggitt
Copy link
Member

liggitt commented May 23, 2017

cc @kubernetes/sig-cli-feature-requests

@verb
Copy link
Contributor Author

verb commented Jun 1, 2017

@dchen1107 @idvoretskyi This should move to 1.8 milestone & features.

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 1, 2017
@verb verb changed the title Pod Troubleshooting Debug Containers Jun 1, 2017
@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.7 Jun 1, 2017
@idvoretskyi idvoretskyi removed this from In Progress in Kubernetes 1.7 features Jun 1, 2017
@idvoretskyi
Copy link
Member

@verb thanks, updated.

@calebamiles calebamiles modified the milestones: 1.8, next-milestone Jul 25, 2017
@pwittrock
Copy link
Member

@verb Is this still targeted for 1.8?

@verb
Copy link
Contributor Author

verb commented Aug 18, 2017

@pwittrock No, let's bump to 1.9

@pwittrock pwittrock removed this from the 1.8 milestone Sep 7, 2017
@idvoretskyi
Copy link
Member

@verb still on track for 1.9?

@idvoretskyi idvoretskyi added this to the next-milestone milestone Oct 2, 2017
@verb
Copy link
Contributor Author

verb commented Oct 7, 2017

@idvoretskyi yes

@verb
Copy link
Contributor Author

verb commented Oct 24, 2017

/remove-sig api-machinery
/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 24, 2017
@radu-matei
Copy link

Hi!
Is there anyone actively working on this?

I would really like to start contributing on it (realistically starting next week or so).

@verb
Copy link
Contributor Author

verb commented Jan 19, 2018

@radu-matei Yes, I'm actively working on it. I have some PRs lined up but we haven't quite finalized the API yet, see kubernetes/community#1269.

I'd love to have some help here, of course. Was there a particular area to which you'd like to contribute?

@radu-matei
Copy link

@verb I probably can work on kubectl right away, but I would also very much want to understand the API server and kubelet.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@parul5sahoo
Copy link

parul5sahoo commented Jun 10, 2022

Hello @verb 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage stable for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to update the following:

  • update the test plan section in the KEP README.md according to the latest template
  • Get the PRR for 1.25 milestone

Open PR #3384 is addressing above ^

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you! #

@verb
Copy link
Contributor Author

verb commented Jun 10, 2022

Hi @dchen1107, my only concern is that due to the release lag of cloud providers a portion of users haven't had an opportunity to try the feature and provide feedback. For example, 1.23 only became available in GKE's rapid channel last month. I was going to push graduation in the 1.26 cycle.

That being said, afaik we're feature complete, we have graduation criteria to measure some real-world usage, and 1.23 should have at least a couple of months in GKE's regular channel (I don't know about other providers) before code freeze. You're probably getting more feedback than I am. I support GA if you think it's time, and I'm available to work on it.

@Priyankasaggu11929
Copy link
Member

Hello, @verb 👋 I'm the lead for 1.25 Enhancements team.

Following the above comment #277 (comment), just a quick note that I'm updating the label to stage/stable for this 1.25 enhancement. Thank you so much! 🙂

@Priyankasaggu11929 Priyankasaggu11929 added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jun 11, 2022
@liggitt
Copy link
Member

liggitt commented Jun 13, 2022

For example, 1.23 only became available in GKE's rapid channel last month.

1.23 was available in January. 1.24 was available in May.

@parul5sahoo
Copy link

Hello @verb 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the PR with PRR and updated test plan merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is at-risk and will be marked tracked as soon as the PR gets merged . Thank you!

@parul5sahoo
Copy link

Thank you @verb for updating the test plan, the enhancement has been marked as tracked and is ready for Enhancements Freeze.

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 21, 2022

Hi @verb 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

(updated)I was unable to find out any k/k PRs promoting Ephermeral Containers KEP to stable. Could you please point me,if any related PRs are currently open or confirm if they're yet to be raised?

The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@verb
Copy link
Contributor Author

verb commented Jul 25, 2022

Hi @Priyankasaggu11929, thanks for following up. I've opened PRs and updated the description with links.

@Priyankasaggu11929
Copy link
Member

With all k/k code PRs merged now, the enhancement is ready for the 1.25 Code Freeze.

The status is now marked as tracked. Thank you so much! 🙂

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2022
@verb
Copy link
Contributor Author

verb commented Dec 15, 2022

With GA in 1.25, I'm happy to consider this KEP fully implemented. Thanks everyone! 🎉

I know there are still improvements we want to make for ephemeral containers, but let's track these with new KEPs. I'll send a PR to mark this implemented. 👍

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
@pacoxu
Copy link
Member

pacoxu commented Dec 16, 2022

EphemeralContainers feature gate was removed in kubernetes/kubernetes#114410 for v1.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests