Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet OpenTelemetry Tracing #2831

Open
8 of 12 tasks
sallyom opened this issue Jul 21, 2021 · 50 comments
Open
8 of 12 tasks

Kubelet OpenTelemetry Tracing #2831

sallyom opened this issue Jul 21, 2021 · 50 comments
Assignees
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@sallyom
Copy link
Contributor

sallyom commented Jul 21, 2021

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 21, 2021
@kikisdeliveryservice
Copy link
Member

@sallyom can you please add the mandatory discussion link to this issue?

@ehashman
Copy link
Member

ehashman commented Sep 8, 2021

/sig node instrumentation

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2021
@liggitt liggitt modified the milestone: v1.24 Oct 28, 2021
@logicalhan
Copy link
Member

/assign

@shiva1333
Copy link

/cc

2 similar comments
@yangjunmyfm192085
Copy link

/cc

@249043822
Copy link
Member

/cc

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 17, 2022
@hosseinsalahi
Copy link

hosseinsalahi commented Jan 20, 2022

Hello @sallyom

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting alpha for v1.24,

Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
    - KEP file PR is pending.
  • KEP status is marked as implementable for this release
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date for release v1.24.
Thanks!

@sallyom
Copy link
Contributor Author

sallyom commented Jan 20, 2022

@encodeflush thanks for the check-in - I'm not sure what the production readiness review is edit: found it, will add the questionnaire, I don't see it on the enhancements README can you point me to the steps to get that done? Thanks again. Also, am I meant to check those off as they are done or are they for someone else to decide?

@hosseinsalahi
Copy link

@sallyom Thanks for the update. Those criterion should be fulfilled form your side. From enhancements team point of view, we go through them and check if your KEP meets the requirements.

@chrisnegus
Copy link

Hi @sallyom 👋 1.24 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu March 31, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@valaparthvi
Copy link

valaparthvi commented Mar 21, 2022

Hi @sallyom 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

@hosseinsalahi
Copy link

Hello @sallyom

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as at risk.

Could you please confirm if following PR is part of the implementation for this enhancement?

Kindly please let me know if I'm missing any related PRs other than the ones I linked above. Thank you so much!

@ddebroy
Copy link
Member

ddebroy commented Mar 22, 2022

#3087 is not directly related to the overall OpenTelemetry enhancements.

@sallyom
Copy link
Contributor Author

sallyom commented Mar 23, 2022

kubernetes/kubernetes#105126 is the initial implementation for this enhancement

@valaparthvi
Copy link

valaparthvi commented Mar 29, 2022

Hi @sallyom 👋 1.24 Release Comms team here.

We have an opt-in process for the feature blog delivery. If you would like to publish a feature blog for this issue in this cycle, then please opt in on this tracking sheet.

The deadline for submissions and the feature blog freeze is scheduled for 01:00 UTC Wednesday 23rd March 2022 / 18:00 PDT Tuesday 22nd March 2022. Other important dates for delivery and review are listed here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.24#timeline.

For reference, here is the blog for 1.23.

Please feel free to reach out any time to me or on the #release-comms channel with questions or comments.

Thanks!

Hey @sallyom, can you please add a placeholder PR for this feature in https://github.com/kubernetes/website by March 30, that is our extended deadline for feature blog freeze?

Example of a feature blog PR: kubernetes/website#30538
Example of a feature blog: https://github.com/kubernetes/website/blob/main/content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md

@gracenng
Copy link
Member

Hi, 1.24 Enhancements Lead here 👋. With code freeze now in effect, this enhancement has not met the criteria for the freeze and has been removed from the milestone.

As a reminder, the criteria for code freeze is:

All PRs to the kubernetes/kubernetes repo have merged by the code freeze deadline
Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 30, 2022
@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 30, 2022
@saschagrunert saschagrunert added this to the v1.27 milestone Jan 11, 2023
@saschagrunert saschagrunert added lead-opted-in Denotes that an issue has been opted in to a release and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 11, 2023
@logicalhan
Copy link
Member

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 19, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @logicalhan @dashpole 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hey again @logicalhan @dashpole
Please try to get the KEP PR #3714 (addressing the changes mentioned above), merged before tomorrow's Enhancement Freeze :)
The status of this enhancement is still marked as at risk

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Feb 9, 2023

@Atharva-Shinde, PR seems to be merged now. This KEP should be OK

@marosset
Copy link
Contributor

This enhancement meets all the requirements to be tracked in v1.27.

Thanks @saschagrunert @sallyom @dashpole @SergeyKanzhelev !

@marosset marosset added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 10, 2023
saschagrunert added a commit to saschagrunert/kubernetes that referenced this issue Feb 14, 2023
We now graduate `KubeletTracing` to beta, which means we enable the
feature gate per default.

Part of kubernetes/enhancements#2831

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@katmutua
Copy link
Member

katmutua commented Mar 9, 2023

Hello @sallyom 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

@saschagrunert
Copy link
Member

Thank you @katmutua, the placeholder is now available in kubernetes/website#39904

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Mar 11, 2023

Hey again @saschagrunert @vrutkovs 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

k8s-publishing-bot pushed a commit to kubernetes/kubelet that referenced this issue Mar 15, 2023
We now graduate `KubeletTracing` to beta, which means we enable the
feature gate per default.

Part of kubernetes/enhancements#2831

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>

Kubernetes-commit: a28385ebe28ffa692e4b407b109d83018b0e5df7
@SergeyKanzhelev
Copy link
Member

@somalley, @dashpole do you want to GA in 1.28 as was planned in the issue description? It is not typical to do GA one release after beta as it typically doesn't give enough time to collect feedback.

@saschagrunert
Copy link
Member

(I agree this should stay in beta for at least one more release)

@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@dashpole
Copy link
Contributor

@saschagrunert Is GA planned for 1.30?

If it is, we need to add the 1.30 milestone, and the lead-opted-in label

@saschagrunert
Copy link
Member

@dashpole not planned for 1.30, do we want to target it for 1.31?

@dashpole
Copy link
Contributor

We definitely can, but we don't need to decide until the start of the 1.31 process. I'll check back in here then

rayowang pushed a commit to rayowang/kubernetes that referenced this issue Feb 9, 2024
We now graduate `KubeletTracing` to beta, which means we enable the
feature gate per default.

Part of kubernetes/enhancements#2831

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Deferred
Development

No branches or pull requests