Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for resizing PVs #284

Closed
gnufied opened this issue Apr 28, 2017 · 101 comments
Closed

Add support for resizing PVs #284

gnufied opened this issue Apr 28, 2017 · 101 comments
Assignees
@gnufied
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Kubernetes 1.7 features

Comments

@gnufied
Copy link
Member

gnufied commented Apr 28, 2017 •
edited

Feature Name

  • Add support for resizing existing PVs
  • Primary contact (assignee): Hemant Kumar( @gnufied)
  • Responsible SIGs: storage-sig
  • Design proposal link (community repo): Proposal for growing persistent volumes community#657
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers: @saad-ali @jsafrane
  • Approver (likely from SIG/area to which feature belongs): @jsafrane
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.8
      • File system resizing and GCE, EBS, Cinder volume type support : 1.9
    • Beta release target (x.y): 1.11
    • Stable release target (x.y): 1.24
@duglin
Copy link

duglin commented Apr 28, 2017

/cc @sandyamin123 @aniket-s-kulkarni

@idvoretskyi idvoretskyi added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 3, 2017
@idvoretskyi idvoretskyi added this to the v1.7 milestone May 3, 2017
@idvoretskyi
Copy link
Member

@gnufied can you update the feature description with the design proposal?

@idvoretskyi idvoretskyi added this to In Progress in Kubernetes 1.7 features May 3, 2017
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 9, 2017
@gnufied
Copy link
Member Author

gnufied commented May 23, 2017

Updated link to design proposal - kubernetes/community#657

@saad-ali
Copy link
Member

This will not ship alpha until 1.8 at the earliest, moving out of 1.7 milestone

@saad-ali saad-ali modified the milestones: next-milestone, v1.7 May 25, 2017
@gnufied
Copy link
Member Author

gnufied commented May 25, 2017

@saad-ali I know that timeline is pretty tight and code freeze is looming. But I would like to do my best to make this an alpha feature for 1.7. Yes - there is a chance, we may fail, but I don't see any harm in trying.

So - please, can we move this back to 1.7 milestone? I was hoping to have a discussion about this today in sig but we ran out of time. I am planning to schedule a call tomorrow morning.

@saad-ali saad-ali mentioned this issue May 25, 2017
Closed
@xingzhou xingzhou mentioned this issue Jun 9, 2017
Closed
@saad-ali
Copy link
Member

@saad-ali I know that timeline is pretty tight and code freeze is looming. But I would like to do my best to make this an alpha feature for 1.7. Yes - there is a chance, we may fail, but I don't see any harm in trying.

So - please, can we move this back to 1.7 milestone? I was hoping to have a discussion about this today in sig but we ran out of time. I am planning to schedule a call tomorrow morning.

I didn't mean to punt resize without your input @gnufied. Sorry about that. It just looked like there were a lot of big design questions, and I'd rather the team spend the time before 1.8 coding beings to close on those rather than rush the design and implementation. We can prioritize this higher for 1.8. Thanks for driving this!

@idvoretskyi
Copy link
Member

@gnufied I'd second @saad-ali's suggestion about not moving this item to 1.7 and keeping it for 1.8. Unfortunately, either feature or code freeze dates have already passed, so it is unlikely to add the new features now.

Would be happy to see this item in 1.8.

@gnufied
Copy link
Member Author

gnufied commented Jun 14, 2017

@saad-ali @idvoretskyi no worries. Yeah perhaps it was bit over ambitious to try and get this at such a later stage. Looking forward to get this done for 1.8 though. 🍰 🍰

@dutchiechris dutchiechris mentioned this issue Jul 7, 2017
Closed
@saad-ali saad-ali modified the milestones: 1.8, next-milestone Jul 12, 2017
@idvoretskyi idvoretskyi added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2017
@childsb childsb mentioned this issue Aug 30, 2017
Closed
@gnufied gnufied mentioned this issue Aug 31, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Sep 4, 2017
Merge pull request #49727 from gnufied/expand-pvc-plugin-changes
cd417b5 
Automatic merge from submit-queue (batch tested with PRs 49727, 51792)

Implement Controller for growing persistent volumes

This PR implements API and controller plane changes necessary for doing controller side resize.

xref :  kubernetes/community#657 

Also xref kubernetes/enhancements#284 

```
Add alpha support for allowing users to grow persistent volumes. Currently we only support volume types that just require control plane resize (such as glusterfs) and don't need separate file system resize. 
```
@jdumars
Copy link
Member

jdumars commented Sep 15, 2017

@gnufied do you have an update on missing docs? PR is due today.

@gnufied
Copy link
Member Author

gnufied commented Sep 15, 2017

I will open docs PR EOD today. sorry about the delay.

@jdumars
Copy link
Member

jdumars commented Sep 18, 2017

@gnufied any update on the docs PR?

@gnufied
Copy link
Member Author

gnufied commented Sep 18, 2017

I am on it. It is taking longer than I expected, I am really sorry about that. But it should all be in by today.

@gnufied gnufied mentioned this issue Sep 18, 2017
Merged
@gnufied
Copy link
Member Author

gnufied commented Oct 10, 2017

We partially implemented this in 1.8. we need to roll this feature over to 1.8. The feature design has already been merged.

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

The Enhancements Freeze is now in effect and this enhancement is removed from the release.
Please feel free to file an exception.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 4, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 4, 2022
@gnufied gnufied mentioned this issue Feb 4, 2022
Merged
@gracenng
Copy link
Member

gracenng commented Feb 7, 2022

Updated to tracked for 1.24

@gnufied
Copy link
Member Author

gnufied commented Feb 10, 2022

This issue still has "tracked: no". @gracenng is this expected?

@gracenng gracenng added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 11, 2022
@JamesLaverack JamesLaverack added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Feb 14, 2022
@PI-Victor
Copy link
Member

Hi @gnufied 👋 1.24 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@gracenng
Copy link
Member

Hi @gnufied 1.24 Enhancements Team here,
With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked PR. Kindly list them in this issue. Thanks!

@gracenng
Copy link
Member

Hi @gnufied, friendly bump on this as we're less than a week away from Freeze

@gnufied gnufied mentioned this issue Mar 25, 2022
Merged
@tengqm tengqm mentioned this issue Mar 29, 2022
Merged
@gracenng
Copy link
Member

All good for 1.24 code freeze 🥳

@gnufied gnufied mentioned this issue Mar 30, 2022
Merged
@github-actions github-actions bot mentioned this issue May 6, 2022
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mnpenner
Copy link

Not very clear, but I think this is available in k8s 1.24, and blog that is alluded to in the linked issue is probably this one: https://kubernetes.io/blog/2022/05/05/volume-expansion-ga/

@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
@mengjiao-liu mengjiao-liu mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnufied gnufied

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
No open projects
Kubernetes 1.7 features
In Progress
Milestone
No milestone
Development

No branches or pull requests