Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove klog specific command line arguments from Kubernetes components #2845

Closed
20 tasks done
serathius opened this issue Jul 30, 2021 · 41 comments
Closed
20 tasks done

Remove klog specific command line arguments from Kubernetes components #2845

serathius opened this issue Jul 30, 2021 · 41 comments
Assignees
@pohly @dgrisonnet
Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.

Comments

@serathius
Copy link
Contributor

serathius commented Jul 30, 2021 •
edited by dgrisonnet

Enhancement Description
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 30, 2021
@serathius
Copy link
Contributor Author

/sig arch
/sig instrumentation
/wg structured-logging

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jul 30, 2021
@k8s-ci-robot
Copy link
Contributor

@serathius: The label(s) sig/arch cannot be applied, because the repository doesn't have them.

In response to this:

/sig arch
/sig instrumentation
/wg structured-logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 30, 2021
@serathius serathius mentioned this issue Jul 30, 2021
Merged
@serathius
Copy link
Contributor Author

/sig architecture
/milestone v1.23

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Jul 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jul 30, 2021
serathius added a commit to serathius/enhancements that referenced this issue Sep 2, 2021
@serathius
Add PRR for kubernetes#2845
3a83f0a
@kevindelgado
Copy link
Contributor

kevindelgado commented Sep 3, 2021 •
edited

Hi @serathius! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo (PR Open).
  • KEP status is marked as implementable
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements (PR Open).

Looks like for this one we would just need the KEP (#2912) merge by enhancements freeze :)

All good now!

Thanks!

@kevindelgado
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 3, 2021
@kevindelgado
Copy link
Contributor

/tracked yes

serathius added a commit to serathius/enhancements that referenced this issue Sep 7, 2021
@serathius
Remove mention of --logtostdout flag in kubernetes#2845
921f7e6
@kevindelgado
Copy link
Contributor

Hi @serathius

Ping! As a reminder your PR (#2912 ) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

serathius added a commit to serathius/enhancements that referenced this issue Sep 9, 2021
@serathius
kubernetes#2845 Update PRR
ed0bd31
serathius added a commit to serathius/enhancements that referenced this issue Sep 9, 2021
@serathius
kubernetes#2845 Add dims as SIG arch approver
af7fdba
k8s-ci-robot pushed a commit that referenced this issue Sep 9, 2021
@serathius
Move KEP-2845 to implementable (#2912)
8568805 
* Move KEP-2845 to implementable

* Add PRR for #2845

* Remove mention of --logtostdout flag in #2845

* KEP #2485: Require splitting stdout/stderr to Json format

* Add pohly as reviewer for KEP 2845

* #2845 Update PRR

* #2845 Add dims as SIG arch approver
ravisantoshgudimetla pushed a commit to ravisantoshgudimetla/enhancements that referenced this issue Sep 9, 2021
@serathius @ravisantoshgudimetla
Move KEP-2845 to implementable (kubernetes#2912)
320e36f 
* Move KEP-2845 to implementable

* Add PRR for kubernetes#2845

* Remove mention of --logtostdout flag in kubernetes#2845

* KEP kubernetes#2485: Require splitting stdout/stderr to Json format

* Add pohly as reviewer for KEP 2845

* kubernetes#2845 Update PRR

* kubernetes#2845 Add dims as SIG arch approver
@ehashman ehashman mentioned this issue Sep 9, 2021
Closed
@serathius serathius mentioned this issue Sep 17, 2021
Closed
@mehabhalodiya
Copy link

Hi @serathius 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

@pohly pohly mentioned this issue Sep 28, 2021
Merged
@serathius
Copy link
Contributor Author

serathius commented Nov 1, 2021 •
edited

@pohly I have split Alpha work by milestones. I have assigned to you

  • Klog can be configured without registering flags
  • Kubernetes logging configuration drops global state

Please confirm and let me know when you will have PR for them.

@serathius
Copy link
Contributor Author

Marked "Klog can be configured without registering flags" as resolved as technically kubernetes/kubernetes#105076 moved klog flag registration into component-base allowing us to register only flags we want.

@serathius serathius mentioned this issue Nov 1, 2021
Closed
82 tasks
@pohly
Copy link
Contributor

pohly commented Nov 1, 2021

@pohly I have split Alpha work by milestones. I have assigned to you

* Klog can be configured without registering flags

* Kubernetes logging configuration drops global state

Please confirm

That's okay. As discussed in https://kubernetes.slack.com/archives/C020CCMUEAX/p1635445845031900, both will be solved by adding fields for -v and -vmodule to LoggingConfiguration. Those two fields then can be set without having to use command line flags (first line item) and the configuration can be passed around before being applied (second line item).

@pohly
Copy link
Contributor

pohly commented Nov 2, 2021

/assign

@serathius
Copy link
Contributor Author

Could you please confirm if following PR is part of the implementation for this enhancement?

@encodeflush all the work for Beta is done, I don't think this is a PR.

@hosseinsalahi
Copy link

Hello @serathius @pohly

I'm just checking in once more as we approach the 1.24 Code Freeze on 18:00 PDT, Tuesday, March 29th 2022

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are merged by the code freeze deadline.
  • Have a documentation placeholder PR open by 18:00 PDT, Thursday, March 31, 2022.

For note, the status of this enhancement is currently marked as tracked.

Could you please confirm if following PR is part of the implementation for this enhancement?
- #1602

Thank you!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 removed this from the v1.24 milestone May 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@pohly
Copy link
Contributor

pohly commented Aug 8, 2022

/remove-lifecycle stale

The goal is to complete the deprecation in 1.26.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2022
@pohly pohly mentioned this issue Aug 30, 2022
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@dgrisonnet
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2022
@dgrisonnet
Copy link
Member

@pohly should this be graduated to stable now that the flags have been removed in k/k?

@pohly
Copy link
Contributor

pohly commented Nov 8, 2022

Yes, I think we could do that.

@logicalhan logicalhan mentioned this issue Nov 8, 2022
Merged
@logicalhan
Copy link
Member

Yes, I think we could do that.

#3650

@sftim
Copy link
Contributor

sftim commented Nov 17, 2022

Could we change the issue title to "Remove klog specific command line arguments from Kubernetes components"?
(currently: "Deprecate klog specific flags in Kubernetes components", but we in fact plan to remove them as well)

@serathius serathius changed the title Deprecate klog specific flags in Kubernetes components Remove klog specific command line arguments from Kubernetes components Nov 17, 2022
@pohly
Copy link
Contributor

pohly commented Nov 17, 2022

/title Remove klog specific command line arguments from Kubernetes components

@logicalhan
Copy link
Member

/assign @dgrisonnet to find klog PRs

@k8s-ci-robot
Copy link
Contributor

@logicalhan: GitHub didn't allow me to assign the following users: PRs, to, find, klog.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @dgrisonnet to find klog PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet
Copy link
Member

Closing since the KEP is now stable and implemented.

enxebre added a commit to enxebre/hypershift that referenced this issue Jun 5, 2023
@enxebre
Remove alsologtostderr flag form CAP*
a5f6ed3 
This is needed to accomodate CAPI 1.4 coming in 4.14 payload https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.3-to-v1.4.html, kubernetes/enhancements#2845, kubernetes/kubernetes#112120
@enxebre enxebre mentioned this issue Jun 5, 2023
Merged
4 tasks
enxebre added a commit to enxebre/hypershift that referenced this issue Jun 6, 2023
@enxebre
Remove alsologtostderr flag form CAP*
37f4c69 
This is needed to accomodate CAPI 1.4 coming in 4.14 payload https://main.cluster-api.sigs.k8s.io/developer/providers/migrations/v1.3-to-v1.4.html, kubernetes/enhancements#2845, kubernetes/kubernetes#112120
@dgrisonnet dgrisonnet mentioned this issue Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

@dgrisonnet dgrisonnet

Labels
sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests