Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod conditions around readiness to start containers after completion of pod sandbox creation #3085

Closed
6 of 10 tasks
ddebroy opened this issue Dec 14, 2021 · 68 comments
Closed
6 of 10 tasks
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@ddebroy
Copy link
Member

ddebroy commented Dec 14, 2021

See #4138 for latest update.

Enhancement Description

KEP work continues on : #4138

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 14, 2021
@ddebroy
Copy link
Member Author

ddebroy commented Dec 14, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2021
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 17, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 17, 2022
@rhockenbury
Copy link

Hi @ddebroy! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

Please plan to merge #3087 by enhancements freeze to complete the above items. The status of this enhancement is at risk. Thanks!

@ddebroy
Copy link
Member Author

ddebroy commented Feb 1, 2022

PRR for the KEP is complete for 1.24. Waiting on final reviews from sig-node.

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

The Enhancements Freeze is now in effect and this enhancement is removed from the release.
Please feel free to file an exception.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Feb 4, 2022
@gracenng gracenng added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Feb 4, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@ddebroy
Copy link
Member Author

ddebroy commented May 5, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Hello @ddebroy 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the open KEP PR #3087 for following & get it merged by Enhancements Freeze:

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ddebroy
Copy link
Member Author

ddebroy commented Jun 13, 2022

I have updated the Test Plan section as recommended based on the latest template pointed out above.

@Priyankasaggu11929
Copy link
Member

Thanks for the quick update, @ddebroy 🙂

@ddebroy ddebroy changed the title Pod conditions around starting and completion of pod sandbox creation Pod conditions around completion of pod sandbox creation and pod networking configuration Jun 17, 2022
@Priyankasaggu11929
Copy link
Member

With KEP PR #3087 merged, the enhancement is ready for the 1.25 Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

@didicodes
Copy link

Hello @ddebroy 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

@parul5sahoo
Copy link

parul5sahoo commented Jul 22, 2022

Hi @ddebroy 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@kannon92
Copy link
Contributor

Hey @ddebroy, I want to update the description to remove the beta field and add some PRs that I have waiting for this. I am unable to edit it as it was created by you.

Can you add this under alpha (KEP (k/enhancements) update PR(s): #3778)

And can you add kubernetes/website#40945 to the website section so we track some of the PRs in the issue.

@katcosgrove
Copy link

Hello @ddebroy! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @ddebroy , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@kannon92
Copy link
Contributor

I believe this kubernetes/website#40945 should suffice.

I have one where I need to update the blog post from last year to say that it has been renamed.

@ruheenaansari34
Copy link

Hey again @ddebroy 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023.

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation-related PR/s.
  • All code-related PR/s are merged or are in a merge-ready state (i.e. they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related to PR/s too.

This is the code related PR/s that I found on this KEP issue:

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@kannon92
Copy link
Contributor

Thank you! I'm going to see if I can get some edit access to this issue so I can update the issue.

@Atharva-Shinde
Copy link
Contributor

Hey @kannon92 👋 Enhancements Lead here,
With kubernetes/kubernetes#111358 and kubernetes/kubernetes#117702 merged, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@kannon92
Copy link
Contributor

Thank you @Atharva-Shinde! I'm planning on copying this and creating a new issue so I can keep this up-to-date.

@kannon92
Copy link
Contributor

For next release, I'd like to target this for beta. One item I think may need to be addressed (kubernetes/kubernetes#117702 (comment)).

At Beta stage, I believe the recommendation is to have the Condition name going through an official API review and shifted out of the temporary pkg/kubelet/types/constants.go below?

@liggitt is this a common way to add new conditions to pods? I guess in beta we would want to move the condition name to be here (https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/v1/types.go#L2834?)

@liggitt
Copy link
Member

liggitt commented Jul 26, 2023

once we commit to publishing named conditions, we have to assume that external integrators will start to trigger off of those, so we treat it like an API surface. Yes, moving the constant to the api types package would be a good place to put it, and would pull in API review as a side-effect

@kannon92
Copy link
Contributor

once we commit to publishing named conditions, we have to assume that external integrators will start to trigger off of those, so we treat it like an API surface. Yes, moving the constant to the api types package would be a good place to put it, and would pull in API review as a side-effect

That makes sense. I think that can be a good call for Beta for this issue.

@kannon92
Copy link
Contributor

From @gracenng and sig-release (https://kubernetes.slack.com/archives/C0BP8PW9G/p1689178157530059), I am moving this to a new thread so I can keep the feature up-to-date since I will take over this feature.

#4138 is the new issue.

@ddebroy
Copy link
Member Author

ddebroy commented Jul 31, 2023

Thanks @kannon92!

@ddebroy
Copy link
Member Author

ddebroy commented Jul 31, 2023

Closing this issue as it is superseded by #4138

@ddebroy ddebroy closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@SergeyKanzhelev
Copy link
Member

/stage beta
/milestone v1.30

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.30 Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 26, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 1, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Removed From Milestone
Status: Tracked
Development

No branches or pull requests