Introduce nodeExpandSecret in CSI PV source #3107

humblec · 2022-01-05T09:34:25Z

Enhancement Description

CSI spec 1.5 enhanced the spec to add optional secrets field to
NodeExpandVolumeRequest. To support this, we need to have NodeExpandSecret to the
CSI PV source and also derive the expansion secret in csiclient to
send it out as part of the nodeexpand request.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

The text was updated successfully, but these errors were encountered:

humblec · 2022-01-05T09:34:49Z

/sig storage

humblec · 2022-01-05T09:36:09Z

Cc @xing-yang @msau42 @jsafrane @gnufied

humblec · 2022-01-05T09:36:23Z

Cc @zhucan

xing-yang · 2022-01-05T13:31:33Z

/milestone v1.24

msau42 · 2022-01-11T03:45:44Z

@humblec do you plan to put together a kep for this?

humblec · 2022-01-11T07:02:48Z

@humblec do you plan to put together a kep for this?

Yeah, thats the plan @msau42 .

rhockenbury · 2022-01-20T22:14:56Z

Hi @humblec! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze at 18:00pm PT on Thursday Feb 3rd. This enhancement is targeting alpha for 1.24.

Here’s where this enhancement currently stands:

Updated KEP file using the latest template has been merged into the k/enhancements repo.
KEP status is marked as implementable for latest-milestone: 1.24
KEP has a test plan section filled out.
KEP has up to date graduation criteria.
KEP has a production readiness review that has been completed and merged into k/enhancements.

Please plan to submit a KEP and PRR to satisfy this list of requirements. The status of this enhancement is at risk. Thanks!

Issue kubernetes#3107 Other comments: Prototype with working implementation kubernetes/kubernetes#105963 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

humblec · 2023-10-17T16:07:09Z

Hey there @humblec ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@Princesso kubernetes/website#43535 should cover the k/website part.

kcmartin · 2023-10-20T18:47:17Z

Hi @humblec! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

humblec · 2023-10-21T02:34:24Z

Yes, I am planning to publish blog for this feature. I will get a blog draft soon on the repo.

sreeram-venkitesh · 2023-10-27T17:20:36Z

Hey again @humblec 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

The status of this KEP is currently at risk for Code Freeze. I can see the following k/k PR for promoting this feature to stable:

Promote CSINodeExpandSecret to GA kubernetes#121303

Please update the issue description to include all the related PRs of this KEP under a new stable section in the Github issue description.

As always, we are here to help if any questions come up. Thanks!

xing-yang · 2023-10-31T19:53:57Z

@sreeram-venkitesh This PR kubernetes/kubernetes#121303 has got "lgtm" and "approved" label. It needs a rebase before it can be merged. Due to the time zone difference, the PR author won't be able to rebase it until tomorrow.

npolshakova · 2023-11-01T02:30:57Z

Hi @humblec, @xing-yang, 1.29 Enhancements lead here. This KEP is currently still at risk for code freeze. Once kubernetes/kubernetes#121303 is rebased and merged we can mark this KEP as tracked for code freeze. Let me know if you have any questions!

humblec · 2023-11-01T03:26:46Z

@npolshakova rebase is in progress and will be back to merge queue soon.

humblec · 2023-11-01T06:59:35Z

@npolshakova Its merged.. 🎉 . please mark it for code freeze.

sreeram-venkitesh · 2023-11-01T07:54:37Z

Marked as tracked for code freeze 🎉

kcmartin · 2023-11-13T19:45:21Z

@humblec @xing-yang Are you still planning to publish a blog for this feature? If so, we need the draft PR opened by tomorrow, Nov. 14. Thanks, from the 1.29 Release Communications team.

humblec · 2023-11-13T23:38:46Z

@kcmartin sure. I have filed (kubernetes/website#43921) . Thanks

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

Shadow contributions: - 1.27 shadow reviews: 6 - 1.28 shadow reviews: 9 - 1.29 - did not shadow due to time constraints with new SIG API Machinery TL role Planned contributions: - 1.30+ contribute to PRR, able to review roughly 12 KEPs per release. I am happy to PRR more than 12 so long as they are SIG API Machinery KEPs, since I'll be reviewing those anyway.. Shadow reviewer promotion criteria: Transitions from new to alpha - kubernetes#3983 - kubernetes#3751 Transitions from alpha to beta - kubernetes#3107 - kubernetes#2485 Transitions from beta to GA - kubernetes#2268 Three enhancements that require coordination between multiple components. - kubernetes#3751 - kubernetes#2485 - kubernetes#3107 Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile. - kubernetes#2268 (component skew) - kubernetes#2485 (component skew) - kubernetes#3751 (HA skew - feature gated fields, component skew) kubernetes#2268 (HA skew of controller considered) Three enhancements that are outside your primary domain. - kubernetes#3983 (SIG Node) - kubernetes#3751 (SIG Storage) - kubernetes#2268 (SIG Node) - kubernetes#3107 (SIG Storage) Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking. - Yes. E.g. kubernetes#2268 (ability to analyze cluster in aggregate considered, rescheduling considered) Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics. - Yes. E.g. kubernetes#3751 (new API call, volume of calls considered)

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

salehsedghpour · 2024-01-05T23:55:45Z

Hi @humblec , 👋 1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

salehsedghpour · 2024-01-06T16:56:54Z

/remove-label lead-opted-in

salehsedghpour · 2024-01-16T23:23:06Z

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

salehsedghpour · 2024-01-30T19:13:27Z

I'm closing this issue as it is completed.

humblec · 2024-01-31T06:49:56Z

@salehsedghpour yeah, this has been completed and we are good to close.. 👍

This commit flip the feature gate of `CSINodeExpandSecret` to Beta and default ON. Reference: kubernetes/enhancements#3107 kubernetes/enhancements#3531 Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 5, 2022

k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2022

k8s-ci-robot added this to the v1.24 milestone Jan 5, 2022

gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 12, 2022

humblec mentioned this issue Jan 21, 2022

KEP-3107: SecretRef field addition to NodeExpandVolume request #3173

Merged

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 14, 2023

CSI NodeExpansion GA promotion blog

c31b69e

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

humblec mentioned this issue Nov 14, 2023

CSI NodeExpansion GA promotion blog kubernetes/website#43921

Merged

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 16, 2023

CSI NodeExpansion GA promotion blog

00110f4

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023

CSI NodeExpansion GA promotion blog

6d05f65

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023

CSI NodeExpansion GA promotion blog

d3d4bed

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Nov 20, 2023

CSI NodeExpansion GA promotion blog

405ce01

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

jpbetz mentioned this issue Nov 22, 2023

Add jpbetz to prod-readiness-approvers #4343

Merged

humblec added a commit to humblec/kubernetes.github.io that referenced this issue Dec 4, 2023

CSI NodeExpansion GA promotion blog

edee156

KEP#kubernetes/enhancements#3107 Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>

k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024

carlory mentioned this issue Jan 7, 2024

mark 3107 as implemented #4391

Merged

k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024

salehsedghpour closed this as completed Jan 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce nodeExpandSecret in CSI PV source #3107

Introduce nodeExpandSecret in CSI PV source #3107

humblec commented Jan 5, 2022 •

edited by pacoxu

humblec commented Jan 5, 2022

humblec commented Jan 5, 2022

humblec commented Jan 5, 2022

xing-yang commented Jan 5, 2022

msau42 commented Jan 11, 2022

humblec commented Jan 11, 2022

rhockenbury commented Jan 20, 2022 •

edited

humblec commented Oct 17, 2023 •

edited

kcmartin commented Oct 20, 2023

humblec commented Oct 21, 2023

sreeram-venkitesh commented Oct 27, 2023

xing-yang commented Oct 31, 2023

npolshakova commented Nov 1, 2023

humblec commented Nov 1, 2023

humblec commented Nov 1, 2023

sreeram-venkitesh commented Nov 1, 2023

kcmartin commented Nov 13, 2023

humblec commented Nov 13, 2023 •

edited

salehsedghpour commented Jan 5, 2024 •

edited

salehsedghpour commented Jan 6, 2024

salehsedghpour commented Jan 16, 2024

salehsedghpour commented Jan 30, 2024

humblec commented Jan 31, 2024

Introduce nodeExpandSecret in CSI PV source #3107

Introduce nodeExpandSecret in CSI PV source #3107

Comments

humblec commented Jan 5, 2022 • edited by pacoxu

Enhancement Description

humblec commented Jan 5, 2022

humblec commented Jan 5, 2022

humblec commented Jan 5, 2022

xing-yang commented Jan 5, 2022

msau42 commented Jan 11, 2022

humblec commented Jan 11, 2022

rhockenbury commented Jan 20, 2022 • edited

humblec commented Oct 17, 2023 • edited

kcmartin commented Oct 20, 2023

humblec commented Oct 21, 2023

sreeram-venkitesh commented Oct 27, 2023

xing-yang commented Oct 31, 2023

npolshakova commented Nov 1, 2023

humblec commented Nov 1, 2023

humblec commented Nov 1, 2023

sreeram-venkitesh commented Nov 1, 2023

kcmartin commented Nov 13, 2023

humblec commented Nov 13, 2023 • edited

salehsedghpour commented Jan 5, 2024 • edited

salehsedghpour commented Jan 6, 2024

salehsedghpour commented Jan 16, 2024

salehsedghpour commented Jan 30, 2024

humblec commented Jan 31, 2024

humblec commented Jan 5, 2022 •

edited by pacoxu

rhockenbury commented Jan 20, 2022 •

edited

humblec commented Oct 17, 2023 •

edited

humblec commented Nov 13, 2023 •

edited

salehsedghpour commented Jan 5, 2024 •

edited