New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent unauthorised volume mode conversion during volume restore #3141
Comments
/sig storage |
Hi @RaunakShah ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting
The status of this enhancement is track as |
/milestone v1.24 |
@gracenng Yes, this is targeting Alpha in 1.24. |
Hi @RaunakShah , 1.24 Enhancements Team here. Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd. |
All good for 1.24 Enhancements Freeze |
@gracenng Should this have a Tracked/Yes label? |
Hi @xing-yang & @RaunakShah, 1.24 Docs shadow here. 👋 This enhancement is marked as Needs Docs for the 1.24 release. Please follow the steps detailed in the documentation to open a PR against the Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you! 🙌 |
Hi @RaunakShah 1.24 Enhancements Team here, With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is |
PRs are submitted here: |
@gracenng It might be better to label this feature as "tracked/out-of-tree" as all the code changes are out-of-tree. |
All good for Code Freeze! |
Hi @RaunakShah, reminder that tomorrow (April 5th) is the deadline for 1.24 Docs Ready for Review. Please open a PR (and link it back here), push your docs content for this enhancement, and remove the work-in-progress label when ready for review. We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by tomorrow. Thank you! |
Here's the doc PR: kubernetes/website#32673 |
@nate-double-u @xing-yang I've removed the WIP label from the doc PR. |
This enhancement proposal mentions the annotation |
We could do that in 1.25. |
A note for when this KEP goes to beta (targeting v1.25): the documentation that was added in v1.24 needs to be updated. |
/milestone clear |
Thank you @RaunakShah ! This enhancement is ready to be traced for graduation to beta in v1.27. /label tracked/yes |
@RaunakShah befora graduating to GA, please update the KEP, the new flag is in external-provisioner and snapshot-controller, not external-snapshotter sidecar: enhancements/keps/sig-storage/3141-prevent-volume-mode-conversion/README.md Lines 264 to 266 in 42a4b1c
In addition, there could be version skew between the external-provisioner (shipped by a CSI driver vendor) and snapshot-controller (shipped by Kubernetes vendor). I'd appreciate a little more detail in Version skew strategy chapter, now it says it's OK, but it does not say how do we achieve that. What exactly happens when there is new a external-provisioner with old snapshot-controller. |
Hi @RaunakShah 👋, Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023. Please ensure the following items are completed:
For this enhancement, it looks like all linked PRs are merged. Please let me know what other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks! |
Hi @fsmunoz, all code PRs are merged. Just docs/blog remaining. Thanks! |
Hello @RaunakShah 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
@pnbrown The KEP PR is merged. Please let us know if anything is missing. Thanks! |
@xing-yang Thank you. I've marked that complete. There is still one question on the readiness survey that is not answered: |
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀 |
Hello @RaunakShah, 👋 1.30 Docs Shadow here. |
Hi @RaunakShah , 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
@Princesso Here is the placeholder PR for the doc updates - kubernetes/website#45262 |
Hey again @RaunakShah 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
@RaunakShah, Enhancements team here! |
Hi @pnbrown, the only tickets remaining for this KEP are documentation and blog related. There are no other code changes that need to go in.
Sure will do! |
@RaunakShah, looks like the links for the blog and docs placeholder PRs got reversed in your comment above. The correct links are below: @Princesso Here is the placeholder PR for the doc updates - kubernetes/website#45261 Please note some important deadlines for comms and docs
Please reach out if you have any questions! |
Enhancement Description
One-line enhancement description (can be used as a release note): Prevent unauthorised volume mode conversion during volume restore.
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3141-prevent-volume-mode-conversion
Primary contact (assignee): @RaunakShah @xing-yang
Responsible SIGs: SIG-Storage
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Beta
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Stable
k/enhancements
) update PR(s): KEP-3141: Graduate "Prevent unauthorised volume mode conversion" to Stable #4459, KEP-3141: Add no known failure modes to README #4497Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: