Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow informers for getting a stream of data instead of chunking #3157

Open
4 of 8 tasks
p0lyn0mial opened this issue Jan 18, 2022 · 87 comments
Open
4 of 8 tasks

Allow informers for getting a stream of data instead of chunking #3157

p0lyn0mial opened this issue Jan 18, 2022 · 87 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@p0lyn0mial
Copy link
Contributor

p0lyn0mial commented Jan 18, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig api-machinery
/sig scalability

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Jan 18, 2022
@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 20, 2022
@gracenng gracenng added this to the v1.24 milestone Jan 20, 2022
@gracenng
Copy link
Member

Hi @p0lyn0mial ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo. KEP-3157: allow informers for getting a stream of data instead of chunking #3142
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
    - [ ] KEP has up to date graduation criteria. -- not needed for alpha
  • KEP has a production readiness review that has been completed and merged into k/enhancements -- PRR not found

The status of this enhancement is track as at risk
Thanks!

@p0lyn0mial
Copy link
Contributor Author

Hi @gracenng! Many thanks for the heads-up. Could you please double-check the last point? The KEP has the Production Readiness Review Questionnaire. In addition to that, I have filled the required bits for the alpha version - it just hasn't been reviewed yet.

@gracenng
Copy link
Member

Hi @p0lyn0mial,
Thanks for the reply. Your PRR Questionaire in the KEP needs to be approved by the PRR team, which will result in a file in
https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/
Your sig has not made a folder there yet, please check out the format.

Regarding your second point, I am tracking your KEP files and the first bullet will be checked when the PR is merged. Does that answer your question?

@gracenng
Copy link
Member

Hi @p0lyn0mial , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
There's no update for this enhancement since last checkin, let me know if I missed anything.
Current status is at risk

@p0lyn0mial
Copy link
Contributor Author

Hi @gracenng, it looks like it won't make it to 1.24. Please leave me some instructions on how to update the KEP so it won't show up on your query.

@gracenng
Copy link
Member

gracenng commented Jan 31, 2022 via email

@gracenng gracenng removed this from the v1.24 milestone Feb 4, 2022
@gracenng gracenng removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 4, 2022
@Dingshujie
Copy link
Member

@p0lyn0mial how is feature going? we met a lot of server overloading scene(kube-apiserver oom or master oom), looking forward to this feature. if you need help,you can assign some tasks to me.

@JohnRusk
Copy link

@Dingshujie BTW, if you have more than a few hundred nodes, then this fix will probably help to reduce API server load kubernetes/kubernetes#109381 . (If you have more than a few thousand nodes it will definitely help). It solves a bug where the kubelets would keep doing the same listing calls over and over again (typically immediately after a restart of the API server). Obvoiusly, other list issues are possible too, so that fix won't solve them all for you. But it might help.

@Dingshujie
Copy link
Member

@Dingshujie BTW, if you have more than a few hundred nodes, then this fix will probably help to reduce API server load kubernetes/kubernetes#109381 . (If you have more than a few thousand nodes it will definitely help). It solves a bug where the kubelets would keep doing the same listing calls over and over again (typically immediately after a restart of the API server). Obvoiusly, other list issues are possible too, so that fix won't solve them all for you. But it might help.

@JohnRusk thanks, i already cherry-pick this to 1.23 branch. but this fixs can't slove the situation that custom-defined operator list issues.
and finally expect all list from watch cache

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 24, 2022
@wojtek-t
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 26, 2022
@p0lyn0mial
Copy link
Contributor Author

/milestone v1.26

@liangyuanpeng
Copy link

/lifecycle frozen

for avoid fighting bots

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 4, 2024
@p0lyn0mial
Copy link
Contributor Author

@liangyuanpeng Could you please explain why you added the label? We are actively working on the issue, and the label you added suggests that the feature is frozen.

@mitar
Copy link

mitar commented Jan 4, 2024

Label means that the stale bot will not complain anymore. So state of the issue is frozen at current state (live, instead of going to stale->rotten->closed).

@liangyuanpeng
Copy link

liangyuanpeng commented Jan 4, 2024

@mitar Thanks for help to explain! that's exactly what i want to say.

@p0lyn0mial This is different from the lifecycle in release, I'm sorry for causing any confusion.

@p0lyn0mial
Copy link
Contributor Author

@p0lyn0mial This is different from the lifecycle in release, I'm sorry for causing any confusion.

@liangyuanpeng np, I think I misunderstood the purpose of the label. Thank you both for explaining.

@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2024

/milestone v1.30
/label lead-opted-in
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

@deads2k: Can not set label tracked/yes: Must be member in one of these teams: [release-team-enhancements release-team-leads]

In response to this:

/milestone v1.30
/label lead-opted-in
/label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjons
Copy link

tjons commented Jan 31, 2024

Hello @p0lyn0mial 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage beta for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria (it looks like this has not merged yet)
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Merge the KEP changes readme into the k/enhancements repo.
  • Mark this KEP as implementable for latest-milestone: 1.30.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@p0lyn0mial
Copy link
Contributor Author

Hey @tjons, I think that the KEP is up to date. Please double-check on my answers and feel free to share more details if there is anything that is missing.

Merge the KEP changes readme into the k/enhancements repo.

Could you please be more specific about what changes should be merged into the readme?
I think that the KEP is using the latest template.

Mark this KEP as implementable for latest-milestone: 1.30.

It looks like the KEP is marked as implementable for latest-milestone: 1.30.
Is there a different file I should update?

@tjons
Copy link

tjons commented Feb 8, 2024

Hey @p0lyn0mial - thanks for checking in, you're right! Everything looks good.

With all the requirements met, this enhancement is now tracked for enhancements freeze 🚀

@Princesso
Copy link

Hello @p0lyn0mial, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@kcmartin
Copy link

Hi @p0lyn0mial ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@p0lyn0mial
Copy link
Contributor Author

Hello @p0lyn0mial, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?

@Princesso I've opened a placeholder PR for now - kubernetes/website#45283

@p0lyn0mial
Copy link
Contributor Author

Hi @p0lyn0mial ,
👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

@kcmartin done, i've opened kubernetes/website#45285 and kubernetes/website#45286 (for now as placeholders).

@tjons
Copy link

tjons commented Feb 25, 2024

Hey again @p0lyn0mial 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons
Copy link

tjons commented Mar 6, 2024

Hey @p0lyn0mial - checking in again. The code freeze is in about ~6 hours. Do you think you'll be able to get the above PR merged in time?

@salehsedghpour
Copy link
Contributor

Hello @p0lyn0mial 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
@p0lyn0mial
Copy link
Contributor Author

Hey, we will miss the 1.30 milestone. There are a few beta criteria that haven't been completed, and there is a blocker bug in etcd that needs to be patched and adopted by Kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Status: Tracked
Status: Removed from Milestone
Status: Removed from Milestone
Development

No branches or pull requests