Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up IPTables Chain Ownership #3178

Closed
13 of 15 tasks
danwinship opened this issue Jan 23, 2022 · 46 comments
Closed
13 of 15 tasks

Cleaning up IPTables Chain Ownership #3178

danwinship opened this issue Jan 23, 2022 · 46 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@danwinship
Copy link
Contributor

danwinship commented Jan 23, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 23, 2022
@danwinship
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2022
@thockin thockin added this to the v1.25 milestone Jan 26, 2022
@thockin
Copy link
Member

thockin commented Jan 26, 2022

This is tagged for 1.25 - is that right?

@thockin thockin self-assigned this Jan 26, 2022
@danwinship
Copy link
Contributor Author

@thockin yeah... oh, I explained in the PR but not here. It involves changing the same pieces of code that the internal traffic policy and proxy terminating endpoints and preferlocal traffic policy KEPs are changing, and I wasn't sure we had time to queue another change on top of those ones for 1.24. And it's not like it's urgent or anything anyway...

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2022
@danwinship
Copy link
Contributor Author

/remove-lifecycle rotten

@thockin
Copy link
Member

thockin commented Jun 20, 2022

Added to spreadsheet for 25

@johnbelamaric
Copy link
Member

Is this still planning on going to stable in 1.28? I don't see a KEP update PR.

@aojea
Copy link
Member

aojea commented Jun 14, 2023

ping @danwinship

@johnbelamaric
Copy link
Member

Still don't see a KEP PR to bump this to GA?

@thockin
Copy link
Member

thockin commented Jun 15, 2023 via email

@Atharva-Shinde
Copy link
Contributor

Thanks @thockin :)
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀.
The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

@Atharva-Shinde Atharva-Shinde added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 15, 2023
@Atharva-Shinde
Copy link
Contributor

Hey again @danwinship 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@danwinship
Copy link
Contributor Author

danwinship commented Jul 17, 2023

Sorry, this was discussed in the SIG but not updated here; we are not going to GA for 1.28, we are waiting for 1.29.
oops, no, wrong KEP!

@thockin thockin moved this from Beta gated (merged) to GA (merged, gate not removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jul 17, 2023
@thockin
Copy link
Member

thockin commented Jul 17, 2023

Code is approved

@Atharva-Shinde
Copy link
Contributor

Hey @danwinship 👋 Enhancements Lead here,
With kubernetes/kubernetes#119374 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@danwinship
Copy link
Contributor Author

/assign

@thockin thockin modified the milestones: v1.28, v1.30 Aug 17, 2023
@npolshakova
Copy link

Hey @danwinship 👋 1.29 Enhancements Lead here, is there any more work planned for this KEP? Also is the milestone accurate (are you targeting v1.30 instead of v1.29?)

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 8, 2023
@danwinship
Copy link
Contributor Author

@npolshakova I'm not sure this needs to be tracked by the release team at this point, since it is already GA. The issue is just being left open to remind us to finish the cleanup 2 releases post-GA (so yes, the next expected change is in 1.30, not 1.29).

@carlory
Copy link
Member

carlory commented Dec 18, 2023

the feature-gate was removed in kubernetes/kubernetes#122137

@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
@aojea
Copy link
Member

aojea commented Feb 20, 2024

It seems this is done, so I'm going to close it
/close

@k8s-ci-robot
Copy link
Contributor

@aojea: Closing this issue.

In response to this:

It seems this is done, so I'm going to close it
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Status: Tracked
Obsolete: SIG-Network KEPs (see https...
GA (merged, gate not removed)
Development

No branches or pull requests