Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS v2 Improvements #3299

Closed
8 tasks done
ritazh opened this issue May 9, 2022 · 65 comments · Fixed by #4380
Closed
8 tasks done

KMS v2 Improvements #3299

ritazh opened this issue May 9, 2022 · 65 comments · Fixed by #4380
Assignees
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@ritazh
Copy link
Member

ritazh commented May 9, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 9, 2022
@ritazh
Copy link
Member Author

ritazh commented May 9, 2022

/sig auth

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 9, 2022
@enj enj added this to Needs Triage in SIG Auth Old May 13, 2022
@ritazh
Copy link
Member Author

ritazh commented May 31, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label May 31, 2022
@ritazh ritazh moved this from Needs Triage to In Review in SIG Auth Old May 31, 2022
@enj
Copy link
Member

enj commented Jun 6, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 6, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 8, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 9, 2022

Hello @ritazh 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 9, 2022)

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following in the open KEP PR #3302:

For note, the status of this enhancement is marked as at risk. Thank you for keeping the issue description up-to-date!

@Priyankasaggu11929
Copy link
Member

Hello @ritazh 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the pending items done before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

@Priyankasaggu11929
Copy link
Member

With KEP PR #3302 merged, the enhancement is ready for 1.25 enhancements freeze.

For note, the status is now marked as tracked in the enhancements tracking sheet. Thank you!

@didicodes
Copy link

Hello @ritazh 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hi @ritazh, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

@Atharva-Shinde
Copy link
Contributor

Hey @ritazh reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022.
Try to get the action items done which are mentioned in the comment above before the code-freeze :)
The status of the enhancement is still marked as at-risk

@ritazh
Copy link
Member Author

ritazh commented Aug 1, 2022

Thanks @Atharva-Shinde! kubernetes/kubernetes#111126 is currently waiting to be reviewed again by the approvers.

@Priyankasaggu11929
Copy link
Member

Hello 👋, 1.25 Enhancements Lead here.

Unfortunately, this enhancement did not meet the code freeze criteria because there are still unmerged k/k code PRs.

If you still wish to progress this enhancement in v1.25, please file an exception request. Thank you so much!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 3, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@ritazh
Copy link
Member Author

ritazh commented Aug 3, 2022

@Priyankasaggu11929 FYI the exception request has been approved. kubernetes/kubernetes#111126 (comment)

@Priyankasaggu11929
Copy link
Member

Thanks for the update @ritazh.

With the k/k PR also merged, I am marking it as tracked for 1.25 release cycle. Thank you so much!

@Priyankasaggu11929 Priyankasaggu11929 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Aug 4, 2022
@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.25 milestone Aug 4, 2022
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jul 19, 2023

Thanks for filling an exception request! I'll reapply the v1.28 milestone if the exception request is approved.
/milestone clear

The exception request was approved! Applying the v1.28 milestone again :)

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jul 19, 2023
@Atharva-Shinde Atharva-Shinde added this to the v1.28 milestone Jul 19, 2023
@Rishit-dagli
Copy link
Member

Hello @ritazh wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42076

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@liggitt
Copy link
Member

liggitt commented Aug 28, 2023

/label lead-opted-in

we're continuing work on this in 1.29, planning to graduate to GA

@liggitt liggitt modified the milestones: v1.28, v1.29 Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Aug 28, 2023
@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Sep 23, 2023

Hello @ritazh 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

Everything is up to date and KEP is tracked for the enhancements freeze 🎉

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@aramase
Copy link
Member

aramase commented Oct 2, 2023

Update the latest milestone to 1.29 in the kep.yaml file.

@sreeram-venkitesh The kep.yaml you have tagged is from my fork which is incorrect. The kep.yaml in the enhancements repo has latest milestone set to 1.29 for this KEP.

Have a completed PRR review merged into k/enhancements for the stable stage.

Same issue as above. The link referenced/validated is from my fork. The PRR review is complete and the PRR in this repo is up-to-date.

stable:
approver: "@deads2k"

@liggitt liggitt added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 2, 2023
@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Oct 3, 2023

@aramase Apologies for the oversight! Thanks for clarifying, I've updated my comment above and the enhancement tracking sheet to Tracked for enhancements freeze 🎉

@katcosgrove
Copy link

Hey there @enj and @ritazh! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@James-Quigley
Copy link

Hi @ritazh 👋 from the v1.29 Communications Release Team! We would like to check if you have any plans to publish blogs for this KEP regarding new features, removals, and deprecations for this release.
If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)
Here's the 1.29 Calendar

@sreeram-venkitesh
Copy link
Member

Hey again @ritazh 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

The status of this KEP is currently at risk for Code Freeze. Please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Nov 1, 2023

Hello @ritazh @aramase 👋, 1.29 Enhancements team here.

With all the following implementation(code related) PRs merged into k/k, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀 Are there any other PRs other than the following ones? If there are any other PRs that needs to be tracked, please let us know. Also please update the issue description with the following PRs:

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

Please let me know if there are additional test PRs we should track. Thanks!

@liggitt
Copy link
Member

liggitt commented Jan 3, 2024

@ritazh @aramase @enj can we mark this implemented and close out the issue now?

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Graduating
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
Archived in project
SIG Auth Old
In Review
Development

Successfully merging a pull request may close this issue.