/sig network
/sig cloud-provider

Punting to 1.27

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

/label lead-opted-in

/retitle Remove transient node predicates from KCCM's service controller

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

yes please - this one doesn't have APi so doesn't need an alpha

Thanks @thockin @alexanderConstantinescu

Once #3835 merges this enhancement will be ready for inclusion in v1.27

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

Hi @thockin 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

Pinging this after sig-net - let's decide if this moves to GA in 1.30

I'll let it soak at least one release more kubernetes/kubernetes#121116, WDYT @alexanderConstantinescu , just to get signal, these things take some time to detect

I'll let it soak at least one release more kubernetes/kubernetes#121116, WDYT @alexanderConstantinescu , just to get signal, these things take some time to detect

I am fine with this. I'm filing a PR updating the enhancement with a stable milestone set for 1.30

1.30 is next - did you mean 31?

1.30 is next - did you mean 31?

I meant 1.30. My understanding is: if we want to "soak for one more release" then we extend the current milestone by one release. This feature was marked stable: 1.29, but I forgot to update the feature gate in Kube for this feature in 1.29, so it's still in beta. Extending beta by one release therefore means we go to stable in 1.30...does this makes sense?

@aojea : did you mean that we should go to stable in 1.31?

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

+1

I'll let Antonio decide, following how strongly he feels about it

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

not really, major providers have to revendor and use to take some time to pick up these changes, all cloud provider code moved to external cloud providers, and it was beta but we had a fix in 1.29 with backports kubernetes/kubernetes@2032b74

although, we are going to remove the cloud providers tests this release (most probably), so it will be useless to get it another release more, @alexanderConstantinescu go ahead and GA this then

Also, from the original bug:

"""
This PR should have no effect on >= 1.27 since the predicates are already aligned under the feature gate StableLoadBalancerNodeSet, but this should get in so that we guard against the broken behaviour should someone turn that feature gate off.
"""

It was about a regression on 1.26 or when the gate was disabled.

It was about a regression on 1.26 or when the gate was disabled.

oh, my fault, sorry, I skipped that super important detail 😓

Hello @alexanderConstantinescu and @thockin 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Make sure that the KEP has the production readiness review. (For more information on the PRR process, check here).

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@salehsedghpour : I made a mistake in the last release and got a prr-review for Stable, but forgot to update the code afterwards. In this release we're only updating the code and the prr-review file already exists, see: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3458.yaml

Is this fine?

Yes, thanks for the clarification. With this information, this enhancements is now tracked for enhancement freeze.

Hi @alexanderConstantinescu and @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @thockin,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

Hey again @alexanderConstantinescu and @thockin 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour : this is the only PR which was needed for this release: kubernetes/kubernetes#122961 - the implementation was done a while ago. This PR just promotes the feature to stable

@alexanderConstantinescu thanks for clarification. As kubernetes/kubernetes#122961 is already merged, this can now be marked as tracked for code freeze.

May you please also make sure that this PR is added to issue description as well?

@alexanderConstantinescu, Enhancements team here!
As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented after code PRs are merged and the feature gates are removed.

Hi @salehsedghpour : just to confirm: this feature is going GA in 1.30, so we will remove the feature gate in 1.31. Should I mark it implemented in 1.31 or 1.30 ?

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

Will do!