Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Component Health SLIs #3466

Closed
25 tasks done
logicalhan opened this issue Aug 16, 2022 · 37 comments
Closed
25 tasks done

Kubernetes Component Health SLIs #3466

logicalhan opened this issue Aug 16, 2022 · 37 comments
Assignees
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@logicalhan
Copy link
Member

logicalhan commented Aug 16, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2022
@Kanika637
Copy link

Kanika637 commented Aug 24, 2022

Hey @logicalhan, can you give some more context on this issue?
I might can work on this

@logicalhan logicalhan added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2022
@logicalhan
Copy link
Member Author

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2022
@dashpole
Copy link
Contributor

dashpole commented Sep 8, 2022

/assign @logicalhan

@dashpole dashpole added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 8, 2022
@rhockenbury
Copy link

/milestone 1.26

@k8s-ci-robot
Copy link
Contributor

@rhockenbury: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury
Copy link

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 11, 2022
@logicalhan
Copy link
Member Author

/assign @wojtek-t

@logicalhan logicalhan changed the title Kubernetes Healthchecks in Metric Format Kubernetes Component Health SLIs Sep 16, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 16, 2022

👋 Hello @logicalhan , 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.
This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury rhockenbury added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 18, 2022
@wojtek-t wojtek-t assigned logicalhan and unassigned logicalhan and wojtek-t Sep 21, 2022
@logicalhan
Copy link
Member Author

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

@ruheenaansari34 I've updated the KEP using the template. Would you mind re-assessing it?

@ruheenaansari34
Copy link

@logicalhan Thank you. I've re-assessed it and looks like we still need KEP owner's acknowledgement in the Test plan section of KEP's README.
Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

@logicalhan
Copy link
Member Author

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Would you mind reviewing this: #3564?

@logicalhan
Copy link
Member Author

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Done.

@ruheenaansari34
Copy link

Excellent. Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jberkus
Copy link
Contributor

jberkus commented Oct 18, 2022

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

@logicalhan
Copy link
Member Author

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

Sure done.

@rhockenbury
Copy link

Hi @logicalhan 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Let me know if there's any PRs that aren't mentioned in the issue description that we should be tracking.

As always, we are here to help should questions come up. Thanks!

@npolshakova
Copy link

Hi @logicalhan,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@logicalhan
Copy link
Member Author

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Mar 11, 2023
@mickeyboxell
Copy link

mickeyboxell commented Mar 15, 2023

Hi @logicalhan 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by tomorrow, March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@mickeyboxell
Copy link

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

@logicalhan
Copy link
Member Author

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

kubernetes/website#40064

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2023
@logicalhan logicalhan added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 22, 2023
@logicalhan
Copy link
Member Author

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 22, 2023
@logicalhan logicalhan added this to the v1.29 milestone Sep 22, 2023
@npolshakova
Copy link

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@logicalhan
Copy link
Member Author

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Done

@npolshakova
Copy link

Thanks! With https://github.com/kubernetes/enhancements/pull/4241/files merged in, this KEP is now tracked for enhancement freeze! 🚀

@Princesso
Copy link

Hey there @logicalhan ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@Princesso
Copy link

Hi @logicalhan, the deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of the docs for this enhancement? Thank you!

@logicalhan
Copy link
Member Author

Hi @logicalhan, the deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of the docs for this enhancement? Thank you!

kubernetes/website#43562

@kcmartin
Copy link

Hi @logicalhan! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@npolshakova
Copy link

Hey again @logicalhan 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs has merged and update in the Issue description:

With this pr merged and the status updated to implemented, the status of this KEP is tracked for code freeze. 🚀

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Jan 5, 2024

Hi, 👋 v1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is updated to implemented, so it seems that is completed and we can close it. Shall we?

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

This issue can be closed as it is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Net New
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests