Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeGroupSnapshot #3476

Open
2 of 4 tasks
xing-yang opened this issue Aug 25, 2022 · 25 comments · Fixed by #1551
Open
2 of 4 tasks

VolumeGroupSnapshot #3476

xing-yang opened this issue Aug 25, 2022 · 25 comments · Fixed by #1551
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Aug 25, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 25, 2022
@xing-yang
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 25, 2022
@xing-yang xing-yang self-assigned this Aug 30, 2022
@xing-yang
Copy link
Contributor Author

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@xing-yang xing-yang added lead-opted-in Denotes that an issue has been opted in to a release stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 7, 2022
@msau42 msau42 linked a pull request Sep 20, 2022 that will close this issue
@msau42 msau42 linked a pull request Sep 20, 2022 that will close this issue
@rhockenbury rhockenbury added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 20, 2022

Hello @xing-yang 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ruheenaansari34
Copy link

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the kep.yaml, and README and get the PR merged.

@xing-yang
Copy link
Contributor Author

@ruheenaansari34 Thanks for the reminder! I updated the KEP and moved test plan and graduation criteria under design details section.

@ruheenaansari34
Copy link

@xing-yang Thank you. I've re-assessed it and looks like we still need

Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

  • "Drawbacks" and "Alternatives" sections (if applicable) are added after "Implementation History".

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

@xing-yang
Copy link
Contributor Author

@ruheenaansari34 I've updated the KEP PR with the owner's acknowledgment and also moved "Alternatives" after "Implementation History". PTAL. Thanks.

@ruheenaansari34
Copy link

Thank you. Please ensure the PR is merged before enhancements freeze at 18:00 PDT today and that will fulfill requirements.

@xing-yang
Copy link
Contributor Author

Hi @ruheenaansari34, we need more time to finalize the design details so the KEP won't be merged today. Since the implementation is completely out-of-tree, we will continue to work on it. When you remove the tracked/yes label, can you please also add the tracked/out-of-tree label? Thanks!

@rhockenbury rhockenbury added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Oct 7, 2022
@rhockenbury
Copy link

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2023
@xing-yang
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2023
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2023
@xing-yang xing-yang added this to the v1.27 milestone Jan 12, 2023
@xing-yang xing-yang changed the title VolumeGroup and VolumeGroupSnapshot VolumeGroupSnapshot Jan 26, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jan 31, 2023

Hello @xing-yang 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@johnbelamaric
Copy link
Member

The new question is not needed for alpha but would be nice to have. The PRR approval is still in place from last cycle, and I went through commit-by-commit and all the answers on the updated KEP look consistent with the previous discussions. So PRR is approved.

@johnbelamaric
Copy link
Member

@Atharva-Shinde I updated the PRR checkbox above

@Atharva-Shinde
Copy link
Contributor

Hey again @xing-yang
Please try to get the KEP PR #1551, merged before tomorrow's Enhancement Freeze :)
The status of this enhancement is still marked as at risk

@xing-yang
Copy link
Contributor Author

@Atharva-Shinde The KEP is merged.

@Atharva-Shinde
Copy link
Contributor

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@LukeMwila
Copy link

Hi @xing-yang, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @xing-yang 👋 Enhancements team here,
Can you please include the kubernetes/kubernetes code PRs related to this KEP in the Issue description, this will make it easier to track the code related PRs of this KEP.

@xing-yang
Copy link
Contributor Author

xing-yang commented Mar 14, 2023

Hi @Atharva-Shinde, all code development are out of tree in this repo: https://github.com/kubernetes-csi/external-snapshotter. So we don't need to follow the k/k code freeze deadline. It already has a "tracked/out-of-tree" label. Thanks!

@xing-yang
Copy link
Contributor Author

Hi @LukeMwila, since all the code will be developed out of tree, the docs will also be out of tree here: https://kubernetes-csi.github.io/docs/. So I think we don't need to add docs in k/website. Thanks!

@marosset
Copy link
Contributor

/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 20, 2023
@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@xing-yang
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
Status: Net New
Status: Tracked
Development

Successfully merging a pull request may close this issue.

9 participants