Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Device Manager to kubelet #3573

Closed
4 tasks done
swatisehgal opened this issue Oct 2, 2022 · 14 comments · Fixed by #3987
Closed
4 tasks done

Add Device Manager to kubelet #3573

swatisehgal opened this issue Oct 2, 2022 · 14 comments · Fixed by #3987
Assignees
@swatisehgal
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.26

Comments

@swatisehgal
Copy link
Contributor

swatisehgal commented Oct 2, 2022 •
edited

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

Addtional References:

NOTE: The graduation of Device Plugin API to GA is out of scope of this KEP and will be covered in a separate KEP in the future. Discussion on this topic can be found here.

  1. Original Issue: Extension to support new compute resources #368
  2. Original Proposal: Device Plugin Design Proposal community#695 currently present here: https://github.com/kubernetes/design-proposals-archive/blob/main/resource-management/device-plugin.md
  3. Device Plugin Work Tracker Issues: Device plugins work tracker kubernetes#53497 and Device Plugin Beta work tracker kubernetes#56649
  4. Beta Graduation: DevicePlugins feature is beta in 1.10 release kubernetes#60170
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 2, 2022
@swatisehgal
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2022
@swatisehgal swatisehgal changed the title Graduate to DeviceManager to GA Graduate DeviceManager to GA Oct 2, 2022
@swatisehgal swatisehgal mentioned this issue Oct 2, 2022
Merged
@marosset
Copy link
Contributor

marosset commented Oct 3, 2022

/milestone v1.26
/label lead-opted-in
(Doing this on behalf of sig-node https://kubernetes.slack.com/archives/C0BP8PW9G/p1664788920990529)

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
@rhockenbury
Copy link

/stage stable
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 3, 2022
@marosset
Copy link
Contributor

marosset commented Oct 3, 2022 •
edited

Hello @swatisehgal 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage stable for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #3574 will address all of these requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@marosset
Copy link
Contributor

marosset commented Oct 6, 2022

With #3574 merged this enhancement is tracked for the v1.26 release. Thank you!

@sftim
Copy link
Contributor

sftim commented Oct 10, 2022

I recommend cracking on with early work on a docs update so that these are GA quality (or have PRs open to make them be) by the appropriate review deadline.

@swatisehgal
Copy link
Contributor Author

@sftim Sure, will do.

This was referenced Oct 11, 2022
Merged
Merged
@ffromani ffromani mentioned this issue Oct 12, 2022
Merged
@sftim sftim mentioned this issue Oct 19, 2022
Merged
@swatisehgal swatisehgal mentioned this issue Oct 24, 2022
Merged
@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 2, 2022 •
edited

Hi @swatisehgal 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before the code freeze. Please link any other PRs that should be tracked beyond the below PR:

As always, we are here to help should questions come up. Thanks!

@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 7, 2022 •
edited

For this enhancement, it looks like the k/k PR kubernetes/kubernetes#112980 is closed 🎉. If you do have any other k/k PRs open, please link them to this issue.

@krol3
Copy link

krol3 commented Nov 9, 2022

Hello @swatisehgal 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@marosset marosset removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Dec 12, 2022
@marosset
Copy link
Contributor

Hi @swatisehgal since this enhancement has graduated to stable can you please update https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3573-device-plugin/kep.yaml setting the status to implemented and then close this issue.
Thanks!

@sftim
Copy link
Contributor

sftim commented Dec 22, 2022

Maybe the title of this issue should be “Add Device Manager to kubelet”

@swatisehgal swatisehgal changed the title Graduate DeviceManager to GA Add Device Manager to kubelet Jan 24, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2023
@SergeyKanzhelev SergeyKanzhelev mentioned this issue May 5, 2023
Merged
@SergeyKanzhelev
Copy link
Member

Send #3987 that will close this issue

@kikisdeliveryservice kikisdeliveryservice removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swatisehgal swatisehgal

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
1.26 Enhancements Tracking
Status: Graduating
Milestone
v1.26
Development

Successfully merging a pull request may close this issue.

DeviceManager is GA now SergeyKanzhelev/enhancements
10 participants
@rhockenbury @kikisdeliveryservice @krol3 @SergeyKanzhelev @marosset @swatisehgal @k8s-ci-robot @ruheenaansari34 @sftim @k8s-triage-robot