Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kubectl plugin resolution for non-shadowing subcommands #3638

Open
8 tasks done
ardaguclu opened this issue Oct 24, 2022 · 30 comments
Open
8 tasks done

Improve kubectl plugin resolution for non-shadowing subcommands #3638

ardaguclu opened this issue Oct 24, 2022 · 30 comments
Assignees
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@ardaguclu
Copy link
Member

ardaguclu commented Oct 24, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 24, 2022
@ardaguclu
Copy link
Member Author

/milestone v1.27

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2022
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/assign @ardaguclu

@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 12, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu
Copy link
Member Author

Thanks @Atharva-Shinde. I added response for the newly added Scalability question. Is there anything further I can do aside from waiting for PRR review?

@Atharva-Shinde
Copy link
Contributor

Hey @ardaguclu, aside from getting PRR approved, everything for this KEP looks good for now :)

@ardaguclu
Copy link
Member Author

Thanks @Atharva-Shinde

@Atharva-Shinde
Copy link
Contributor

@ardaguclu With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu ardaguclu changed the title kubectl built-in command shadowing by external plugins Improve kubectl plugin resolution for non-shadowing subcommands Feb 14, 2023
@sftim
Copy link
Contributor

sftim commented Mar 6, 2023

Docs PR: kubernetes/website#39800

@LukeMwila
Copy link

Hi @ardaguclu, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey again @ardaguclu 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2023
@marckhouzam
Copy link
Member

@ardaguclu This is pretty cool! Looking at the KEP, I didn't see any mention of shell completion support. As long as the "sub plugins" are kept under the "create" command, there isn't much need for shell completion support. However, if this is meant to be generalized, it may be useful to support shell completion for such sub-plugins as well.

Here is the section of the plugin KEP describing how shell completion is supported: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2379-kubectl-plugins#shell-completion-support
And here is the PR that add such support kubernetes/kubernetes#105867

@ardaguclu ardaguclu changed the title Improve kubectl plugin resolution for non-shadowing subcommands KEP-3638: Improve kubectl plugin resolution for non-shadowing subcommands Sep 14, 2023
@ardaguclu ardaguclu changed the title KEP-3638: Improve kubectl plugin resolution for non-shadowing subcommands Improve kubectl plugin resolution for non-shadowing subcommands Sep 14, 2023
@soltysh
Copy link
Contributor

soltysh commented Sep 18, 2023

/stage beta
/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Sep 18, 2023
@salehsedghpour
Copy link
Contributor

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Ensure that the PR and PRR is merged to k/enhancements

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@salehsedghpour
Copy link
Contributor

Hi @ardaguclu , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like #4209 will address all of the requirements.

Let me know if I missed anything. Thanks!

@salehsedghpour
Copy link
Contributor

As #4209 is merged now, the status of this enhancement can marked as tracked for enhancement freeze.

@Princesso
Copy link

Hey there @ardaguclu ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@Princesso
Copy link

Hi @ardaguclu ! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@Princesso
Copy link

Hi @salehsedghpour ! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@ardaguclu
Copy link
Member Author

Hi @Princesso. For this beta stage, there will be no website changes required.

@Princesso
Copy link

Princesso commented Oct 19, 2023

Hi @ardaguclu , thanks for responding. How about docs changes?

@ardaguclu
Copy link
Member Author

There won't be any doc changes with respect to this feature in beta

@salehsedghpour
Copy link
Contributor

Hey again @ardaguclu 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

With this, the status of this KEP is now at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @ardaguclu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@salehsedghpour
Copy link
Contributor

Hi @ardaguclu ,
As the following PR is now merged the status of this PR can now be marked with tracked for the code freeze.
kubernetes/kubernetes#120663

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked for Code Freeze
Status: Needs Triage
Development

No branches or pull requests

10 participants