Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support paged LIST queries from the Kubernetes API #365

Closed
smarterclayton opened this issue Jul 27, 2017 · 85 comments · Fixed by #4463
Closed

Support paged LIST queries from the Kubernetes API #365

smarterclayton opened this issue Jul 27, 2017 · 85 comments · Fixed by #4463
Assignees
@smarterclayton @wojtek-t
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 27, 2017 •
edited by wojtek-t

Feature Description

  • One-line feature description (can be used as a release note): Allow API consumers - especially those that must retrieve large sets of data - to retrieve results in pages so as to reduce the memory and size impact of those very large queries.
  • Primary contact (assignee): @smarterclayton
  • Responsible SIGs: sig-api-machinery, sig-scalability
  • Design proposal link (community repo): Design for consistent API chunking in Kubernetes community#896
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: deads2k lavalamp
  • Approver (likely from SIG/area to which feature belongs): lavalamp
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.8)
    • Beta release target (1.9)
    • Stable release target (1.29)
@smarterclayton smarterclayton added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 27, 2017
@dixudx
Copy link
Member

dixudx commented Jul 28, 2017

/cc

@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Aug 3, 2017
@idvoretskyi idvoretskyi added this to the 1.8 milestone Aug 3, 2017
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Aug 3, 2017 •
edited

This work is part of the SLO improvements we have for kubernetes - helping us meet the requirements of much denser clusters. The key goal for alpha is to prove that it will help us reach the next scale limit for Kubernetes, and will take work across several releases to get there.

@smarterclayton smarterclayton mentioned this issue Aug 11, 2017
Merged
@smarterclayton smarterclayton added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Aug 11, 2017
k8s-github-robot pushed a commit to kubernetes/community that referenced this issue Aug 29, 2017
Merge pull request #896 from smarterclayton/list
1886e7a 
Automatic merge from submit-queue

Design for consistent API chunking in Kubernetes

In order to reduce the memory allocation impact of very large LIST operations against the Kubernetes apiserver, it should be possible to receive a single large resource list as many individual page requests to the server.

Part of kubernetes/enhancements#365. Taken from kubernetes/kubernetes#49338. Original discussion in kubernetes/kubernetes#2349
@idvoretskyi
Copy link
Member

@smarterclayton @kubernetes/sig-api-machinery-feature-requests @kubernetes/sig-scalability-feature-requests can you confirm that this feature targets 1.8?

If yes, please, update the features tracking spreadsheet with the feature data, otherwise, let's remove this item from 1.8 milestone.

Thanks

@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 14, 2017
@smarterclayton
Copy link
Contributor Author

Yes, it was delivered for 1.8.

@smarterclayton
Copy link
Contributor Author

Beta for 1.9

@smarterclayton smarterclayton removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 10, 2017
@smarterclayton smarterclayton modified the milestones: 1.8, 1.9 Oct 10, 2017
@smarterclayton
Copy link
Contributor Author

Goals for 1.9 - expose in CLI for get.go
Goals for 1.10 - expose for all CLI commands, GA

@zacharysarah
Copy link
Contributor

zacharysarah commented Nov 22, 2017 •
edited

@smarterclayton 👋 Please open a documentation PR and add a link to the 1.9 tracking spreadsheet. Thanks in advance!

@zacharysarah
Copy link
Contributor

@smarterclayton Bump for docs ☝️

/cc @idvoretskyi

@zacharysarah zacharysarah mentioned this issue Nov 30, 2017
Closed
@idvoretskyi
Copy link
Member

@smarterclayton @kubernetes/sig-api-machinery-feature-requests @kubernetes/sig-scalability-feature-requests any updates on the docs status?

A friendly reminder on docs deadline tomorrow.

/cc @zacharysarah

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 30, 2017
@smarterclayton smarterclayton mentioned this issue Dec 2, 2017
Merged
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 2, 2017 via email

@cben cben mentioned this issue Jan 10, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2018
@smarterclayton smarterclayton added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Mar 8, 2018
@wojtek-t wojtek-t added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Aug 31, 2023
@wojtek-t wojtek-t mentioned this issue Aug 31, 2023
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Sep 4, 2023

/label lead-opted-in

@wojtek-t
Copy link
Member

wojtek-t commented Sep 4, 2023

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 4, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Sep 4, 2023

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 4, 2023
@npolshakova
Copy link

npolshakova commented Sep 22, 2023 •
edited

Hello @wojtek-t 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • If there are code changes going into 1.29, keep the status as implementable until the after the code PRs are merged in and feature gates are removed. Let me know if you have any questions!

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@wojtek-t wojtek-t mentioned this issue Sep 22, 2023
Merged
@wojtek-t
Copy link
Member

@npolshakova - fixed in #4235 - PTAL

@zacharysarah
Copy link
Contributor

1.9, July 2017?! Lordy.

84-years

@npolshakova
Copy link

@npolshakova - fixed in #4235 - PTAL

Thanks! With the addressed, this enhancement is now Tracked for Enhancement Freeze 🚀

@taniaduggal
Copy link

Hey there @smarterclayton 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@taniaduggal
Copy link

Hey there @smarterclayton , The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@wojtek-t
Copy link
Member

@taniaduggal - documentation PR has already been merged: kubernetes/website#42800

@wojtek-t wojtek-t mentioned this issue Oct 20, 2023
Merged
@npolshakova
Copy link

npolshakova commented Oct 23, 2023 •
edited

Hey again @wojtek-t 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Please make sure to update the issue description with the correct milestone and link the KEP pr in the description as well.

This KEP is currently marked as at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@wojtek-t
Copy link
Member

The main PR is: kubernetes/kubernetes#119503 and it was already linked to this issue above...

We're code complete for this release now.

@npolshakova
Copy link

The main PR is: kubernetes/kubernetes#119503 and it was already linked to this issue above...

We're code complete for this release now.

Thanks! Can you update the issue description as well for tracking purposes? It looks a little out of date right now:

Feature target (which target equals to which milestone):

    Alpha release target (1.8)
    Beta release target (1.9)
    Stable release target ()

@wojtek-t
Copy link
Member

done

@a-mccarthy
Copy link

Hi @wojtek-t, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@npolshakova
Copy link

done

Thanks @wojtek-t! Can the issue description be updated as well if you get a chance?

Feature target (which target equals to which milestone):

    Alpha release target (1.8)
    Beta release target (1.9)
    Stable release target (1.29):
        KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4235
        Code (k/k) update PR(s):  https://github.com/kubernetes/kubernetes/pull/119503

@npolshakova
Copy link

Hello @wojtek-t 👋, 1.29 Enhancements team here.

With kubernetes/kubernetes#119503 merged, all the implementation(code related) PRs are now merged and this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

Just a reminder, the test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all (if any) test PRs are merged in by then. Please let me know if there are any test PRs we should track. Thanks!

@salehsedghpour
Copy link
Contributor

Hi @wojtek-t, 👋 1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
A kind reminder, as it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@wojtek-t wojtek-t mentioned this issue Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarterclayton smarterclayton

@wojtek-t wojtek-t

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
1.29 Enhancements Tracking
Status: Tracked for Code Freeze
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark pagination KEP as implemented wojtek-t/enhancements