New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubelet limit of Parallel Image Pulls #3673
Comments
/sig node |
Some intial ideas can be found in https://docs.google.com/document/d/1MMZlKSxkDBDz0kEn9JGm848_IJgydJqXWz5t9D3Ev8I/edit# and kubernetes/kubernetes#112242 kubernetes/kubernetes#112044 |
/lead opted-in |
/label lead-opted-in |
Hello @pacoxu & @ruiwen-zhao 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this enhancement, it looks like #3713 will address most of these requirements.
The status of this enhancement is marked as |
Updated the KEP PR #3713 to change the status to implemnetable. Once it is merged then all of the requirements will be addressed. |
Thanks @ruiwen-zhao - this enhancement is ready to be |
/assign @pacoxu @ruiwen-zhao |
Draft document update: kubernetes/website#39732 |
Hi @ruiwen-zhao @pacoxu 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release. Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. Please feel free to reach out with any questions. Thanks! |
Is kubernetes/website#39732 sufficient for now? |
Hi @ruiwen-zhao @pacoxu 👋, Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023. Please ensure the following items are completed:
Please let me know if there are any other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks! |
Hi @marosset The PR is kubernetes/kubernetes#115220, which has been merged already. Thanks! |
this will be progressing to beta in 1.28 as per the sig node meeting 5/2/2023 /milestone v1.28 |
I opened kubernetes/kubernetes#121604. I still need some more test. |
@pacoxu , I just doubled check this case. If the PR includes any net-new changes, in your case kubernetes/kubernetes#120229, it needs to be merged by the code freeze date even if it includes some tests. But if there is a PR that that basically just cover some tests, it can be merged by the Test Freeze. So regarding this KEP, I'm checking kubernetes/kubernetes#120229 this PR. Is this the wrong PR that I'm looking in? And is there any other PR in k/k that I'm missing. I would appreciate it if you can update the issue description with all related PRs. |
Hello @pacoxu 👋 1.29 Enhancements lead here, Unfortunately, the implementation (code related) PR (kubernetes/kubernetes#120229 ) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone. If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks! /milestone clear |
BTW, this issue description doesn't yet link to the actual KEP text. |
/remove-label lead-opted-in |
/stage beta |
Hello @pacoxu and @ruiwen-zhao , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks! |
Yep I think #4452 will address everything. I will chase for approvals. Thanks! |
/label lead-opted-in |
Hello @ruiwen-zhao @pacoxu 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
Sent #4494 to answer the question. |
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀 |
Hello @ruiwen-zhao, @pacoxu , 👋 1.30 Docs Shadow here. |
Hi @ruiwen-zhao , 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
There is an existing doc already. I think the only thing we need to do is to change it to Beta once we are ready. |
@pacoxu already wrote a blog about this feature when it launched in Alpha: https://kubernetes.io/blog/2023/05/15/speed-up-pod-startup/#maximum-parallel-image-pulls-will-help-secure-your-node-from-overloading-on-image-pulling. I don't really think we need another one, unless @pacoxu maybe has different ideas? |
@ruiwen-zhao +1 we may not have a new blog in this release cycle for this feature. |
Thanks for your response @ruiwen-zhao @pacoxu |
Hi @mrunalp , @ruiwen-zhao thanks for your response. Could you please point me in the direction of the docs that exist already? Thank you! |
There is a blog here: https://kubernetes.io/blog/2023/05/15/speed-up-pod-startup/#maximum-parallel-image-pulls-will-help-secure-your-node-from-overloading-on-image-pulling And doc about this feature here: https://kubernetes.io/docs/concepts/containers/images/#maximum-parallel-image-pulls, and |
Hey again @ruiwen-zhao @pacoxu 👋 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP): Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hello @ruiwen-zhao @pacoxu 👋 Enhancements team here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the If you still wish to progress this enhancement in /milestone clear |
Enhancement Description
One-line enhancement description (can be used as a release note): Add a node-level limit to kubelet to limit the number of parallel image pulls
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3673-kubelet-parallel-image-pull-limit/README.md
Discussion Link:
Primary contact (assignee): @pacoxu @ruiwen-zhao
Responsible SIGs: SIG Node
Enhancement target (which target equals to which milestone):
Alpha
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Beta
k/enhancements
) update PR(s):k/k
) update PR(s): [node-e2e] add test cases for serialize and parallel image pulling kubernetes#121604k/website
) update(s):Promote parallel image pulls to beta website#42061 merged in v1.28, and reverted).Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: