Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EndpointSlice Reconciler into Staging #3685

Closed
5 tasks done
akhilles opened this issue Dec 12, 2022 · 18 comments
Closed
5 tasks done

Move EndpointSlice Reconciler into Staging #3685

akhilles opened this issue Dec 12, 2022 · 18 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@akhilles
Copy link
Contributor

akhilles commented Dec 12, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 12, 2022
@akhilles
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2022
@thockin thockin moved this from New, not evaluated to Evaluated, not committed (undecided whether we want to do this or not) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jan 5, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2023
@akhilles
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 14, 2023
@thockin
Copy link
Member

thockin commented Jun 7, 2023

Is this making progress? I need to decide if it is in or our for 1.28

@robscott robscott mentioned this issue Jun 8, 2023
4 tasks
@thockin
Copy link
Member

thockin commented Jun 8, 2023

At this point I am assuming it is NOT in for 28

@robscott
Copy link
Member

robscott commented Jun 9, 2023

@thockin The only thing we were missing for v1.28 was to mark this as implementable, @mskrocki is doing that with #4075 if you have time to approve.

@thockin thockin moved this from Evaluated, not committed (undecided whether we want to do this or not) to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jun 9, 2023
@thockin thockin self-assigned this Jun 9, 2023
@thockin thockin added this to the v1.28 milestone Jun 9, 2023
@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 9, 2023
@Atharva-Shinde
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 10, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jun 11, 2023

Hello @akhilles @robscott 👋, Enhancements Lead here.

Question:
Looking at kep.yaml I see that this KEP moved to alpha on 1.19, beta on 1.20 and stable on 1.22 but on this issue I don't see any outreach from the release team/ enhancements team, why so? Also this KEP hasn't addressed PRR Questionnaire or any tests in Test Plan Section. So is this an out-of-tree enhancement?

@Atharva-Shinde
Copy link
Contributor

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@robscott
Copy link
Member

robscott commented Jun 12, 2023

Hey @Atharva-Shinde I think there's some confusion here. This is just moving some code to a different package, so there's no effect on production readiness, testing, etc. There's also no way to feature gate it or split it into separate releases. In this case we're just trying to go through a lightweight KEP process to show that there's high level approval for the change (moving key EndpointSlice controller code so it can easily be imported by others). @mskrocki has filed a PR to update the KEP for this cycle: #4075. If we're missing anything that's needed for such a lightweight/single-cycle GEP, please let us know.

@Atharva-Shinde
Copy link
Contributor

Thanks @robscott for the information. It looks like this enhancement is then ready for the upcoming Enhancements freeze🚀

Changing the status of this enhancement now to tracked!

@robscott
Copy link
Member

Thanks @Atharva-Shinde!

@taniaduggal
Copy link

Hello @akhilles 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@akhilles
Copy link
Contributor Author

Hi @taniaduggal, there's no docs work needed for this as it's just a refactoring of the code base.

@Atharva-Shinde
Copy link
Contributor

Hey again @akhilles 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

This is the code related PR that I found on this KEP issue:

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @akhilles 👋 Enhancements Lead here,
With kubernetes/kubernetes#118953 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@akhilles
Copy link
Contributor Author

I think this can be closed? This was more of an informational KEP, and all the relevant changes have been merged. Please re-open if there are any outstanding tasks.

@aojea aojea moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to DONE (GA, merged, gate removed) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Aug 16, 2023
@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked
Obsolete: SIG-Network KEPs (see https...
DONE (GA, merged, gate removed)
Development

No branches or pull requests

8 participants