Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Indexed Jobs #3715

Open
4 tasks done
ahg-g opened this issue Jan 9, 2023 · 23 comments
Open
4 tasks done

Elastic Indexed Jobs #3715

ahg-g opened this issue Jan 9, 2023 · 23 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status wg/batch Categorizes an issue or PR as relevant to WG Batch.

Comments

@ahg-g
Copy link
Member

ahg-g commented Jan 9, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 9, 2023
@sftim
Copy link
Contributor

sftim commented Jan 10, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 10, 2023
@sftim
Copy link
Contributor

sftim commented Jan 10, 2023

/wg batch

@k8s-ci-robot k8s-ci-robot added the wg/batch Categorizes an issue or PR as relevant to WG Batch. label Jan 10, 2023
@ahg-g
Copy link
Member Author

ahg-g commented Jan 11, 2023

/assign

@ahg-g ahg-g changed the title Indexed Jobs with unset completions parameter Elastic Indexed Jobs Jan 20, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2023

/stage alpha
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 20, 2023
@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Jan 31, 2023

Hello @ahg-g 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27

There is a slight confusion here, the KEP states that this enhancement is targeting beta but it appears that there was no alpha stage in the first place to graduate to beta, and the lead has opted in for alpha.
So is this enhancement targeting alpha or beta?
Please take a look and I'll update the stage of this KEP accordingly.

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ahg-g
Copy link
Member Author

ahg-g commented Jan 31, 2023

@Atharva-Shinde can you point to what is missing from the test plan section? Note that the KEP is proposing to graduate to beta right away, so we don't have the integration and e2e tests yet.

@Atharva-Shinde
Copy link
Contributor

Note that the KEP is proposing to graduate to beta right away, so we don't have the integration and e2e tests yet.

ack.
I've updated my comment. You don't need to update your test plan :)

@Atharva-Shinde
Copy link
Contributor

@ahg-g, With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@LukeMwila
Copy link

Hi @ahg-g, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey again @ahg-g 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@ahg-g
Copy link
Member Author

ahg-g commented Mar 12, 2023

Hi @Atharva-Shinde, yes all relevant PRs are merged, I updated the description.

@marosset
Copy link
Contributor

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Mar 20, 2023
@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2023
@ahg-g
Copy link
Member Author

ahg-g commented Jan 17, 2024

@soltysh we will try to graduate this to GA in this release.

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 17, 2024
@ahg-g
Copy link
Member Author

ahg-g commented Jan 17, 2024

/assign @danielvegamyhre

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 17, 2024
@ahg-g
Copy link
Member Author

ahg-g commented Jan 17, 2024

/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 17, 2024
@atiratree
Copy link
Member

atiratree commented Jan 24, 2024

The newly proposed successPolicy changes the meaning of completions. That is we run number of pods according to completions, but we might mark the job as Complete/Succeeded earlier, before all the pods have finished (can also result in the pods to be discarded prematurely).

This might not affect Elastic Indexed Jobs feature, but there might be new cross-field validations (completions, successPolicy, indexes). And possible issues might come to light when implementing/testing the new feature with regards to mutable completions field.

I think it might be better to wait with graduating this feature to stable until we have a clearer picture.

What is your opinion on this? @ahg-g @danielvegamyhre @soltysh

@ahg-g
Copy link
Member Author

ahg-g commented Jan 26, 2024

I am good with that, please feel free to remove it from the milestone.

@danielvegamyhre
Copy link
Member

That makes sense, thanks for bringing this up.

@soltysh
Copy link
Contributor

soltysh commented Jan 26, 2024

What is your opinion on this? @ahg-g @danielvegamyhre @soltysh

That's a good suggestion, thx Filip for catching this.
/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Jan 26, 2024
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 26, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 26, 2024

@salehsedghpour fyi: this is being removed from 1.30

@soltysh
Copy link
Contributor

soltysh commented Jan 26, 2024

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Jan 26, 2024
@AnaMMedina21
Copy link

Hello @ahg-g 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

Just want to confirm that this work has been postponed. The status of this enhancement is marked as Removed from Milestone for v1.30 release. (correct me, if otherwise)

@salehsedghpour
Copy link
Contributor

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
Status: Tracked
Status: Removed from Milestone
Status: Needs Triage
Development

No branches or pull requests