Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stay on supported Go versions #3744

Open
6 of 9 tasks
liggitt opened this issue Jan 17, 2023 · 20 comments
Open
6 of 9 tasks

Stay on supported Go versions #3744

liggitt opened this issue Jan 17, 2023 · 20 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@liggitt
Copy link
Member

liggitt commented Jan 17, 2023

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 17, 2023
@liggitt
Copy link
Member Author

liggitt commented Jan 17, 2023

/sig release architecture

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2023
@liggitt
Copy link
Member Author

liggitt commented Jan 17, 2023

/assign

@jeremyrickard
Copy link
Contributor

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 2, 2023
@jeremyrickard jeremyrickard added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@jeremyrickard
Copy link
Contributor

/stage stable

@fsmunoz
Copy link

fsmunoz commented Feb 4, 2023

Hello @liggitt 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@liggitt
Copy link
Member Author

liggitt commented Feb 4, 2023

The linked PR has lgtm/approve from sig approvers, shadow PRR is complete and it's waiting for an ack from @johnbelamaric.

  • there is a missing topic in the PRR Scalability about resource exhaustion

This KEP is a process KEP, so the answer to almost every PRR question is "no" or "n/a", but sure, I pushed an update to add the new question.

As an aside, I copied the KEP template on January 17th... it looks like the template was modified to add that question about a week ago in #3783. It's very frustrating to make the questions that need answering a moving target a handful of days before enhancements freeze. @wojtek-t, would it be possible for PRR to batch updates to the KEP template by the .0 release, to avoid churn for folks working on KEPs for the upcoming release (and avoid churn for release folks checking bookkeeping for every KEP for the upcoming release)?

@fsmunoz
Copy link

fsmunoz commented Feb 5, 2023

@liggitt I missed that question as well, to be honest, so I was also caught off-guard since the KEPs I was reviewing seemed to be up-to-date, this is why I explicitly mentioned that question, it was indeed not present even if KEPs that were done very recently :( Thank you for adding that question, that covers everything once #3749 is merged (but I will take another look then).

@liggitt
Copy link
Member Author

liggitt commented Feb 6, 2023

@fsmunoz - #3749 is merged, can you confirm this meets requirements to be tracked for 1.27?

@fsmunoz
Copy link

fsmunoz commented Feb 7, 2023

Hi @liggitt , thank you for your work on this.

Here's where this enhancement currently stands (and this is for stable, it was erroneously described as alpha before);

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

This being a process enhancement, I'm assuming (with the information I have right now) that the graduation and PRR are perfectly adequate as-is, since this is either done or not done. With that, I'm marking this as meeting all the requirements to be tracked for v1.27.

Thanks!

/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot
Copy link
Contributor

@fsmunoz: Those labels are not set on the issue: tracked/no

In response to this:

Hi @liggitt , thank you for your work on this.

Here's where this enhancement currently stands (and this is for stable, it was erroneously described as alpha before);

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

This being a process enhancement, I'm assuming (with the information I have right now) that the graduation and PRR are perfectly adequate as-is, since this is either done or not done. With that, I'm marking this as meeting all the requirements to be tracked for v1.27.

Thanks!

/label tracked/yes
/remove-label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 7, 2023
@cpanato
Copy link
Member

cpanato commented Feb 18, 2023

/approve

@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

Hi @liggitt 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like all linked PRs are merged; there are however two additional tasks in the Code sections, but without associated PRs - if they have PRs and they are not merged, then this status is not up-to-date and conditions for code freeze might be missing.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@liggitt
Copy link
Member Author

liggitt commented Mar 13, 2023

there are no code changes for k/k remaining, the rest of the work is around release process docs and project policy docs

@liggitt
Copy link
Member Author

liggitt commented Mar 13, 2023

I updated the description to make that clearer

@liggitt
Copy link
Member Author

liggitt commented Mar 20, 2023

@marosset can you modify the milestone in the 1.27 tracking project to stable for this process change?

@marosset
Copy link
Contributor

@marosset can you modify the milestone in the 1.27 tracking project to stable for this process change?

done!

@mickeyboxell
Copy link

@liggitt was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@liggitt
Copy link
Member Author

liggitt commented Mar 21, 2023

As mentioned in #3744 (comment), this is a policy KEP not tied to the v1.27.0 release. The remaining docs are to release handbooks and policy docs. I'm working on those but they are detached from the release cut, so I wouldn't expect them to be against the website repo or the dev-1.27 branch

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/release Categorizes an issue or PR as relevant to SIG Release. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Development

No branches or pull requests

9 participants