Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP: Referential Authorization #3766

Open
8 tasks
robscott opened this issue Jan 20, 2023 · 17 comments
Open
8 tasks

KEP: Referential Authorization #3766

robscott opened this issue Jan 20, 2023 · 17 comments
Assignees
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@robscott
Copy link
Member

robscott commented Jan 20, 2023

Enhancement Description

  • One-line enhancement description (can be used as a release note): Move ReferenceGrant to new sig-auth API Group
  • Kubernetes Enhancement Proposal: KEP-3766: Move ReferenceGrant to sig-auth API Group #3767
  • Discussion Link: https://groups.google.com/g/kubernetes-sig-auth/c/akUOI3gea0c
  • Primary contact (assignee): @robscott
  • Responsible SIGs: sig-auth, closely related to sig-network and sig-storage
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.30
    • Stable release target (x.y):
  • Beta
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update(s):
  • Stable
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update(s):
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 20, 2023
@robscott
Copy link
Member Author

/sig auth
/sig network
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2023
@robscott
Copy link
Member Author

/assign @youngnick

@enj enj added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2023
@enj enj added this to the v1.27 milestone Jan 23, 2023
@sftim
Copy link
Contributor

sftim commented Jan 24, 2023

Would folks be willing to retitle this KEP? Although the change we want to bring about is a move of API group, the desired state is that there is a ReferenceGrant API available for multiple consumers and with review by SIG Architecture.

I'd like to capture that desired outcome, which will become visible to end users (eg: in release notes, other release-related comms), in the KEP title.

@youngnick
Copy link
Contributor

That seems reasonable to me, something like "Create in-tree ReferenceGrant resource for allowing cross-namespace references"? ("in-tree" is doing a lot of heavy lifting there.)

@sftim
Copy link
Contributor

sftim commented Jan 24, 2023

That's also changing the intent. I originally thought this KEP was about updating the existing CRD to be one that SIG Auth would own.

Let's be clear on which we want, so that our end users are also not confused!

@fsmunoz
Copy link

fsmunoz commented Feb 1, 2023

Hello @robscott 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

  • Update to the latest KEP template. Specifically, there is an additional question in the Scalability section of the PRR.
  • Update kep.yaml to reflect current stage information. This assumes that the description in the issue that states that the v1.27 is for beta is correct, and that the kep.yaml information that v1.27 is for alpha is not - if the opposite is true then no change would be needed in the file.
  • Fix formatting in the Graduation Criteria section.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jeremyrickard
Copy link
Contributor

@fsmunoz I don't believe this has had a PRR review.

@johnbelamaric
Copy link
Member

Yes, it is merged right now as provisional, so the PRR tooling doesn't kick in - Rob & I discussed this. Before it moves to implementable it needs PRR. @robscott this needs to move to implementable ASAP if you want to make the release!

@robscott
Copy link
Member Author

robscott commented Feb 8, 2023

@johnbelamaric filed a PR earlier that would make that change, but still needs some more reviews + approvals: #3832

@fsmunoz
Copy link

fsmunoz commented Feb 8, 2023

@johnbelamaric thank you, I was going from the content of the KEP PRR section. Until it's marked as implementable though it's not going to be tracked.

@robscott
Copy link
Member Author

robscott commented Feb 9, 2023

As much as I'd love to get this in to the 1.27 cycle, I think everyone that could review/approve is pretty underwater this cycle and we likely need some rounds of review + revision on this KEP still. In light of that, we should probably formally punt this to the 1.28 cycle.

@fsmunoz
Copy link

fsmunoz commented Feb 10, 2023

@robscott I'm marking this as Deferred, should this change in the next hours place comment and we'll try to review it. Thanks!

@enj enj removed the lead-opted-in Denotes that an issue has been opted in to a release label Mar 13, 2023
@enj
Copy link
Member

enj commented Mar 13, 2023

/milestone clear

@robscott
Copy link
Member Author

robscott commented Jan 3, 2024

Some quick updates on this KEP.

  1. We've met at the previous 2 KubeCons with some sig-auth leads to discuss a path forward, resulting in this updated proposal
  2. I've translated that proposal into a rough proof of concept here: https://github.com/robscott/referencegrant-poc

@robscott robscott changed the title Move ReferenceGrant to new sig-auth API Group KEP: Referential Authorization Jan 6, 2024
@enj enj added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 17, 2024
@mickeyboxell
Copy link

Hello @robscott @deads2k @youngnick 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

For this KEP, we would just need to update the following:

  • The latest-milestone and stage should be updated to 1.30 in the kep.yaml file.
  • The production readiness review should be completed and updated with the information for the targeting stage alpha.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@enj
Copy link
Member

enj commented Feb 5, 2024

Per the slack thread conversation, I am moving this KEP out of the v1.30 release.

@enj enj removed this from the v1.30 milestone Feb 5, 2024
@enj enj removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
Status: Deferred
Status: Removed from Milestone
Status: In Review
Development

No branches or pull requests