Skip to content

Mutating Admission Policies #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 of 10 tasks
jpbetz opened this issue Apr 24, 2023 · 35 comments
Open
6 of 10 tasks

Mutating Admission Policies #3962

jpbetz opened this issue Apr 24, 2023 · 35 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Apr 24, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 24, 2023
@jpbetz jpbetz changed the title KEP: Mutating Admission Policies Mutating Admission Policies Apr 24, 2023
@kannon92
Copy link
Contributor

kannon92 commented May 2, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2023
@cici37 cici37 self-assigned this Jan 11, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 23, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2024
@mickeyboxell
Copy link

mickeyboxell commented Jan 31, 2024

Hello @jpbetz @cici37 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on [02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca):.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

I saw the comment here that a replacement KEP will be opened: #3963 (comment). Please link the new KEP as soon as it is available so we can properly assess whether it is ready for inclusion in the v1.30 release.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Sorry, something went wrong.

@mickeyboxell mickeyboxell moved this to At Risk for Enhancements Freeze in 1.30 Enhancements Tracking Jan 31, 2024
@mickeyboxell
Copy link

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@mickeyboxell mickeyboxell moved this from At Risk for Enhancements Freeze to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 8, 2024
@celestehorgan
Copy link

Hello @jpbetz 👋, 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

====

(non copy-pasted note: I'm pretty sure this requires docs! As it's an addition of a new alpha feature please remember to mark any docs you do write as alpha for version 1.30!

@kcmartin
Copy link

Hi @jpbetz, @cici37,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@mickeyboxell
Copy link

mickeyboxell commented Feb 22, 2024

Hey again @jpbetz @cici37 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

Sorry, something went wrong.

@mickeyboxell mickeyboxell moved this from Tracked for Enhancements Freeze to At Risk for Code Freeze in 1.30 Enhancements Tracking Feb 22, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 29, 2024

After discussing with @cici37 @deads2k @fedebongio @alexzielenski, we'd like to re-target this enhancement for v1.31 milestone.

We weighed the benefits of merging the first alpha in this release against the risks-- less than a week remaining till code freeze, high reviewer workloads and overall size of this enhancement. The quality of work so far is amazing, so part of our goal is to avoid "crunch" and the risks it entails.

We feel it is best overall to take some extra time and merge this with a high level of quality and confidence in 1.31. We will continue to prioritize API and implementation review. Once the implementation PR is ready, we will hold it until the code thaws for 1.31 and then merge, hopefully early in the cycle.

@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 29, 2024

/milestone v1.31

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 10, 2024

@shecodesmagic I've merged #4917 to address the needed KEP updates. PTAL, thanks!

@shecodesmagic
Copy link

Thanks @jpbetz,

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.32. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

Could you also update the Release Signoff Checklist in the README.md: https://github.com/jpbetz/enhancements/blob/7e5a064f6cf071d77340fb81b4c11759fa276d20/keps/sig-api-machinery/3962-mutating-admission-policies/README.md#release-signoff-checklist

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Sorry, something went wrong.

@shecodesmagic shecodesmagic moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.32 Enhancements Tracking Oct 10, 2024
@pacoxu
Copy link
Member

pacoxu commented Oct 12, 2024

Is the label tracked/no here synced? The KEP was merged for v1.32.

@edithturn
Copy link

Hello @jpbetz, 👋🏼 this is Edith from the v1.32 Communications Team!

We’d love for you to consider writing a feature blog about your enhancement! ✍
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@AnshumanTripathi
Copy link

Hello @jpbetz 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@AnshumanTripathi
Copy link

Hi @jpbetz 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is Thursday Oct 24 at 18:00 PDT.

Thanks,

Anshuman

@edithturn
Copy link

edithturn commented Oct 28, 2024

Hello @jpbetz! 🙂

This is a reminder to author your feature blog post!

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Thank you very much!
Edith from the v1.32 Shadow Communications Team

@shecodesmagic
Copy link

shecodesmagic commented Oct 29, 2024

Hey @jpbetz 👋, v1.32 Enhancements team here again (😁)

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here’s where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP if missing):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

Sorry, something went wrong.

@shecodesmagic shecodesmagic moved this from Tracked for enhancements freeze to Tracked for code freeze in 1.32 Enhancements Tracking Oct 29, 2024
@shecodesmagic shecodesmagic moved this from Tracked for code freeze to At risk for code freeze in 1.32 Enhancements Tracking Oct 29, 2024
@dipesh-rawat
Copy link
Member

Hello @jpbetz 👋, v1.32 Enhancements team here

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.32 Enhancements Tracking Nov 8, 2024
@tengqm
Copy link

tengqm commented Nov 8, 2024

So .... this feature MutatingAdmissionPolicy enters Alpha from 1.32 rather than 1.30, right? We need to update the website for this if so.

@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 8, 2024

So .... this feature MutatingAdmissionPolicy enters Alpha from 1.32 rather than 1.30, right? We need to update the website for this if so.

Correct. We'll update it

@dipesh-rawat
Copy link
Member

Hello 👋, 1.33 Enhancements Lead here.

I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Jan 12, 2025
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
@dipesh-rawat dipesh-rawat removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jan 12, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2025
@cici37
Copy link
Contributor

cici37 commented Apr 16, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Deferred
Status: Removed from Milestone
Status: Tracked for code freeze
Development

No branches or pull requests