Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Terminating Pods in Deployments #3973

Open
1 of 4 tasks
kannon92 opened this issue May 1, 2023 · 22 comments
Open
1 of 4 tasks

Consider Terminating Pods in Deployments #3973

kannon92 opened this issue May 1, 2023 · 22 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@kannon92
Copy link
Contributor

kannon92 commented May 1, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 1, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented May 2, 2023

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2023
@atiratree
Copy link
Member

@kannon92 can you please link a correct KEP in the description?

@dejanzele
Copy link
Contributor

As discussed with @kannon92, I will be taking over this KEP.

/assign dejanzele

@atiratree
Copy link
Member

@dejanzele I had a similar discussion with @kannon92 some time ago about this as well. And I have the KEP mostly written, just need to finish it..

@atiratree
Copy link
Member

@kannon92 @dejanzele I have opened the new version of the KEP in #4357.

@kannon92
Copy link
Contributor Author

/assign @atiratree

@atiratree
Copy link
Member

/label lead-opted-in
/milestone v1.30
/stage alpha

@k8s-ci-robot
Copy link
Contributor

@atiratree: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

@atiratree: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor

soltysh commented Jan 23, 2024

/label lead-opted-in
/milestone v1.30
/stage alpha

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2024
@meganwolf0
Copy link

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The KEP and PRR look good in the Pull Request, this is just a reminder to make sure they're all merged before enhancements freeze

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@meganwolf0
Copy link

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

@salehsedghpour
Copy link
Contributor

With all the requirements fulfilled in #4357 this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@celestehorgan
Copy link

Hello @kannon92 👋, 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@natalisucks
Copy link

Hi @atiratree and @dejanzele,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@atiratree
Copy link
Member

hi, I have opened placeholder PRs:

@meganwolf0
Copy link

Hey again @atiratree 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@atiratree
Copy link
Member

atiratree commented Mar 4, 2024

I have updated the kubernetes/kubernetes#123430 PR with an implementation, but I am still missing the tests, so we will not be able to merge this feature in 1.30 due to not enough time.

Even though it might be possible to finish this if we had enough review capacity, I would prefer not to for the following reasons:

  • to allow proper review process to make sure we have not looked over something
  • I have identified that we will need a new annotation deployment.kubernetes.io/replicaset-replicas-before-scale (please see ignore replicaset-replicas-before-scale annotation in deployment rollbacks kubernetes#123670) to support partial scalling of older revision replica sets for deployments with TerminationComplete podReplacementPolicy. It would be great if we could merge this now, to make sure N-1 kubectl works with cluster that turn on the DeploymentPodReplacementPolicy feature.

@meganwolf0
Copy link

Thank you @atiratree - In this case I will mark this enhancement Removed from Milestone

@kannon92
Copy link
Contributor Author

kannon92 commented Mar 4, 2024

updated links.

@atiratree
Copy link
Member

In today's sig-apps call, we have decided to postpone the introduction of the annotation into 1.31 along with the alpha version of the feature. We will specifically document in the KEP/docs that this feature should be used with the latest kubectl. In the next release (1.32), the rollbacks should be backwards compatible.

@salehsedghpour
Copy link
Contributor

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Status: Needs Triage
Development

No branches or pull requests

9 participants