Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a drop-in kubelet configuration directory #3983

Open
6 of 8 tasks
haircommander opened this issue May 4, 2023 · 52 comments
Open
6 of 8 tasks

Add support for a drop-in kubelet configuration directory #3983

haircommander opened this issue May 4, 2023 · 52 comments
Assignees
@sohankunkerkar
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone
v1.30

Comments

@haircommander
Copy link
Contributor

haircommander commented May 4, 2023 •
edited

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 4, 2023
@haircommander
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.28

Adding to the milestone for tracking based on discussions at sig node meeting.

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 5, 2023
@ffromani
Copy link
Contributor

ffromani commented May 9, 2023

+1!!! (non binding)
@haircommander I'd love to help here to get this in kubelet

@yuqi-zhang yuqi-zhang mentioned this issue May 24, 2023
Merged
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 6, 2023
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 8, 2023
@ruheenaansari34
Copy link

Hello @haircommander 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to take care of:

  • Merging KEP update PR
  • The KEP number seems to be incorrect ie., should this be 3983 instead of 3893?

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuqi-zhang
Copy link
Contributor

Hi @ruheenaansari34 , I've updated the ID, thanks for pointing that out!

Is there anything else needed at the moment other than getting consensus to merge the enhancement?

@ruheenaansari34
Copy link

@yuqi-zhang Please take care of the following before the Enhancement freeze to meet the requirements:

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuqi-zhang
Copy link
Contributor

Thanks! I've marked it as implementable after discussion with @haircommander . We will work to get it merged

@Atharva-Shinde
Copy link
Contributor

Thanks @yuqi-zhang :)
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀.
The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

@Rishit-dagli
Copy link
Member

Hello @haircommander 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @haircommander , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@haircommander
Copy link
Contributor Author

yes I will take care of it, thanks @Rishit-dagli !

@haircommander
Copy link
Contributor Author

done! kubernetes/website#42013

@ruheenaansari34
Copy link

Hey again @haircommander 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @haircommander 👋 Enhancements Lead here,
With kubernetes/kubernetes#119390 merged as per the issue description I updated above, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@Rishit-dagli
Copy link
Member

Hello @haircommander wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42013

@haircommander
Copy link
Contributor Author

thank you! I have moved it out of draft

@katcosgrove
Copy link

Hey y'all! I'm swinging by for the v1.28 Docs team. Today is the docs deadline. Is there anything we can help you with to get this merged?

@haircommander
Copy link
Contributor Author

sorry I am updating it now, I will get this done soon.

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.29
/stage beta
/label lead-opted-in

@sohankunkerkar
Copy link
Contributor

@drewhagen Thanks for your patience. Here's the link for the placeholder PR: kubernetes/website#43542

@kcmartin
Copy link

Hi @sohankunkerkar @haircommander! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@salehsedghpour
Copy link
Contributor

Hey again @sohankunkerkar @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs (including kubernetes/kubernetes#121193, I guess) of this KEP under beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@npolshakova
Copy link

Hello @sohankunkerkar @haircommander 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Nov 1, 2023
@npolshakova
Copy link

With kubernetes/kubernetes#121193 merged this is now marked as tracked for code freeze for 1.29! 🚀

@pacoxu pacoxu mentioned this issue Nov 9, 2023
Closed
jpbetz added a commit to jpbetz/enhancements that referenced this issue Nov 22, 2023
@jpbetz
Request to be promoted to PRR approver
85bbe9f 
Shadow contributions:
- 1.27 shadow reviews: 6
- 1.28 shadow reviews: 9
- 1.29 - did not shadow due to time constraints with new SIG API Machinery TL role

Planned contributions:
- 1.30+ contribute to PRR, able to review roughly 12 KEPs per release.  I am happy to PRR more than 12 so long as they are SIG API Machinery KEPs, since I'll be reviewing those anyway..

Shadow reviewer promotion criteria:

Transitions from new to alpha

- kubernetes#3983
- kubernetes#3751

Transitions from alpha to beta

- kubernetes#3107
- kubernetes#2485

Transitions from beta to GA

- kubernetes#2268

Three enhancements that require coordination between multiple components.

- kubernetes#3751
- kubernetes#2485
- kubernetes#3107

Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

- kubernetes#2268 (component skew)
- kubernetes#2485 (component skew)
- kubernetes#3751 (HA skew - feature gated fields, component skew)
kubernetes#2268 (HA skew of controller considered)

Three enhancements that are outside your primary domain.

- kubernetes#3983 (SIG Node)
- kubernetes#3751 (SIG Storage)
- kubernetes#2268 (SIG Node)
- kubernetes#3107 (SIG Storage)

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

- Yes. E.g. kubernetes#2268 (ability to analyze cluster in aggregate considered, rescheduling considered)

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

- Yes. E.g. kubernetes#3751 (new API call, volume of calls considered)
@jpbetz jpbetz mentioned this issue Nov 22, 2023
Merged
@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@sohankunkerkar sohankunkerkar mentioned this issue Jan 19, 2024
Merged
@SergeyKanzhelev
Copy link
Member

/stage beta
/milestone v1.30

(as per #4419)

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 1, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@AnaMMedina21
Copy link

Hello @haircommander👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: V1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@SergeyKanzhelev
Copy link
Member

@sohankunkerkar @haircommander when working on documentation for the feature, it would be nice if you can compare how the merge logic same/differ from the kubeadm logic mentioned here: #4031 (comment)

kubeadm patch mechanism replacement is not a goal, but since it is already being used, it is a good way to check usability of drop-in configuration

@celestehorgan
Copy link

Hi @sohankunkerkar @haircommander!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

===

I notice that your Alpha PR was empty and closed due to this going Beta in 1.30. Let us know if you need any help deciding what needs writing :)

@sohankunkerkar
Copy link
Contributor

Hi @celestehorgan, Thank you for the reminder. I have submitted a PR for updating the documentation to the main branch. Upon merging, I will open a PR targeting the 1.30-dev branch. To provide some context, this feature was originally planned for Beta release in 1.29. However, due to last-minute bug fixes, we decided to delay the move to Beta and allow for some soak time before proceeding. Since there were no significant changes to the feature, I did not update the documentation in 1.29, which is why you see an empty PR, but thanks for the help :)

@Checksumz
Copy link

Hi @haircommander ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@AnaMMedina21
Copy link

Hello @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@wangzhen127
Copy link
Member

Hi @haircommander, I am interested at this feature. I saw in the KEP that during beta phase, it includes "Implement the capability to query the kubelet's full effective configuration via API, covering both standard mode and standalone kubelet mode." Have we had this capability already? Can you share how to query the kubelet's full effective config? Thanks!

@sohankunkerkar
Copy link
Contributor

wangzhen127 Thanks for your interest. Today, we can query the Kubelet config by setting up the kubectl proxy and using a curl command to query the /configz endpoint (curl -X GET http://127.0.0.1:8001/api/v1/nodes/<node-name>/proxy/configz | jq .). This is more of a gap in the Kubernetes documentation. Additionally, we need to refine the language used in the KEP to make it sound more like a documentation request than an implementation.

@wangzhen127
Copy link
Member

Ah, I see. Thanks for the clarification! So basically kubectl get --raw "/api/v1/nodes/<nodename>/proxy/configz" | jq

@sohankunkerkar
Copy link
Contributor

Ah, I see. Thanks for the clarification! So basically kubectl get --raw "/api/v1/nodes/<nodename>/proxy/configz" | jq

Yeah,that's another way to query the configz endpoint.

@sohankunkerkar
Copy link
Contributor

@AnaMMedina21 Thanks for the reminder. Could you exclude the docs PR from the code freeze tracker? The code PR has already merged.

@salehsedghpour
Copy link
Contributor

Hello @haircommander 👋 , Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

@dipesh-rawat dipesh-rawat mentioned this issue Mar 8, 2024
Open
@sohankunkerkar sohankunkerkar mentioned this issue Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohankunkerkar sohankunkerkar

Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
1.28 Enhancements Tracking
Status: Tracked
1.29 Enhancements Tracking
Status: Tracked for Code Freeze
1.30 Enhancements Tracking
Status: Tracked for Doc Freeze
Milestone
v1.30
Development

No branches or pull requests