Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown Version Interoperability Proxy #4020

Open
10 tasks done
richabanker opened this issue May 17, 2023 · 20 comments
Open
10 tasks done

Unknown Version Interoperability Proxy #4020

richabanker opened this issue May 17, 2023 · 20 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@richabanker
Copy link
Contributor

richabanker commented May 17, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 17, 2023
@richabanker
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 2, 2023

/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 2, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 2, 2023
@Atharva-Shinde
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 5, 2023
@ruheenaansari34
Copy link

Hello @richabanker 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to take care of:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hey @richabanker
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@AdminTurnedDevOps
Copy link

Hey @richabanker

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@richabanker
Copy link
Contributor Author

richabanker commented Jun 22, 2023

Thanks @AdminTurnedDevOps, added a placeholder PR kubernetes/website#41723

Edit: modified above PR to a blog PR, and created a new documentation PR here kubernetes/website#42147

@ruheenaansari34
Copy link

Hey again @richabanker 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023.

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@richabanker
Copy link
Contributor Author

Hi @ruheenaansari34, thanks for the reminder. Updated the issue description.

@richabanker
Copy link
Contributor Author

All code update PRs are merged for this feature.

@Atharva-Shinde
Copy link
Contributor

Hey @richabanker 👋 Enhancements Lead here,
With kubernetes/kubernetes#118386,
kubernetes/kubernetes#119272 and
kubernetes/kubernetes#117740 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze! Thanks

@Rishit-dagli
Copy link
Member

Hello @richabanker wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#41723

@Ritikaa96
Copy link
Contributor

I get the name was changed as per discussion here
Will the feature gate: UnknownVersionInteroperabilityProxy be renamed as well?

@richabanker
Copy link
Contributor Author

I get the name was changed as per discussion here Will the feature gate: UnknownVersionInteroperabilityProxy be renamed as well?

I would prefer consistency across docs and code, so I think we should change the feature gate name as well. But since its code freeze right now, that change can happen after the freeze is lifted. @jpbetz what are your thoughts on this?

@jpbetz
Copy link
Contributor

jpbetz commented Jul 27, 2023

I get the name was changed as per discussion here Will the feature gate: UnknownVersionInteroperabilityProxy be renamed as well?

I would prefer consistency across docs and code, so I think we should change the feature gate name as well. But since its code freeze right now, that change can happen after the freeze is lifted. Joe Betz what are your thoughts on this?

I would also prefer the consistency.

But once 1.28.0 is published, we're forever stuck with the name for the 1.28 minor version. I'm also not convinced that renaming it to a more consistent name in 1.29 is a net benefit to users.

This ship may have already sailed.

@Ritikaa96
Copy link
Contributor

I get the name was changed as per discussion here Will the feature gate: UnknownVersionInteroperabilityProxy be renamed as well?

I would prefer consistency across docs and code, so I think we should change the feature gate name as well. But since its code freeze right now, that change can happen after the freeze is lifted. Joe Betz what are your thoughts on this?

I would also prefer consistency.

But once 1.28.0 is published, we're forever stuck with the name for the 1.28 minor version. I'm also not convinced that renaming it to a more consistent name in 1.29 is a net benefit to users.

This ship may have already sailed.

Noted. FWIW if the feature gate and feature name are the same, it will be easier for a user to remember (and not confused in some rare cases) which feature gate they needed to enable when kube - apiserver is started. It might be a matter of user convenience. Though I understand the reasoning behind leaving it as is due to the code freeze.

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Apr 16, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked
Development

No branches or pull requests